From nobody Sun Jun 16 12:46:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605028587; cv=none; d=zohomail.com; s=zohoarc; b=mH0QUqziMGzhd9QeOpYhPGS3ElEVpBdqjhVRb3+jj//eTud+AEXDnx99+MozO0acLsn/ADdEfo425aBQA0s71oHKVSCcmkBDyz9nyvvvOTVri4AT4M0vyzhc+4v+RFglUDTAO5dGmo+WQTo+00uGWbP8Bbbgr/rhA3CXO6srizE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605028587; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ztUh/VqhRg/dQv63Nr/DaKjDjS8XUjA1d7lTXeIFruU=; b=d7aURJbJwFhJ7fROGrG/0vR7iPPLCeODEh1gfBi4OztLLuY2DuvZI7Y7Hcs1YlMq9m1rChSo8XQuVGEbldpr9aiKtrYKaD0CMnhEXnGZfYDP++y0wzxLta5Ta47eWLLGEofUTADt4Budk9j5EqfQJ8imNxXvN1SSZLcliyU+O54= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605028587840542.97044423582; Tue, 10 Nov 2020 09:16:27 -0800 (PST) Received: from localhost ([::1]:42726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcXFr-0006Z3-3p for importer@patchew.org; Tue, 10 Nov 2020 12:16:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcXBI-0002KO-1x for qemu-devel@nongnu.org; Tue, 10 Nov 2020 12:11:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kcXBF-0001aR-PO for qemu-devel@nongnu.org; Tue, 10 Nov 2020 12:11:43 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-tr3hW0-KPzaa_qJk-Sj-Pg-1; Tue, 10 Nov 2020 12:11:38 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B9A6E191E2A2; Tue, 10 Nov 2020 17:11:37 +0000 (UTC) Received: from localhost (ovpn-114-36.ams2.redhat.com [10.36.114.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 37E5D5B4CD; Tue, 10 Nov 2020 17:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605028300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ztUh/VqhRg/dQv63Nr/DaKjDjS8XUjA1d7lTXeIFruU=; b=SDxp3gfMJZ6rjzYDe7AKvq+8tdFOuq65jrPp3RBGeKXaBYQnYm+TXNNRmyQTx5kB/LKfrV 5Pcn7S3M6a4RcfPntRD5+yqin1+z4DiSFVYKiU8QIzCaQ8OYoCG1qzDFU6vXigqA8ooOyp PSKJqOpxB+w7uYE/ScZNapmkE6+yL/0= X-MC-Unique: tr3hW0-KPzaa_qJk-Sj-Pg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 1/3] meson: move vhost_user_blk_server to meson.build Date: Tue, 10 Nov 2020 17:11:19 +0000 Message-Id: <20201110171121.1265142-2-stefanha@redhat.com> In-Reply-To: <20201110171121.1265142-1-stefanha@redhat.com> References: <20201110171121.1265142-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/10 02:00:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , qemu-block@nongnu.org, "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Max Reitz , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The --enable/disable-vhost-user-blk-server options were implemented in ./configure. There has been confusion about them and part of the problem is that the shell syntax used for setting the default value is not easy to read. Move the option over to meson where the conditions are easier to understand: have_vhost_user_blk_server =3D (targetos =3D=3D 'linux') if get_option('vhost_user_blk_server').enabled() if targetos !=3D 'linux' error('vhost_user_blk_server requires linux') endif elif get_option('vhost_user_blk_server').disabled() or not have_system have_vhost_user_blk_server =3D false endif This patch does not change behavior. Signed-off-by: Stefan Hajnoczi Tested-by: Philippe Mathieu-Daud=C3=A9 --- meson_options.txt | 2 ++ configure | 16 ++++------------ meson.build | 12 ++++++++++++ block/export/meson.build | 5 ++++- 4 files changed, 22 insertions(+), 13 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index b4f1801875..f6f64785fe 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -64,6 +64,8 @@ option('xkbcommon', type : 'feature', value : 'auto', description: 'xkbcommon support') option('virtiofsd', type: 'feature', value: 'auto', description: 'build virtiofs daemon (virtiofsd)') +option('vhost_user_blk_server', type: 'feature', value: 'auto', + description: 'build vhost-user-blk server') =20 option('capstone', type: 'combo', value: 'auto', choices: ['disabled', 'enabled', 'auto', 'system', 'internal'], diff --git a/configure b/configure index 805f779150..5ae73fa32c 100755 --- a/configure +++ b/configure @@ -329,7 +329,7 @@ vhost_crypto=3D"" vhost_scsi=3D"" vhost_vsock=3D"" vhost_user=3D"" -vhost_user_blk_server=3D"" +vhost_user_blk_server=3D"auto" vhost_user_fs=3D"" kvm=3D"auto" hax=3D"auto" @@ -1247,9 +1247,9 @@ for opt do ;; --enable-vhost-vsock) vhost_vsock=3D"yes" ;; - --disable-vhost-user-blk-server) vhost_user_blk_server=3D"no" + --disable-vhost-user-blk-server) vhost_user_blk_server=3D"disabled" ;; - --enable-vhost-user-blk-server) vhost_user_blk_server=3D"yes" + --enable-vhost-user-blk-server) vhost_user_blk_server=3D"enabled" ;; --disable-vhost-user-fs) vhost_user_fs=3D"no" ;; @@ -2388,12 +2388,6 @@ if test "$vhost_net" =3D ""; then test "$vhost_kernel" =3D "yes" && vhost_net=3Dyes fi =20 -# libvhost-user is Linux-only -test "$vhost_user_blk_server" =3D "" && vhost_user_blk_server=3D$linux -if test "$vhost_user_blk_server" =3D "yes" && test "$linux" =3D "no"; then - error_exit "--enable-vhost-user-blk-server is only available on Linux" -fi - ########################################## # pkg-config probe =20 @@ -6287,9 +6281,6 @@ fi if test "$vhost_vdpa" =3D "yes" ; then echo "CONFIG_VHOST_VDPA=3Dy" >> $config_host_mak fi -if test "$vhost_user_blk_server" =3D "yes" ; then - echo "CONFIG_VHOST_USER_BLK_SERVER=3Dy" >> $config_host_mak -fi if test "$vhost_user_fs" =3D "yes" ; then echo "CONFIG_VHOST_USER_FS=3Dy" >> $config_host_mak fi @@ -7010,6 +7001,7 @@ NINJA=3D$ninja $meson setup \ -Dcapstone=3D$capstone -Dslirp=3D$slirp -Dfdt=3D$fdt \ -Diconv=3D$iconv -Dcurses=3D$curses -Dlibudev=3D$libudev\ -Ddocs=3D$docs -Dsphinx_build=3D$sphinx_build -Dinstall_blobs=3D$b= lobs \ + -Dvhost_user_blk_server=3D$vhost_user_blk_server \ $cross_arg \ "$PWD" "$source_path" =20 diff --git a/meson.build b/meson.build index f5175010df..4f5c916557 100644 --- a/meson.build +++ b/meson.build @@ -751,6 +751,16 @@ statx_test =3D ''' =20 has_statx =3D cc.links(statx_test) =20 +have_vhost_user_blk_server =3D (targetos =3D=3D 'linux') + +if get_option('vhost_user_blk_server').enabled() + if targetos !=3D 'linux' + error('vhost_user_blk_server requires linux') + endif +elif get_option('vhost_user_blk_server').disabled() or not have_system + have_vhost_user_blk_server =3D false +endif + ################# # config-host.h # ################# @@ -775,6 +785,7 @@ config_host_data.set('CONFIG_MPATH_NEW_API', mpathpersi= st_new_api) config_host_data.set('CONFIG_CURSES', curses.found()) config_host_data.set('CONFIG_SDL', sdl.found()) config_host_data.set('CONFIG_SDL_IMAGE', sdl_image.found()) +config_host_data.set('CONFIG_VHOST_USER_BLK_SERVER', have_vhost_user_blk_s= erver) config_host_data.set('CONFIG_VNC', vnc.found()) config_host_data.set('CONFIG_VNC_JPEG', jpeg.found()) config_host_data.set('CONFIG_VNC_PNG', png.found()) @@ -2107,6 +2118,7 @@ summary_info +=3D {'vhost-crypto support': config_hos= t.has_key('CONFIG_VHOST_CRYPT summary_info +=3D {'vhost-scsi support': config_host.has_key('CONFIG_VHOST= _SCSI')} summary_info +=3D {'vhost-vsock support': config_host.has_key('CONFIG_VHOS= T_VSOCK')} summary_info +=3D {'vhost-user support': config_host.has_key('CONFIG_VHOST= _KERNEL')} +summary_info +=3D {'vhost-user-blk server support': have_vhost_user_blk_se= rver} summary_info +=3D {'vhost-user-fs support': config_host.has_key('CONFIG_VH= OST_USER_FS')} summary_info +=3D {'vhost-vdpa support': config_host.has_key('CONFIG_VHOST= _VDPA')} summary_info +=3D {'Trace backends': config_host['TRACE_BACKENDS']} diff --git a/block/export/meson.build b/block/export/meson.build index 19526435d8..135b356775 100644 --- a/block/export/meson.build +++ b/block/export/meson.build @@ -1,2 +1,5 @@ blockdev_ss.add(files('export.c')) -blockdev_ss.add(when: 'CONFIG_VHOST_USER_BLK_SERVER', if_true: files('vhos= t-user-blk-server.c')) + +if have_vhost_user_blk_server + blockdev_ss.add(files('vhost-user-blk-server.c')) +endif --=20 2.28.0 From nobody Sun Jun 16 12:46:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605028595; cv=none; d=zohomail.com; s=zohoarc; b=PxCOBakD68oikB4DUkY2UqEpN9vQjW6YgFb69f5Y3WBx6ZBYEjc9RlxTBW55biFBEsAE9uED42hmTDYFlVlUbmYxdQD7PXWcqNxAUSb8QJ2mV4WK+bscD3cuwInngj1A+g32ID6m4H2cXGknx7pbhqfLca+ASY9TGPEIgLtg96c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605028595; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lijNlQoal5CZP324ogddw/V1oy4mBUppSaqJxytQpOE=; b=OQg7p7F9Ku7pMBxUVpK66NCVwyGGxe2NrXqT4d5hjgj7j09kxrM4fpqNYxcsCAsymrWKwpnOmIbtG5Dz4Byp/iMZnrTFCw8lXTX6dSHL7IcqSDHbywbmUlmDLS5aWtSbDVTNDAIGB8uzZrA+qV67FV/rEO2Wi7/u5irwcd5mv2Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605028595751521.1898243360786; Tue, 10 Nov 2020 09:16:35 -0800 (PST) Received: from localhost ([::1]:43168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcXFz-0006k2-1U for importer@patchew.org; Tue, 10 Nov 2020 12:16:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcXBR-0002dd-Pg for qemu-devel@nongnu.org; Tue, 10 Nov 2020 12:11:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kcXBO-0001e1-27 for qemu-devel@nongnu.org; Tue, 10 Nov 2020 12:11:53 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-523-b4uD9JWLN7OhBdW4TuecsQ-1; Tue, 10 Nov 2020 12:11:47 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6D4DF1006C9D; Tue, 10 Nov 2020 17:11:46 +0000 (UTC) Received: from localhost (ovpn-114-36.ams2.redhat.com [10.36.114.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44DBF1002C09; Tue, 10 Nov 2020 17:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605028309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lijNlQoal5CZP324ogddw/V1oy4mBUppSaqJxytQpOE=; b=VBpFxVQ/wneP6oE+X86ZYzVee4hqXWknBBUcqmbMwJGUiYzAMLomkY2m4JlCfpMFoe/8bL LMFwBWDIC+7L+alT9H0kwIi2l1TNSr2nBpJS4T4iEBLHzIA0BHGhbFVh9m8SMcHsMLQszl OjTx2obAH0jaC6rft45EH8WtV30fjYQ= X-MC-Unique: b4uD9JWLN7OhBdW4TuecsQ-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 2/3] vhost-user-blk-server: depend on CONFIG_VHOST_USER Date: Tue, 10 Nov 2020 17:11:20 +0000 Message-Id: <20201110171121.1265142-3-stefanha@redhat.com> In-Reply-To: <20201110171121.1265142-1-stefanha@redhat.com> References: <20201110171121.1265142-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/10 02:00:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , qemu-block@nongnu.org, "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Max Reitz , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" I interpreted CONFIG_VHOST_USER as controlling only QEMU's vhost-user device frontends. However, virtiofsd and contrib/ vhost-user device backends are also controlled by CONFIG_VHOST_USER. Make the vhost-user-blk server depend on CONFIG_VHOST_USER for consistency. Now the following error is printed when the vhost-user-blk server is enabled without CONFIG_VHOST_USER: $ ./configure --disable-vhost-user --enable-vhost-user-blk ... ../meson.build:761:8: ERROR: Problem encountered: vhost_user_blk_server r= equires vhost-user support Suggested-by: Philippe Mathieu-Daud=C3=A9 Suggested-by: Alex Benn=C3=A9e Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 4f5c916557..ee3719da39 100644 --- a/meson.build +++ b/meson.build @@ -751,11 +751,14 @@ statx_test =3D ''' =20 has_statx =3D cc.links(statx_test) =20 -have_vhost_user_blk_server =3D (targetos =3D=3D 'linux') +have_vhost_user_blk_server =3D (targetos =3D=3D 'linux' and + 'CONFIG_VHOST_USER' in config_host) =20 if get_option('vhost_user_blk_server').enabled() if targetos !=3D 'linux' error('vhost_user_blk_server requires linux') + elif 'CONFIG_VHOST_USER' not in config_host + error('vhost_user_blk_server requires vhost-user support') endif elif get_option('vhost_user_blk_server').disabled() or not have_system have_vhost_user_blk_server =3D false --=20 2.28.0 From nobody Sun Jun 16 12:46:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605028889; cv=none; d=zohomail.com; s=zohoarc; b=RBECtWG6JiWztIQ4bJDP+HT4o0mGzWlTK+k/tiTcht40RelqrP9H7hSSLH9Jq8cqqyQngekyR+IvE2xSO6ymC6fqq+DlQdYqBm0Y+yy1tj7aNORHxmHYmV5oiebuGnC2VxaW90LBQCU9kMKRf/wkttu4NejEOyNzI0Cn56wQ6fU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605028889; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=d9dfRSaJbUyc6EkbObGXJdWxSJMbqgSGbpCcBqSsK+o=; b=dqIQeplQ+CxvOpPm+T71uukR5LKKAlX9vT+ZJOO7aj5Wr2pbDOX05eYcsCDdp58hzIuEXUBuE7Ru368SnQj6DifKKas9MEpVW28PuVGFpLGngUdk1SdbN78EdazWUJkMkKeZOOCbRQfQpCxC6QrvDtt49XuPJ3Agt0+IVOHayJA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1605028889977389.76573817134715; Tue, 10 Nov 2020 09:21:29 -0800 (PST) Received: from localhost ([::1]:54272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcXKi-0002yL-N0 for importer@patchew.org; Tue, 10 Nov 2020 12:21:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcXBb-0002rA-KR for qemu-devel@nongnu.org; Tue, 10 Nov 2020 12:12:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:58577) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kcXBW-0001gM-Pn for qemu-devel@nongnu.org; Tue, 10 Nov 2020 12:12:01 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-ot-1aJ_GO1Ku3yEwUIIaHw-1; Tue, 10 Nov 2020 12:11:55 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 952C456C36; Tue, 10 Nov 2020 17:11:54 +0000 (UTC) Received: from localhost (ovpn-114-36.ams2.redhat.com [10.36.114.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF2F2385; Tue, 10 Nov 2020 17:11:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605028317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d9dfRSaJbUyc6EkbObGXJdWxSJMbqgSGbpCcBqSsK+o=; b=NNI04F7CHGs/74Pvbmx3u2SUa/zhKUPDU0Ue6n+lZ3DWE90G0VFBR/DZ38hvXFmBUAeQjo Ej8NtSKDO0+Jf4UUvf3/D/rZLcyyOOxVIkQu0cP3i2NiWjWDz7Bjmcl36q5dponBXtfU5j IFk7J7kmBbMFgbUZ/2Bk9Ov2Di19144= X-MC-Unique: ot-1aJ_GO1Ku3yEwUIIaHw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 3/3] configure: mark vhost-user Linux-only Date: Tue, 10 Nov 2020 17:11:21 +0000 Message-Id: <20201110171121.1265142-4-stefanha@redhat.com> In-Reply-To: <20201110171121.1265142-1-stefanha@redhat.com> References: <20201110171121.1265142-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/10 00:21:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , qemu-block@nongnu.org, "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Max Reitz , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The vhost-user protocol uses the Linux eventfd feature and is typically connected to Linux kvm.ko ioeventfd and irqfd file descriptors. The protocol specification in docs/interop/vhost-user.rst does not describe how platforms without eventfd support work. The QEMU vhost-user devices compile on other POSIX host operating systems because eventfd usage is abstracted in QEMU. The libvhost-user programs in contrib/ do not compile but we failed to notice since they are not built by default. Make it clear that vhost-user is only supported on Linux for the time being. If someone wishes to support it on other platforms then the details can be added to vhost-user.rst and CI jobs can test the feature to prevent bitrot. Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Tested-by: Philippe Mathieu-Daud=C3=A9 --- configure | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 5ae73fa32c..ef431f86c0 100755 --- a/configure +++ b/configure @@ -328,7 +328,7 @@ vhost_net=3D"" vhost_crypto=3D"" vhost_scsi=3D"" vhost_vsock=3D"" -vhost_user=3D"" +vhost_user=3D"no" vhost_user_blk_server=3D"auto" vhost_user_fs=3D"" kvm=3D"auto" @@ -718,7 +718,6 @@ fi case $targetos in MINGW32*) mingw32=3D"yes" - vhost_user=3D"no" audio_possible_drivers=3D"dsound sdl" if check_include dsound.h; then audio_drv_list=3D"dsound" @@ -797,6 +796,7 @@ Linux) audio_possible_drivers=3D"oss alsa sdl pa" linux=3D"yes" linux_user=3D"yes" + vhost_user=3D"yes" ;; esac =20 @@ -2339,9 +2339,8 @@ fi # vhost interdependencies and host support =20 # vhost backends -test "$vhost_user" =3D "" && vhost_user=3Dyes -if test "$vhost_user" =3D "yes" && test "$mingw32" =3D "yes"; then - error_exit "vhost-user isn't available on win32" +if test "$vhost_user" =3D "yes" && test "$linux" !=3D "yes"; then + error_exit "vhost-user is only available on Linux" fi test "$vhost_vdpa" =3D "" && vhost_vdpa=3D$linux if test "$vhost_vdpa" =3D "yes" && test "$linux" !=3D "yes"; then --=20 2.28.0