From nobody Wed May 8 18:16:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1604934499; cv=none; d=zohomail.com; s=zohoarc; b=VNuZkvgyiOSChgjqRq3pP/hxzft/d7on4rTM+f4g7DIFaLC9C1wVXIJkVA7Zh14KvLI/D6CuSbpQ1zVsT20S2u6bX74PZwthkpAeRgpgaf3eeXv/rajUm3STBk/fUTPjBBsV4WT0pU1rbMZJZNaw6h3eovA7Jf/tR787cBC7B1E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604934499; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=CILW7Q+jMcCFlKzsmwexTUwuOZBWDrgnAlppGT8xQ9Y=; b=Xi9pLpivQoonAnF2k6CzCOKKBZPRDU7210XtpT2cj7eoWMEyRc7pM8gEOtxcTAHfsVW4gnnXurrz192QxrTtuiEI4TJMUdnDTLq7SvWC7VvjxNmwhb3tBp9BtC0K6PbBwZN+cUZ/tvKvQqDGRxWZ8CcK9fqRvHbEZVQY34XZcSE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604934499562155.6329132351866; Mon, 9 Nov 2020 07:08:19 -0800 (PST) Received: from localhost ([::1]:43794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc8mG-0003lL-E3 for importer@patchew.org; Mon, 09 Nov 2020 10:08:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc8jc-0002H0-LE for qemu-devel@nongnu.org; Mon, 09 Nov 2020 10:05:32 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:38250) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kc8jW-0004kS-JM for qemu-devel@nongnu.org; Mon, 09 Nov 2020 10:05:32 -0500 Received: by mail-wm1-x342.google.com with SMTP id h62so8220766wme.3 for ; Mon, 09 Nov 2020 07:05:26 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id n10sm3360378wrv.77.2020.11.09.07.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 07:05:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CILW7Q+jMcCFlKzsmwexTUwuOZBWDrgnAlppGT8xQ9Y=; b=Zr3xqPAA+87LrmH0N9DXpinXlr1Wo9wFOOXHbdkLdT544CCv0tFDoavDlgEtvLdOAR oIOUKSRBo/mVLK3d1tLWftdiMY9mb/dW82WazsZggFpiLWSrPAHgnKRoolvH3QlEYtq4 4vR8CFC+xdFTLxSh0haehnYfb0obOHeep+qhdVoPhkv7Imw2fZ2zofHy+mPpYQkZgg84 Qdi9P3gtiG04NE4tTdZ9OSAuxey6LaOtd3P+nXVgVEO5KDtYwNOPHyOY1HjKrFNS16oN 2P/R1udZmoRBYMZBHnChoaUkEz9yjrLhZIc2mIOH31FSOK/l8+eJNQD1gI16KDXyuFMv XJSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CILW7Q+jMcCFlKzsmwexTUwuOZBWDrgnAlppGT8xQ9Y=; b=J3lL8PMj1hlvE+qqdqfRlv/8E2cvca6jmHLv6dlhx3Nq1t8mZVpb2CBtwjwrMv+8rt 012SfmXLSJOnDkTef9Fxis0cbcb+6DbsPqRvsJdwDC7Vnmr/LBez7SNyaXZdDbYJv8Kp VNcNJ74G945TKDKLcahJkuFPNFohjBe7cWUxYY05BVbq8Uwbca3u5nyVf02H4A2/Ih42 wrY/uLF/a3nuWiBn50Ycc3lqDmyoRNTnw7llioJ9/hlavnVa4x8bGEEOzzrlh6fSPV1f crAmoCsZXyEecS230RoRiRMuDaYDo14N2hOPYTpVZWeYLXYsu7YYFC1Dzu0Jy+DHp6gQ hhqQ== X-Gm-Message-State: AOAM533NtpgEDuVOwf8Z9ISK/9DXb1QJB+6U/CNjWs+yKYFPtHY7xAZP /3BjuaR+jUIBmVz1u3EgXGI57z4SQB/4oQ== X-Google-Smtp-Source: ABdhPJzxlaoWxK1hN0P14tQR+3Xeih6tfUbAgZvYJUjsM4hb9J+5kdSB4HbO+bYjCnYfgEnRDpy+IQ== X-Received: by 2002:a1c:f002:: with SMTP id a2mr15788906wmb.129.1604934324094; Mon, 09 Nov 2020 07:05:24 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH for-5.2] block/export/vhost-user-blk-server.c: Avoid potential integer overflow Date: Mon, 9 Nov 2020 15:05:22 +0000 Message-Id: <20201109150522.10350-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Coiby Xu , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" In vu_blk_discard_write_zeroes(), we read a 32-bit sector count from the descriptor and convert it to a 64-bit byte count. Coverity warns that the left shift is done with 32-bit arithmetic so it might overflow before the conversion to 64-bit happens. Add a cast to avoid this. Fixes: Coverity CID 1435956 Signed-off-by: Peter Maydell --- Tested with 'make check' and 'make check-acceptance' only. --- block/export/vhost-user-blk-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user= -blk-server.c index 62672d1cb95..e5749451e65 100644 --- a/block/export/vhost-user-blk-server.c +++ b/block/export/vhost-user-blk-server.c @@ -70,7 +70,7 @@ vu_blk_discard_write_zeroes(BlockBackend *blk, struct iov= ec *iov, } =20 uint64_t range[2] =3D { le64_to_cpu(desc.sector) << 9, - le32_to_cpu(desc.num_sectors) << 9 }; + (uint64_t)le32_to_cpu(desc.num_sectors) << 9 }; if (type =3D=3D VIRTIO_BLK_T_DISCARD) { if (blk_co_pdiscard(blk, range[0], range[1]) =3D=3D 0) { return 0; --=20 2.20.1