From nobody Mon Feb 9 23:57:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604929995; cv=none; d=zohomail.com; s=zohoarc; b=Vd+ZuIzNbZDMVjftWBWsKi3HKM5bQNj8QjV0fb5sww48uysvk9bN027VeK0+oo6vRFZ5KhcDwqh+BdAHDGuhelL+B/s9KDFJgS66i4nYwtcY8Wn7EuSM14pmkhKOXLnnh96JKYdSS9URunuwaH4gMgpLtiGrtA1+f/8hY7Pi7EU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604929995; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=0AwdT5nD9C6a2wsBgla1NUJAfuZdmUfnrRvAnSbIFbU=; b=lY59q+A9Dde1Pg2lKOCKVS3yhxbFGeosW7fBFnSxJCdLI6KRMHUm26gQI24c+/rhSZIIk+EjLGKu2oEcwKYdZwCX300CHMRHxE9gFXTgrRtOnNAin/nneR42+Qb4uQZrzK20KTrz9jli108lxkIBE22wzZf+o+qRIKovC6Sb9WY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1604929995564985.4056013106726; Mon, 9 Nov 2020 05:53:15 -0800 (PST) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-306-09YP5NojNj-9cpRgR2LL7g-1; Mon, 09 Nov 2020 08:53:12 -0500 Received: by mail-wr1-f70.google.com with SMTP id q15so4353843wrw.8 for ; Mon, 09 Nov 2020 05:53:12 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id d63sm12759895wmd.12.2020.11.09.05.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 05:53:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604929994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0AwdT5nD9C6a2wsBgla1NUJAfuZdmUfnrRvAnSbIFbU=; b=YDeUVrH+Su3ILu0p8M27M2aRjbHpWiH2SnJ3rz9EOUhp806YjplHHDtrUBnKifEG+iL0bu ylhLMjCwPuZicUTsD4FoEvg7NPD/8qglmAoXqA0+C0fKG9PQNi+uigTSZ76AnEAIe/4Ep1 JtvuNMoun4aMwSO9UrhuwMudWXEIbIg= X-MC-Unique: 09YP5NojNj-9cpRgR2LL7g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0AwdT5nD9C6a2wsBgla1NUJAfuZdmUfnrRvAnSbIFbU=; b=C9nIAX5Ai7OFO3Gs1VxBWmKzKKNeRKxJQZWCUbmvufc6za6ReQjfNLtF/77xi1JD/X zws0SIZwvIPi4mxEr0GGJqwgmsmZjSIdrMos4Z4/e2PJA9/FnA+EX1ROVOS8HPcYQDRH jqSXPK5CCTOIhbQRyXUoQR9dM1MSVdNBQgM+WbrHVZrnP5SZCLyocVs2M6ABJr94xpCa V4DPpRT5vMOfN4AbV1vXu473B4iqLkrlbaNeFKnooC9djDKyyYNoEWwYjjEN9rmFpHwr Gvfj6I3DJkWvgeNlMerDxwZWusoeXzM+B1wXVGPHC/ClvfqIYSdrI6IpP+gkyF14SkAr eXDA== X-Gm-Message-State: AOAM5318b9DPZ8+Q5C3QtBZj2V38s91njYrWA0n+KiyEv19i9CS3L1Ej LmafyRlPSDS2vjeuGkg/V2kGwrugW23vhBpyx8q8CymUx6zgz50JvPxpLP36kB+ehFXqUV0aRPE 6Ny2R9YkyBjEuKQ== X-Received: by 2002:adf:f4c9:: with SMTP id h9mr17434012wrp.332.1604929991701; Mon, 09 Nov 2020 05:53:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJyS13YtWVGV4xyRVW/8sdcn1Yh9NSAnalNkNNnI7imRHv0kEIVO1b6rNDIHmsB1kLS3hNASvw== X-Received: by 2002:adf:f4c9:: with SMTP id h9mr17433999wrp.332.1604929991583; Mon, 09 Nov 2020 05:53:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-6.0 v2 2/4] hw/usb/hcd-xhci: Restrict TYPE_XHCI to hw/usb/ Date: Mon, 9 Nov 2020 14:52:58 +0100 Message-Id: <20201109135300.2592982-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201109135300.2592982-1-philmd@redhat.com> References: <20201109135300.2592982-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) TYPE_XHCI is not a generic device meant to be instantiated by QOM objects outside of hw/usb/. Do not expose the type in public namespace (via include/). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/usb/hcd-xhci.h | 1 + include/hw/usb/xhci.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci.h b/hw/usb/hcd-xhci.h index ccf50ae28be..f7150a7e12b 100644 --- a/hw/usb/hcd-xhci.h +++ b/hw/usb/hcd-xhci.h @@ -27,6 +27,7 @@ #include "hw/usb/xhci.h" #include "sysemu/dma.h" =20 +#define TYPE_XHCI "base-xhci" OBJECT_DECLARE_SIMPLE_TYPE(XHCIState, XHCI) =20 /* Very pessimistic, let's hope it's enough for all cases */ diff --git a/include/hw/usb/xhci.h b/include/hw/usb/xhci.h index 5c90e1373e5..90b56429199 100644 --- a/include/hw/usb/xhci.h +++ b/include/hw/usb/xhci.h @@ -1,7 +1,6 @@ #ifndef HW_USB_XHCI_H #define HW_USB_XHCI_H =20 -#define TYPE_XHCI "base-xhci" #define TYPE_NEC_XHCI "nec-usb-xhci" #define TYPE_QEMU_XHCI "qemu-xhci" #define TYPE_XHCI_SYSBUS "sysbus-xhci" --=20 2.26.2