From nobody Tue Feb 10 06:58:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) client-ip=209.85.128.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1604878979; cv=none; d=zohomail.com; s=zohoarc; b=d8U1kerKxyCJ6c9XjvKW8gyc9V/RHCzIm+JXrzHMttlhwITQ256Iqj5uSHd+pPfVlqGVQ8/pfurGAxR0sPJl1aUFPot59L1G+Tnr7Frvfww1LlFrWwZyF7E2mEhf2V7L/3MBCeOkYWx5QDGfCRPl+6BMOUfiR/JewIXEkbyw10U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604878979; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pZ7rBipTKKb/oioa2rrfZq9jThonQF//eO/4l0XoKyI=; b=dvxbfx+OA5O2hq6+IC1YVYwVB2FDnoiJsfmXp994VPf2E6x/h9gf8LWLe+enumzART8S4R3wXkmr3057zyxIhChelCHmTWo1+ZS/Td57aD87Qc79Q+VZgkJOKvAaGtErpLYWhV8sKLyFy28dzNsNxeSHbAvqvCKNkh4rLxfO2zc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.zohomail.com with SMTPS id 1604878979224480.7205720995812; Sun, 8 Nov 2020 15:42:59 -0800 (PST) Received: by mail-wm1-f53.google.com with SMTP id v5so6439274wmh.1 for ; Sun, 08 Nov 2020 15:42:58 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id q2sm5431060wru.76.2020.11.08.15.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Nov 2020 15:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pZ7rBipTKKb/oioa2rrfZq9jThonQF//eO/4l0XoKyI=; b=TAWB74L0iPa1+/0eZO3xVYo4Ak2YBrRNlxxjJeeAQF9q3e0TvAO2t5Zhia5UjxKtPo 2CL/b9nHG+wyqEjpv5norwzGWYYmi+AE7fExHc/0M/k8wW0ewjJkAe624Nx4GQg4N4S8 vDv3pVwFtAPFXluckxZy7LiSmhz+c1Ry0VR4WszDWngUzuZgwKGuxgV1Vh2/BWZ1PvV5 XVSbaeTI2DM3+EFjsXuzPMUAEm20fllwNvu/dpXDtnKzRhar5u8Dn0vLbUmQzqvnAtM3 qPFcs95yYKrDPRr0GxZuLeZObyCjaLqXWXdssCTqstvFFMadHEGCVW8XvrQTJ1cSV/Kx xHSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pZ7rBipTKKb/oioa2rrfZq9jThonQF//eO/4l0XoKyI=; b=DvwHMT+eDL1JJiZmufE3L3qjCQgCVbnjxeRfLeEfDmNomZQiLiGBnnN7EnagFSs3f5 OhCFsIcoOWb06MjpKxfRawt5L1qQbUR5LtSKLkjPkvxOuOs2dMfkXt7YCDHAxsjSVhlH /RlUpo8+AE6wue5DquG+yi7Y0lni7Sm/VKWBl9qNiZAyfo3dKnjMgnjKhMuFx7Pu1Eaq NWpKhmLQmuBhNjE7ZSlNSSmWFGwjF8AidsrNB+6lQprgBZvnbnPe13O/TLTTjkYBg3xc J4ARw7CFpxqYJlv1e/rvSiYw81AJDvJrkw5nqJn5bM9br2viGGlPJLESNKGQtid5omjT iw/w== X-Gm-Message-State: AOAM533daG2i+C8DbwYgS+E/e8b/6Dx876Qtkgurz1PIKKNnE5ZjGnoZ FrbCBE8lhuiTV1IONEAJSFY= X-Google-Smtp-Source: ABdhPJxHHmCXqtltdovTPDMCeJbKlBppRVSYDARDsf2gPmzuZ1H5zmVkXLEkjGwCD2HHYK8FYPnHDQ== X-Received: by 2002:a1c:1c3:: with SMTP id 186mr11409605wmb.39.1604878977356; Sun, 08 Nov 2020 15:42:57 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paul Burton , libvir-list@redhat.com, Jiaxun Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Peter Maydell Subject: [PULL 3/3] hw/mips/boston: Fix memory leak in boston_fdt_filter() error-handling paths Date: Mon, 9 Nov 2020 00:42:34 +0100 Message-Id: <20201108234234.2389789-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201108234234.2389789-1-f4bug@amsat.org> References: <20201108234234.2389789-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Peter Maydell Coverity points out that the error-handling paths in the boston_fdt_filter() function don't free the fdt that was allocated. Fix the leak by using g_autofree. Fixes: Coverity CID 1432275 Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201106175823.1650-1-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/mips/boston.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/mips/boston.c b/hw/mips/boston.c index 3356d7a6814..3d40867dc4c 100644 --- a/hw/mips/boston.c +++ b/hw/mips/boston.c @@ -349,11 +349,9 @@ static const void *boston_fdt_filter(void *opaque, con= st void *fdt_orig, MachineState *machine =3D s->mach; const char *cmdline; int err; - void *fdt; - size_t fdt_sz, ram_low_sz, ram_high_sz; - - fdt_sz =3D fdt_totalsize(fdt_orig) * 2; - fdt =3D g_malloc0(fdt_sz); + size_t ram_low_sz, ram_high_sz; + size_t fdt_sz =3D fdt_totalsize(fdt_orig) * 2; + g_autofree void *fdt =3D g_malloc0(fdt_sz); =20 err =3D fdt_open_into(fdt_orig, fdt, fdt_sz); if (err) { @@ -380,7 +378,7 @@ static const void *boston_fdt_filter(void *opaque, cons= t void *fdt_orig, =20 s->fdt_base =3D *load_addr; =20 - return fdt; + return g_steal_pointer(&fdt); } =20 static const void *boston_kernel_filter(void *opaque, const void *kernel, --=20 2.26.2