From nobody Mon Feb 9 12:15:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604868350; cv=none; d=zohomail.com; s=zohoarc; b=nM4J2siBT/b5sDmlslIayawltfWbGIU6Ksk/6wIHJvPv5jcTlRHdycxC82M0yPYuLkGjOun2cSIxn0Kvn4z2dE2Oh7MVh41yA2tiv0btnX139tKgHHKBLY0y/NcL/xEOWpIVhd8SMBj8hKrZz6BCKJrykstcnKENbidL06aXXCM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604868350; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=mQ1UDmwFMkB+mv0qV2lzTI3NvVyFxAW3riXAc5YeNWc=; b=gebIS+tgVTtOmSBvCzPGYj+9R14JyxnWkoDH9KO2P/crnHu+LnO8AliTjubNQV/x/p3l9AJNHTW51ffRV+lI5DVDEDqEHg+Ir6chWnT5nfbGtmOyTv/hFjaUyQ/IG+8gixJuPJn6NYDMkmJT9shBUbX7tCDqIaSaOr3amYfxN/I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1604868350386337.13422424524424; Sun, 8 Nov 2020 12:45:50 -0800 (PST) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-3Wvd7rn-P3e5O4tn2ZFCiQ-1; Sun, 08 Nov 2020 15:45:45 -0500 Received: by mail-wr1-f71.google.com with SMTP id h11so3361627wrq.20 for ; Sun, 08 Nov 2020 12:45:45 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id n10sm561471wrv.77.2020.11.08.12.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Nov 2020 12:45:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604868349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mQ1UDmwFMkB+mv0qV2lzTI3NvVyFxAW3riXAc5YeNWc=; b=JhKZ2Ab7CHoJo470iaENhdGWqWcSBXFf99FG6LwPgPJq7GlQ936Y7XHjSYf2ZFsxymsDJG jPPCg4fuC0UCyaajJsXElf8c+K4MjUl4SrAzaGj1Vz7ecCeJYl0Ekj8yJHiE6fjw4sb4lg ATW4O05IODHYVP9wsN9szs3uU4X89b8= X-MC-Unique: 3Wvd7rn-P3e5O4tn2ZFCiQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mQ1UDmwFMkB+mv0qV2lzTI3NvVyFxAW3riXAc5YeNWc=; b=Eia35N1wc54ELogCybWvDGWgXs7X6x9SVrQFK+wHpBPquEvoxjvlkcXLibJvdZomOS /tEm2zUcMMBDUvFg+PIR7Hs1zuXtJJBwEqJtXsqtsTaRJ5p6UvVyqaS4ExRg2Mh62nZB /9A5/m5cQVhpCH8+WL3RMA8fB0uyyOv+z6XwiWhYLW8QKLisN4AnAOM8vilk0nC6hv8g IXO+L7i6FT8ieEzdPGFpbefm7nTXoaeyztiRaN+EZ9j9ogv2oVPxYOpZmBp+2/Ko/Z+5 jbQs9namJVKEVKPKNqsdxI6VMu0HL/YJxAvM6RyzAn/1L993r0a8lo8qXttm1LSCpK8Y XDUw== X-Gm-Message-State: AOAM5336DUohS+JNQxH5n1SUfvEuSEdDDfP2gxcPuxH+IxpMtMLRsFFL u30IoCaRPAdrfJ1XrCXj/TP9bAk+LlGqtDKx+x/hvJCOAcZrKb0AxAkPrUXoy0zmW9QYgjfNGCt T9oX2XEeB+LF7qw== X-Received: by 2002:adf:8362:: with SMTP id 89mr14756598wrd.280.1604868344169; Sun, 08 Nov 2020 12:45:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJxqbR2cLME5tMAFaS6zqdV88bCqMwHdMWRjbXbn1ZbxbP5a4oBp4JHT3JG58/itaflrBByO3Q== X-Received: by 2002:adf:8362:: with SMTP id 89mr14756573wrd.280.1604868343948; Sun, 08 Nov 2020 12:45:43 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Igor Mammedov , "Michael S. Tsirkin" , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Marcel Apfelbaum , Wainer dos Santos Moschetta , Aurelien Jarno , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Aleksandar Rikalo , Richard Henderson , Fam Zheng , "Daniel P . Berrange" Subject: [PATCH-for-5.2 v4 01/17] configure: Check vhost-user is available to build vhost-user-blk-server Date: Sun, 8 Nov 2020 21:45:19 +0100 Message-Id: <20201108204535.2319870-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201108204535.2319870-1-philmd@redhat.com> References: <20201108204535.2319870-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Check vhost-user is available to build vhost-user-blk-server to fix: $ ../configure \ --disable-vhost-user --enable-vhost-user-blk-server && \ make qemu-nbd ... [505/505] Linking target qemu-nbd FAILED: qemu-nbd cc -o qemu-nbd qemu-nbd.p/qemu-nbd.c.o -Wl,--as-needed -Wl,--no-undefined= -pie -Wl,--whole-archive libblockdev.fa libblock.fa libcrypto.fa libauthz.= fa libqom.fa libio.fa -Wl,--no-whole-archive -Wl,--warn-common -Wl,-z,relro= -Wl,-z,now -m64 -fstack-protector-strong -Wl,--start-group libqemuutil.a l= ibblockdev.fa libblock.fa libcrypto.fa libauthz.fa libqom.fa libio.fa @bloc= k.syms -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.= 0 -pthread -lgnutls -lutil -lm -lgthread-2.0 -lglib-2.0 -lbz2 -lgthread-2.0= -lglib-2.0 -lssh -lrbd -lrados -lcurl -lxml2 -lzstd -lacl -lgfapi -lgluste= rfs -lgfrpc -lgfxdr -luuid -laio /usr/lib64/libz.so -L/usr/lib64/iscsi -lis= csi -lnettle -lgnutls -lpam -Wl,--end-group /usr/bin/ld: libblockdev.fa(block_export_vhost-user-blk-server.c.o): in fu= nction `vu_blk_process_vq': block/export/vhost-user-blk-server.c:203: undefined reference to `vu_get_q= ueue' /usr/bin/ld: block/export/vhost-user-blk-server.c:208: undefined reference= to `vu_queue_pop' /usr/bin/ld: libblockdev.fa(block_export_vhost-user-blk-server.c.o): in fu= nction `vu_blk_queue_set_started': block/export/vhost-user-blk-server.c:228: undefined reference to `vu_get_q= ueue' /usr/bin/ld: libblockdev.fa(block_export_vhost-user-blk-server.c.o): in fu= nction `vu_blk_req_complete': block/export/vhost-user-blk-server.c:55: undefined reference to `vu_queue_= push' /usr/bin/ld: block/export/vhost-user-blk-server.c:56: undefined reference = to `vu_queue_notify' /usr/bin/ld: libblockdev.fa(block_export_vhost-user-blk-server.c.o): in fu= nction `vu_blk_queue_set_started': block/export/vhost-user-blk-server.c:229: undefined reference to `vu_set_q= ueue_handler' /usr/bin/ld: libqemuutil.a(util_vhost-user-server.c.o): in function `vu_cl= ient_trip': util/vhost-user-server.c:176: undefined reference to `vu_dispatch' /usr/bin/ld: util/vhost-user-server.c:180: undefined reference to `vu_dein= it' /usr/bin/ld: libqemuutil.a(util_vhost-user-server.c.o): in function `vu_ac= cept': util/vhost-user-server.c:291: undefined reference to `vu_init' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. make: *** [Makefile:171: run-ninja] Error 1 Fixes: bc15e44cb21 ("configure: introduce --enable-vhost-user-blk-server") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure index 805f7791503..5079ebb416a 100755 --- a/configure +++ b/configure @@ -2390,6 +2390,9 @@ fi =20 # libvhost-user is Linux-only test "$vhost_user_blk_server" =3D "" && vhost_user_blk_server=3D$linux +if test "$vhost_user_blk_server" =3D "yes" && test "$vhost_user" =3D "no";= then + error_exit "--enable-vhost-user-blk-server requires --enable-vhost-user" +fi if test "$vhost_user_blk_server" =3D "yes" && test "$linux" =3D "no"; then error_exit "--enable-vhost-user-blk-server is only available on Linux" fi --=20 2.26.2