[PATCH for-5.2] qga: fix missing closedir() in qmp_guest_get_disks()

Michael Roth posted 1 patch 3 years, 4 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201108161112.187945-1-michael.roth@amd.com
qga/commands-posix.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH for-5.2] qga: fix missing closedir() in qmp_guest_get_disks()
Posted by Michael Roth 3 years, 4 months ago
We opendir("/sys/block") at the beginning of the function, but we never
close it prior to returning.

Fixes: Coverity CID 1436130
Fixes: fed3956429d5 ("qga: add implementation of guest-get-disks for Linux")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Tomáš Golembiovský <tgolembi@redhat.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>
---
 qga/commands-posix.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 3711080d07..12c1ba5ef7 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -1443,6 +1443,9 @@ GuestDiskInfoList *qmp_guest_get_disks(Error **errp)
         get_disk_deps(disk_dir, disk);
         ret = get_disk_partitions(ret, de->d_name, disk_dir, dev_name);
     }
+
+    closedir(dp);
+
     return ret;
 }
 
-- 
2.25.1


Re: [PATCH for-5.2] qga: fix missing closedir() in qmp_guest_get_disks()
Posted by Philippe Mathieu-Daudé 3 years, 4 months ago
On 11/8/20 5:11 PM, Michael Roth wrote:
> We opendir("/sys/block") at the beginning of the function, but we never
> close it prior to returning.
> 
> Fixes: Coverity CID 1436130
> Fixes: fed3956429d5 ("qga: add implementation of guest-get-disks for Linux")
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Tomáš Golembiovský <tgolembi@redhat.com>
> Signed-off-by: Michael Roth <michael.roth@amd.com>
> ---
>  qga/commands-posix.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>