From nobody Mon Apr 29 22:51:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604689458; cv=none; d=zohomail.com; s=zohoarc; b=ClYi2TV2vzlgLm1uNWC0WBTqAS2/utM9ZpNMctRCjG3RRRmBakks/ax7Yv7SLcbYp/plXtRhQqMuwF5dHcseVszlzDYD5HCxtutVqNUHLFrbBupyVom2RWTV9rcuYQDrhRTy+0llHcKWuKLtOFkkPKhF1XHaL0HfNT8Lw+drdYY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604689458; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=mQ1UDmwFMkB+mv0qV2lzTI3NvVyFxAW3riXAc5YeNWc=; b=UXXjHESP0CqsK+mqlWpSUFFI6oiSgtJjtF9r9mOXIivn9Yd4h9uYfxQ+y8UxPRLn5Q/TOGK9wC+S8t8957VB9HiSHQmERgNUvJMLjnQOGlXWIYe2BDIKYHut60+2/TmtiUQPUNGAfZqbt+WZ8N1rHar+EMSvYfWjuPxXtPOHPYI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 160468945875288.9584519028084; Fri, 6 Nov 2020 11:04:18 -0800 (PST) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-URuXpgZxNJ237S5POJcrrg-1; Fri, 06 Nov 2020 14:04:14 -0500 Received: by mail-wr1-f72.google.com with SMTP id e18so787907wrs.23 for ; Fri, 06 Nov 2020 11:04:13 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id t6sm3341287wrp.68.2020.11.06.11.04.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 11:04:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604689457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mQ1UDmwFMkB+mv0qV2lzTI3NvVyFxAW3riXAc5YeNWc=; b=FWZetV5sPqzxpzHIh2j4j+gPrhjHM5evmlRXwL2eCK5z0ADn+e6agI65Q5TFzuOmZWvhWQ xiJ3zTW3oFsMaXIwZT0+S3ISrkD5hhfWvyb2S7eXqObsOS1C8ElUAeoutS5kqy+fO2txzb 8K8Y/Z+NIoe6fu290HUxFOV7W8NTmgs= X-MC-Unique: URuXpgZxNJ237S5POJcrrg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mQ1UDmwFMkB+mv0qV2lzTI3NvVyFxAW3riXAc5YeNWc=; b=OkKyzZt9VyB6CzxYXHpcDQ2ihWHzEYrlWuufbJ1jGnRlYe6qPtWaVLaeiiELYCIAyd 5t+fA/LBdRhMhAJ8jwVKmm3AxHUcgrfqsFGcXfe2lHedeXPVRcqM1RLm0iW9nZwZ9hYR P25vqxtpBh3fSEv0btgNt24s8wKG17ygI/JaPMrCJRmRCA+atbA3vjkATWtwDbAjvljS 1RBtLmaFJ2CpKbljJcPBZWueZ6JNzDEGhIjoGQvQkbvs7Dq0l2wL8g/uu1d48NmePGMa Lnj0uEmIMdhYuMXoVWCiaje39kEAvECQqC4YAGVP4K8mlEOk+Qvk5eQaNJ/77XaQT+uc TgUg== X-Gm-Message-State: AOAM530HU+IcT8jeI2Qv9RNn5nN2ej1pK2I274xpWK2nZHG+w3CrGVNv HVv0V6RxMm4T6to9p4VsCu/CR8uAjQ6UvgYhDFMBbo+0MI8HAj1nHKBgG99ol44X+IPTnavCGAo OTRAzL5dYr4UBuw== X-Received: by 2002:a1c:7f0f:: with SMTP id a15mr1007868wmd.97.1604689452723; Fri, 06 Nov 2020 11:04:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJx3iOwD8RJLZQDBHLI3Txz0uA09fu0v7DjvZiaPkOQtXDC6hmmJh1U7EvnRPh6Ob0vRs7z8AA== X-Received: by 2002:a1c:7f0f:: with SMTP id a15mr1007845wmd.97.1604689452493; Fri, 06 Nov 2020 11:04:12 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , "Michael S . Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-5.2] configure: Check vhost-user is available to build vhost-user-blk-server Date: Fri, 6 Nov 2020 20:04:09 +0100 Message-Id: <20201106190409.10571-1-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Check vhost-user is available to build vhost-user-blk-server to fix: $ ../configure \ --disable-vhost-user --enable-vhost-user-blk-server && \ make qemu-nbd ... [505/505] Linking target qemu-nbd FAILED: qemu-nbd cc -o qemu-nbd qemu-nbd.p/qemu-nbd.c.o -Wl,--as-needed -Wl,--no-undefined= -pie -Wl,--whole-archive libblockdev.fa libblock.fa libcrypto.fa libauthz.= fa libqom.fa libio.fa -Wl,--no-whole-archive -Wl,--warn-common -Wl,-z,relro= -Wl,-z,now -m64 -fstack-protector-strong -Wl,--start-group libqemuutil.a l= ibblockdev.fa libblock.fa libcrypto.fa libauthz.fa libqom.fa libio.fa @bloc= k.syms -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.= 0 -pthread -lgnutls -lutil -lm -lgthread-2.0 -lglib-2.0 -lbz2 -lgthread-2.0= -lglib-2.0 -lssh -lrbd -lrados -lcurl -lxml2 -lzstd -lacl -lgfapi -lgluste= rfs -lgfrpc -lgfxdr -luuid -laio /usr/lib64/libz.so -L/usr/lib64/iscsi -lis= csi -lnettle -lgnutls -lpam -Wl,--end-group /usr/bin/ld: libblockdev.fa(block_export_vhost-user-blk-server.c.o): in fu= nction `vu_blk_process_vq': block/export/vhost-user-blk-server.c:203: undefined reference to `vu_get_q= ueue' /usr/bin/ld: block/export/vhost-user-blk-server.c:208: undefined reference= to `vu_queue_pop' /usr/bin/ld: libblockdev.fa(block_export_vhost-user-blk-server.c.o): in fu= nction `vu_blk_queue_set_started': block/export/vhost-user-blk-server.c:228: undefined reference to `vu_get_q= ueue' /usr/bin/ld: libblockdev.fa(block_export_vhost-user-blk-server.c.o): in fu= nction `vu_blk_req_complete': block/export/vhost-user-blk-server.c:55: undefined reference to `vu_queue_= push' /usr/bin/ld: block/export/vhost-user-blk-server.c:56: undefined reference = to `vu_queue_notify' /usr/bin/ld: libblockdev.fa(block_export_vhost-user-blk-server.c.o): in fu= nction `vu_blk_queue_set_started': block/export/vhost-user-blk-server.c:229: undefined reference to `vu_set_q= ueue_handler' /usr/bin/ld: libqemuutil.a(util_vhost-user-server.c.o): in function `vu_cl= ient_trip': util/vhost-user-server.c:176: undefined reference to `vu_dispatch' /usr/bin/ld: util/vhost-user-server.c:180: undefined reference to `vu_dein= it' /usr/bin/ld: libqemuutil.a(util_vhost-user-server.c.o): in function `vu_ac= cept': util/vhost-user-server.c:291: undefined reference to `vu_init' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. make: *** [Makefile:171: run-ninja] Error 1 Fixes: bc15e44cb21 ("configure: introduce --enable-vhost-user-blk-server") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure index 805f7791503..5079ebb416a 100755 --- a/configure +++ b/configure @@ -2390,6 +2390,9 @@ fi =20 # libvhost-user is Linux-only test "$vhost_user_blk_server" =3D "" && vhost_user_blk_server=3D$linux +if test "$vhost_user_blk_server" =3D "yes" && test "$vhost_user" =3D "no";= then + error_exit "--enable-vhost-user-blk-server requires --enable-vhost-user" +fi if test "$vhost_user_blk_server" =3D "yes" && test "$linux" =3D "no"; then error_exit "--enable-vhost-user-blk-server is only available on Linux" fi --=20 2.26.2