From nobody Sun May 5 16:15:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1604662247; cv=none; d=zohomail.com; s=zohoarc; b=awXuN61GC2geODfHqcVDQ6mMDfbEFbxqyPJldyKYqRprL4fU2gX2ENq6n1XV+dGtsO/t3V5FpCgh8Zs2va4EXRSDhn7AgqCVreeiTKmNEQs7mclI1tQsN/RNfQXeiLT2PEQL3TB2qot6A5PjuA72lNp5FN7zsqhJPJX7DNqrDeI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604662247; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=sBzZbxOaDzhkED96Ml51ZDDBBbPq+OYnSrAXiAMh9s8=; b=CqRoVheWPf+cs7f6+qqk5z4nPRCHTzdJrug12TA46ys6dK/TtsVIFdHmYPdgmm+k6emfonpoy4ySr82DJckore2sqQFgzI1z4bVaYHpljkkVQZ+0eBbAai4lqHbUxwDS1rm0WXaGc6xswDGuMhULGhx0rpgBnnozG/bGFStUUBE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604662247416758.5822786780584; Fri, 6 Nov 2020 03:30:47 -0800 (PST) Received: from localhost ([::1]:51218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kazx7-0004yO-KF for importer@patchew.org; Fri, 06 Nov 2020 06:30:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kazwA-0004Jy-4d for qemu-devel@nongnu.org; Fri, 06 Nov 2020 06:29:46 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:32823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kazw8-00005b-CE for qemu-devel@nongnu.org; Fri, 06 Nov 2020 06:29:45 -0500 Received: by mail-wm1-x341.google.com with SMTP id p19so752807wmg.0 for ; Fri, 06 Nov 2020 03:29:43 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id h128sm2019919wme.38.2020.11.06.03.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 03:29:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sBzZbxOaDzhkED96Ml51ZDDBBbPq+OYnSrAXiAMh9s8=; b=d9e8ZSf/AGefJuuJ4O79zTi50Klm9dlLjQJeL89hxcdSYwBm1k+Ol5LGjADDKpYZAV lAobDEMY9gnZZHcKEMNRMgjY/bxWDobMT//xt6eAeu5oKUBzcxHh/sWy11EFAu3sjtiw CXY+3oQAKBLNSjL4KhN36rgAi2D18yqzFfzZlPE91OWOrtR2EHgItT4pmwgCBx+3wvlT NUulEnipjTXP2M8edbW5MuNgtsrNEaTw5m4gwLpLdzbPYvDT2bu3f47wxdKTHSww2fr+ +0Z4CVMnEvwD5sZBEBwfwFzhCe7Td5UDX8ZdBiXJCRgeQ/R5O21Z8nr1c4X0q6SPxVpr w0Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sBzZbxOaDzhkED96Ml51ZDDBBbPq+OYnSrAXiAMh9s8=; b=dGl2ovz9AkBQEw8eWeO6F9uWHv5rOoVTJP0xuCwh57paeSb9Zpp7HNfNe1lgRHULWm MFmJjpGp47TBaq+9ZkzfbC+q7cInL3YILkygyUJAh5VXQdhoJBxYGVAgU7ICfPftGmj+ zUwkv06ld8o8hNFeB5/gcUsnBNx9dptCdBVFt75Y4OAMGlYskPNTTEVNlfMaWy67TtGu kBllLYH64QvMCz7mbRUhxvP/SnfhpJvcYz8ECcyXPK77l6shu1+CzMwO0CBprBfbJXrO OHRaykkluUcjWumY3N8M/AGu2KnhGokQEIRgpVGreprWyE4TLVf80OkJZ85vDZ/GWipa vVIw== X-Gm-Message-State: AOAM5300wwFrLK/TvSBl0OqsOvCjkd3ykFDv+CSsOx7hkcRTiqM/NReH mzK/73PmDeQCGn75rCbVufWDKIjnuJBJaw== X-Google-Smtp-Source: ABdhPJxWrkxCRFfga7ylwsyuh8c94BLbuiBI8XVFpfKfrFo/f8JVwa4eYVmhEnBiRptbZMd2ILQ6pg== X-Received: by 2002:a1c:4302:: with SMTP id q2mr2047297wma.182.1604662182672; Fri, 06 Nov 2020 03:29:42 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH] CODING_STYLE.rst: Be less strict about 80 character limit Date: Fri, 6 Nov 2020 11:29:40 +0000 Message-Id: <20201106112940.31300-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P. Berrange" , zhanghailiang , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Gan Qixin , "Chenqun \(kuhn\)" , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Relax the wording about line lengths a little bit; this goes with the checkpatch changes to warn at 100 characters rather than 80. (Compare the Linux kernel commit bdc48fa11e46f8; our coding style is not theirs, but the rationale is good and applies to us too.) Signed-off-by: Peter Maydell Reviewed-by: Markus Armbruster Reviewed-by: Michael S. Tsirkin --- CODING_STYLE.rst | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/CODING_STYLE.rst b/CODING_STYLE.rst index 8b13ef0669e..7bf4e39d487 100644 --- a/CODING_STYLE.rst +++ b/CODING_STYLE.rst @@ -85,8 +85,13 @@ Line width Lines should be 80 characters; try not to make them longer. =20 Sometimes it is hard to do, especially when dealing with QEMU subsystems -that use long function or symbol names. Even in that case, do not make -lines much longer than 80 characters. +that use long function or symbol names. If wrapping the line at 80 columns +is obviously less readable and more awkward, prefer not to wrap it; better +to have an 85 character line than one which is awkwardly wrapped. + +Even in that case, try not to make lines much longer than 80 characters. +(The checkpatch script will warn at 100 characters, but this is intended +as a guard against obviously-overlength lines, not a target.) =20 Rationale: =20 --=20 2.20.1