From nobody Mon Feb 9 06:18:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1604548289; cv=none; d=zohomail.com; s=zohoarc; b=nVzEn7F/fgGShESSeghJCbTnLbzRFKvdTmA86qE6bs5JepqMDeQEyxALrGTUAQkwJrarNNmfLDxqUsqeks9JgHE+YDN0K9DROxkkXR0xrT6NohLkg9PdJ4s7cdZDqwgS65lMbO5pJ82CwSw0FK75pWrjGxrjIwTXQUT3Sied65U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604548289; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=f3hKZF73/YoTlDUQzOZZBrDgHRYeOYYONQCQiXRT8ZQ=; b=HO/sR6fv2B9yyAhD7RiCsuW1FivI1KmVzbnqnv+JEcGOhbawI+pG8V5NGsv60YAw3VT6tDhgAk+wnamyGLQbqioWDx/2hzjDebDDXMTKQ/b/AcqDdpBuDoj1alSJvSfbTJPz2DtDByKFR9J56IdJLNKQGtl6nkyXre6i0VIcu98= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16045482888931015.3785550933578; Wed, 4 Nov 2020 19:51:28 -0800 (PST) Received: from localhost ([::1]:36708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaWJ5-0006i9-Sz for importer@patchew.org; Wed, 04 Nov 2020 22:51:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaWHN-0005NZ-KR; Wed, 04 Nov 2020 22:49:41 -0500 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:57625 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaWHL-0003wY-9p; Wed, 04 Nov 2020 22:49:41 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4CRTzb3HnLz9sTL; Thu, 5 Nov 2020 14:49:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1604548171; bh=h9uWSlyNbwH/ldEkW6U/uD3o+yRhPlC7O+nq4loYpmE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MgH6i6/cte9FID8DtM3qPcGauqNXCdIAfE0z9kdQJrOAsQSa2QPPIQNX9nIZRw/6K 2kmofWjWyESp6xGQUJKb44Y5dPDgu9dCJUNQ7JisKJhKb/gRkIqZy+YSTmiBJgaq7+ EolkFlRJ3zeXLHsxu34NHq5/gdIxJgx6EUzsh3qw= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 3/3] spapr: Convert hpt_prepare_thread() to use qemu_try_memalign() Date: Thu, 5 Nov 2020 14:49:19 +1100 Message-Id: <20201105034919.393653-4-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201105034919.393653-1-david@gibson.dropbear.id.au> References: <20201105034919.393653-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Greg Kurz HPT resizing is asynchronous: the guest first kicks off the creation of a new HPT, then it waits for that new HPT to be actually created and finally it asks the current HPT to be replaced by the new one. In the case of a userland allocated HPT, this currently relies on calling qemu_memalign() which aborts on OOM and never returns NULL. Since we seem to have path to report the failure to the guest with an H_NO_MEM return value, use qemu_try_memalign() instead of qemu_memalign(). Signed-off-by: Greg Kurz Message-Id: <160398563636.32380.1747166034877173994.stgit@bahia.lan> Signed-off-by: David Gibson --- hw/ppc/spapr_hcall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c index 607740150f..1d8e8e6a88 100644 --- a/hw/ppc/spapr_hcall.c +++ b/hw/ppc/spapr_hcall.c @@ -360,7 +360,7 @@ static void *hpt_prepare_thread(void *opaque) SpaprPendingHpt *pending =3D opaque; size_t size =3D 1ULL << pending->shift; =20 - pending->hpt =3D qemu_memalign(size, size); + pending->hpt =3D qemu_try_memalign(size, size); if (pending->hpt) { memset(pending->hpt, 0, size); pending->ret =3D H_SUCCESS; --=20 2.28.0