From nobody Mon Feb 9 06:14:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1604548301; cv=none; d=zohomail.com; s=zohoarc; b=Bx+Yg+5xlASFwaDfxF7uIPw2EtXgG0dmWfHfdW+p1xRDvr43QyvTsN+aD64osojhE52pyvtfT+s8VlHDg4FQwmSWv18TUnMGnIcAH6ouTlKeQR0tJ/MTAt5IitFV9H/UlfSP5WtEQNswzwEOGeho5mradAR6Bc77h3s2vVijriM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604548301; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kkWtVWfLAFOQ4PuGxXX29yIerJyjQiVRR+ybcKxtAW4=; b=D6JnLulxr8J9xilygttyz4UIotznSpAtInsvD2xT5V8y7KmnAfznSS/G06VpbVtrKY7aOwzqezY8XXyHMUbEetNReYhBJAmAuhb5A18UNXMHM76CY92nN1XP2CGxBW8aU8Zgn/Yoh5U0hR96+/RvTvmWAWri4h4YZV/SBHvp+po= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604548301636159.0350720283277; Wed, 4 Nov 2020 19:51:41 -0800 (PST) Received: from localhost ([::1]:37440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaWJI-000708-BW for importer@patchew.org; Wed, 04 Nov 2020 22:51:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaWHO-0005Nr-NA; Wed, 04 Nov 2020 22:49:42 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:33859 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaWHL-0003wV-Fj; Wed, 04 Nov 2020 22:49:42 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4CRTzb1KK7z9sRR; Thu, 5 Nov 2020 14:49:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1604548171; bh=zUzX5zu57Y2d4gMRLtDx5hcrmHkeL5+qsA7DiyUMmzk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P79qUpqq44edjnFaHGT0hSVcXqHeFz2nkQC2jhLaCTeCJ6Y/aKdQtLVZLrGI1uG1D 93hi61qNZ7FE/kGLwn0KMQxdqQsw8xVi25UH5a0OUbgUa89mWxGTwlULmzlINJvY4s lC/IcbKIG5u7+rtgJ3Dh+DauZgzMK5cHKTLKwIMU= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 1/3] target/ppc/excp_helper: Add a fallthrough for fix compiler warning Date: Thu, 5 Nov 2020 14:49:17 +1100 Message-Id: <20201105034919.393653-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201105034919.393653-1-david@gibson.dropbear.id.au> References: <20201105034919.393653-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/04 22:49:31 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, Euler Robot , Chen Qun , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Chen Qun When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: ../target/ppc/excp_helper.c: In function =E2=80=98powerpc_excp=E2=80=99: ../target/ppc/excp_helper.c:529:13: warning: this statement may fall throug= h [-Wimplicit-fallthrough=3D] 529 | msr |=3D env->error_code; | ~~~~^~~~~~~~~~~~~~~~~~ ../target/ppc/excp_helper.c:530:5: note: here 530 | case POWERPC_EXCP_HDECR: /* Hypervisor decrementer exceptio= n */ | ^~~~ Add the corresponding "fall through" comment to fix it. Reported-by: Euler Robot Signed-off-by: Chen Qun Message-Id: <20201028055107.2170401-1-kuhn.chenqun@huawei.com> Signed-off-by: David Gibson --- target/ppc/excp_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index d7411bcc81..ad0612555d 100644 --- a/target/ppc/excp_helper.c +++ b/target/ppc/excp_helper.c @@ -527,6 +527,7 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int ex= cp_model, int excp) break; case POWERPC_EXCP_HISI: /* Hypervisor instruction storage excepti= on */ msr |=3D env->error_code; + /* fall through */ case POWERPC_EXCP_HDECR: /* Hypervisor decrementer exception = */ case POWERPC_EXCP_HDSI: /* Hypervisor data storage exception = */ case POWERPC_EXCP_HDSEG: /* Hypervisor data segment exception = */ --=20 2.28.0