From nobody Mon Nov 17 15:45:56 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604492526; cv=none; d=zohomail.com; s=zohoarc; b=km4RZ4JDHrZ+UtnBuA2wsH1RCaSIQ5OqOKoXGdN5RnIuyAwXa1NuDYF9JTI1FyDXRXuhLmdyy7UdxFA1Lq9VmeT6hTa81QdgtJ5P59DpqSGnFoh01OJBa4vAecIhunVMhv27LNiMCC/VVMwiY6OZp1Wwq4Cmwu6SmwNKu56LXj4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604492526; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7CwwoAYvS2LJdkyGB+0F/NGd1MdSwpM/+LqhmsM5NCo=; b=LS9g82EdKcYxEDZyCqHHMKZGLVZB7IFHT5Jf4lgXTa2SnlxoSMZpHefqCw3+H/MIP81WWGP0XmsQ0iGRNMyFaAb6uR6CnaAdGKoY0v/eVxrDkVOZf/aCO9PpvJOWXkCJzIhXapOVpqNrQTau42Y7kbIAn9XLUbb/jhlWp8untf8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604492526734535.5933293752479; Wed, 4 Nov 2020 04:22:06 -0800 (PST) Received: from localhost ([::1]:60330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaHnh-0006kG-IJ for importer@patchew.org; Wed, 04 Nov 2020 07:22:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaHfW-0007e1-5g for qemu-devel@nongnu.org; Wed, 04 Nov 2020 07:13:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:39163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kaHfS-0007pi-RT for qemu-devel@nongnu.org; Wed, 04 Nov 2020 07:13:37 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-334-8ACHGK_7O2u4FB9OSpwSEQ-1; Wed, 04 Nov 2020 07:13:32 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A8813805EFD; Wed, 4 Nov 2020 12:13:30 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4128E1C924; Wed, 4 Nov 2020 12:13:27 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8CB059CA5; Wed, 4 Nov 2020 13:13:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604492013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7CwwoAYvS2LJdkyGB+0F/NGd1MdSwpM/+LqhmsM5NCo=; b=TMNXXsq0ohcwOUDZwkTs9J7J6gQfh4EUY7TPq7Wm4veLPRE6fct+QBdRczWup4KoNeO+t6 opQRZuWmo4Qo6Id1Ar4KSjgrfzsshknOW83o6GpzewcbdgR++4vQjy9reGku5ZUStR0g5E RpEGHfrzbkzdboWz0aPj/ty6h7J5+zM= X-MC-Unique: 8ACHGK_7O2u4FB9OSpwSEQ-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 7/8] dev-serial: add support for setting data_bits in QEMUSerialSetParams Date: Wed, 4 Nov 2020 13:13:20 +0100 Message-Id: <20201104121321.7772-8-kraxel@redhat.com> In-Reply-To: <20201104121321.7772-1-kraxel@redhat.com> References: <20201104121321.7772-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 22:09:52 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Thibault , Mark Cave-Ayland , Gerd Hoffmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Mark Cave-Ayland Also implement the behaviour reported in Linux's ftdi_sio.c whereby if an i= nvalid data_bits value is provided then the hardware defaults to using 8. Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20201027150456.24606-8-mark.cave-ayland@ilande.co.uk Signed-off-by: Gerd Hoffmann --- hw/usb/dev-serial.c | 17 +++++++++++++++++ hw/usb/trace-events | 1 + 2 files changed, 18 insertions(+) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index b9e308dca198..e42ce362956b 100644 --- a/hw/usb/dev-serial.c +++ b/hw/usb/dev-serial.c @@ -308,6 +308,23 @@ static void usb_serial_handle_control(USBDevice *dev, = USBPacket *p, break; } case VendorDeviceOutRequest | FTDI_SET_DATA: + switch (value & 0xff) { + case 7: + s->params.data_bits =3D 7; + break; + case 8: + s->params.data_bits =3D 8; + break; + default: + /* + * According to a comment in Linux's ftdi_sio.c original FTDI + * chips fall back to 8 data bits for unsupported data_bits + */ + trace_usb_serial_unsupported_data_bits(bus->busnr, dev->addr, + value & 0xff); + s->params.data_bits =3D 8; + } + switch (value & FTDI_PARITY) { case 0: s->params.parity =3D 'N'; diff --git a/hw/usb/trace-events b/hw/usb/trace-events index 98ee1c54627d..109da521cf4d 100644 --- a/hw/usb/trace-events +++ b/hw/usb/trace-events @@ -327,6 +327,7 @@ usb_serial_handle_control(int bus, int addr, int reques= t, int value) "dev %d:%u usb_serial_unsupported_parity(int bus, int addr, int value) "dev %d:%u uns= upported parity %d" usb_serial_unsupported_stopbits(int bus, int addr, int value) "dev %d:%u u= nsupported stop bits %d" usb_serial_unsupported_control(int bus, int addr, int request, int value) = "dev %d:%u got unsupported/bogus control 0x%x, value 0x%x" +usb_serial_unsupported_data_bits(int bus, int addr, int value) "dev %d:%u = unsupported data bits %d, falling back to 8" usb_serial_bad_token(int bus, int addr) "dev %d:%u bad token" usb_serial_set_baud(int bus, int addr, int baud) "dev %d:%u baud rate %d" usb_serial_set_data(int bus, int addr, int parity, int data, int stop) "de= v %d:%u parity %c, data bits %d, stop bits %d" --=20 2.27.0