From nobody Fri May 17 03:01:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.66 as permitted sender) client-ip=209.85.128.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1604482544; cv=none; d=zohomail.com; s=zohoarc; b=nkgUSDM00Jj/T7TgHzctC8g61PdgRf1q6TsqDA1XdVptWrVH30VG8dBm1vzSQ9CVKNUSf4aPVHerEW7FTxms0a6X/Fufb8uGAsJkSw2eaLIeKC4+oyHaEMhht5jqk6/1haI+AJrGbAtA/OytXQwGbA2p8K6NPpAJ9lnplHWXSEI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604482544; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4AhUjeQiN0LcEfpx9fUA0RoRAgGVy7D+433bMg8WIoY=; b=jYT+kWR+sCwpEpMyyOdD/2bl042flh3aaJEK5T4eKXzBBcYQNVyIpw48L+wDzGYN26qoZ0vW9MZDWds63yx88+DLmEDcvUZ2r9uA1bC3eUzu3FucvQaw1Oxk/8gDUdMmtYG6/KZYTvCmMLyd/HhbeecGLqBkgGbrWR9SUx9gF9k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.zohomail.com with SMTPS id 1604482544114614.0959104708658; Wed, 4 Nov 2020 01:35:44 -0800 (PST) Received: by mail-wm1-f66.google.com with SMTP id h62so1672587wme.3 for ; Wed, 04 Nov 2020 01:35:43 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id f3sm1880884wrw.81.2020.11.04.01.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4AhUjeQiN0LcEfpx9fUA0RoRAgGVy7D+433bMg8WIoY=; b=MiGYwuhK4bBAXxdeMn4u87pmsXL3PJjESP2bna9x91x/I8QrOTJCWapDuj7bhXASK/ tiipDW+vkv1FNRk5slRDB4WD+LmdgrUR/NYDScqx98W06aE5H7nV64PzdCn0PfM2LyC4 K0ORHkzb1OXar2SCl3sSj4Ji/C8gIQfHnBdlwRWyMsHyf+oXUb/1eN367ztbqTunLYES Na6sAyGVLycGmRY0IuAC+ZkBytfkyBIfKjaSr82TfHD9x4MInKyD0zVCjenlSEaLVWHI Aivu8BnbOAicQ4rlUdQjgZlssdfCQJ3lkAEWalilvFfJl2sJCZzPXqkZLoIebcOZCjbI NKZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=4AhUjeQiN0LcEfpx9fUA0RoRAgGVy7D+433bMg8WIoY=; b=OpMm3OXrcEgmVjn68dy3emxigfkZue4AgxDi12Bjl0VoMn8hcayDep/PAHBYI2qcwK 4PEwOU2TxjpaqGQgrUGRNpADIdTRM3msoUwUzjr6nX538Z+ySVfsmQZWM+6N20NZIT2E ufz29vBOhLfbXKlrQt0aXUv3U6OjHUBxHSVgcC0tDfv2nnQIeSgzSOjvRqAzC55cNgCD uwJmYJ0BKnYpl7pSZ0FOEvJVwK/E8bu6recLoYjay5Owh1OnMw/LXfjssKI/YgVl5tdV jyWLPSAMka8WgvsKIAyToc41Gk7/lRxAj1mdViIGeXDCzgaCutHuBumDj6Lg9OEOgKH6 ArGg== X-Gm-Message-State: AOAM532Fqpv3FTHeV7X73WmiGc98/yJy1rkq7ETj+gtDvCbZTx7t+h8C Gdj6WDR/ZsnsUWtpGvQfk/o= X-Google-Smtp-Source: ABdhPJzkWSP7lIgkSDvBwGpprX90shpPVzibsZhma2tGLUU8tMY56+QQGb023emfOGnLLcVcbaoKjw== X-Received: by 2002:a1c:96cb:: with SMTP id y194mr3469929wmd.62.1604482542378; Wed, 04 Nov 2020 01:35:42 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Paolo Bonzini , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/2] MAINTAINERS: Cover exec-vary.c (variable page size) Date: Wed, 4 Nov 2020 10:35:33 +0100 Message-Id: <20201104093534.3064440-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201104093534.3064440-1-f4bug@amsat.org> References: <20201104093534.3064440-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Add exec-vary.c to the 'Overall TCG CPUs' section. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index dd16606bcdc..466898d3dbd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -117,6 +117,7 @@ R: Paolo Bonzini S: Maintained F: softmmu/cpus.c F: cpus-common.c +F: exec-vary.c F: accel/tcg/ F: accel/stubs/tcg-stub.c F: scripts/decodetree.py --=20 2.26.2 From nobody Fri May 17 03:01:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) client-ip=209.85.128.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1604482548; cv=none; d=zohomail.com; s=zohoarc; b=IfUfq4MVphr/Egte8VCAmRGAxE1AwuQM/E7RU2henY9YcEVqOW/bbcDYIuDZ2+vBdPpTD5dLjPBm/+Fs5z6xq42PyHioIYraqlA/Rjk0gQNvINguav9/5FDeVFfEvqGr3XXJ8CdCBgninJdeyS9TIE/8jNBvMBYtlln+ycKKfjc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604482548; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oU5UbR5ntNYy2SUlvhi9joWPDwzoXedtc395+AIU/FU=; b=E+uZ8OLbB83dU3ZHFWiHmN1BHSNEP3rjyHnMxUymfXriC7GCdJzlJG4Cbcjqx8F25IAQyrabpyMhJUkrAbgHqqSaIojdaMUHxHCNyLqtf60mqha+7CT8sRab06NCiUyNjQWxNEvzzeru+wVLGfr61xRKcmxVc5xBpQ8TyajeySs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.zohomail.com with SMTPS id 1604482548918481.89131982000606; Wed, 4 Nov 2020 01:35:48 -0800 (PST) Received: by mail-wm1-f50.google.com with SMTP id p22so1685231wmg.3 for ; Wed, 04 Nov 2020 01:35:48 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id r1sm1772468wro.18.2020.11.04.01.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:35:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oU5UbR5ntNYy2SUlvhi9joWPDwzoXedtc395+AIU/FU=; b=UiK+gY1qMkcIbHe1lyQpWs29c7MRIx27Dij2gKezrDhPavG0xGQKeMc0HH2O+FwWMW Oqxz0cDeFupQQe1oowuGa7VtSaEaGaUwNLvjLNxUQ7egRr09C6tzhe487ZIHZVMQ0Uku Rl6/fEoYVA6TW1rk/b+opnauZsaCrIeqC7wgJlwqppDeMcWBnxp/6CvJ3XfpfW8gDsu1 g778ReZj4T2sof/byrtun6WMsbOHpfVi7BSJECB5ZIJQWO8a7/Sp7Avpg9Pobu9ofdVk vN+Lmmj9+qcOLLGEo/oyFFCMmLMwUTwdCxr7dpAfjnNqUuT7jakrLmZ+N17hyUM2fdGG ++ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=oU5UbR5ntNYy2SUlvhi9joWPDwzoXedtc395+AIU/FU=; b=og156lzkIePYKi4ormxnp/QNi8hHHh08MpLHzkBeGlLq8blQEcAb4q0d9+XgDefV2h B+sJ/QVgHBnRKlkq8jdy3aQ9s/g944BWvtcjTHL/e9tURJlDKRdqvETTbTBaE4hwcxi5 mVpVHPqhs7FYC/cHmNCmQFbEVKG+0I4e+ieRfHL0T1e80mL3xuxghGCX14Iqle7g+hpU Fm7BcaslgJoywrSb4KoXXAJ+BueGlmiEjI4BybHE+MT9V+kzvrM1uqdFst1eWZagGasj wTDYo8U+dy8WdFQhYu0bKdi/On71gp2xA7qJZQzNVAXN8TKQFnfv7O5scyldS1PvpjVc HN+g== X-Gm-Message-State: AOAM532Z4HZMRsdnbSwi8929PgKGyc4VnNxfcVcezFB+ZGbALMoI5cFg ms42IiUU0LMCXTwMUXpXMaE= X-Google-Smtp-Source: ABdhPJxWPCt9IvKwbjlLBPh1mfSeLVBntguEsuqGa2yUdgaZq5uJP32JjIg87gu8rd6/ThFGw2hKxg== X-Received: by 2002:a1c:b387:: with SMTP id c129mr3759443wmf.66.1604482547100; Wed, 04 Nov 2020 01:35:47 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Paolo Bonzini , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/2] exec: Ensure variable page size is only used with TARGET_PAGE_BITS_VARY Date: Wed, 4 Nov 2020 10:35:34 +0100 Message-Id: <20201104093534.3064440-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201104093534.3064440-1-f4bug@amsat.org> References: <20201104093534.3064440-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) If TARGET_PAGE_BITS_VARY is not supported, machines should not intent to modify the target page size. As set_preferred_target_page_bits() is supposed to return 'false' on failure (documented in "qemu-common.h"), return false to indicate failure if this ever happens. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/qemu-common.h | 4 +++- exec-vary.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/qemu-common.h b/include/qemu-common.h index fda7dc6ca77..3ea616d4567 100644 --- a/include/qemu-common.h +++ b/include/qemu-common.h @@ -70,7 +70,9 @@ void cpu_exec_step_atomic(CPUState *cpu); * size may be smaller than any given CPU's preference). * Returns true on success, false on failure (which can only happen * if this is called after the system has already finalized its - * choice of page size and the requested page size is smaller than that). + * choice of page size and the requested page size is smaller than + * that). Only target supporting variable page size should set a + * preferred target page size. */ bool set_preferred_target_page_bits(int bits); =20 diff --git a/exec-vary.c b/exec-vary.c index ff905f2a8fb..4b0b7f193af 100644 --- a/exec-vary.c +++ b/exec-vary.c @@ -86,8 +86,10 @@ bool set_preferred_target_page_bits(int bits) } init_target_page.bits =3D bits; } -#endif return true; +#else + return false; +#endif } =20 void finalize_target_page_bits(void) --=20 2.26.2