From nobody Mon Feb 9 10:27:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604450764; cv=none; d=zohomail.com; s=zohoarc; b=bFWEG5q5MsLKZQpUfGmZcYQAy9l5vQMQpNNViCO6qmYvqgtQr8hgYNKhAFK5v7QhTZf0APtj91ce6f7rqiS23m6dnsQLh0kM5+UNJwurydvlAbfB5NflZPRSkBQGE0TKc3xSaV3n9M21YFwOLXalKAcLICkhJhs3H+cQIUR5bQ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604450764; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fB1rH87GsDpMYD9z/NEMczfG2TJxteUGF9x5BkNa1OY=; b=Q69kWnKF/QJ2cJrTxs7UKS7iOju6u00SLpkcHvntqQATXtQxryGWgHiit5T0XGZhjuEGRFkAsKn6pbKiBIpPhpnSgbRdpGZftlaiTiIk+j9Tmn/leKqiVnxzvpvD/6VqRHo6K8JwULgm8JPbDbXjFrlZrUyGMotisMwvLtZgxGE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160445076478244.19731472948865; Tue, 3 Nov 2020 16:46:04 -0800 (PST) Received: from localhost ([::1]:58360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ka6w7-0001gh-Jh for importer@patchew.org; Tue, 03 Nov 2020 19:46:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ka6ms-0006Bo-23 for qemu-devel@nongnu.org; Tue, 03 Nov 2020 19:36:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1ka6mq-0004oP-9j for qemu-devel@nongnu.org; Tue, 03 Nov 2020 19:36:29 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-529-ap_egA23MsC9IgMjNxH5FA-1; Tue, 03 Nov 2020 19:36:25 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 56AB0186842A for ; Wed, 4 Nov 2020 00:36:21 +0000 (UTC) Received: from scv.redhat.com (ovpn-119-97.rdu2.redhat.com [10.10.119.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2D7A155766; Wed, 4 Nov 2020 00:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604450187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fB1rH87GsDpMYD9z/NEMczfG2TJxteUGF9x5BkNa1OY=; b=hhjRIzztpRRXx76SitCnufDBv70LZ1rWZKwBzCW9VACx6yxlpQRofE0xgvdHr9m5ad2MwZ Zp937b6lExzZq2tyZnHWU+5QzWkSnWWfzeTHO4IyNPM4cuO0c3gaQBV5a3lRcKUnlbOUDL QKVDxAjHS0YFevBwtxuamkmpEMeWm98= X-MC-Unique: ap_egA23MsC9IgMjNxH5FA-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 07/72] scripts/qom-fuse: Apply pylint rules Date: Tue, 3 Nov 2020 19:34:57 -0500 Message-Id: <20201104003602.1293560-8-jsnow@redhat.com> In-Reply-To: <20201104003602.1293560-1-jsnow@redhat.com> References: <20201104003602.1293560-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 00:03:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Cleber Rosa , John Snow , Markus Armbruster , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) - Catch specific exceptions from QMP - Reraise errors with explicit context - method parameters should match parent's names Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- scripts/qmp/qom-fuse | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/scripts/qmp/qom-fuse b/scripts/qmp/qom-fuse index ca30e928679e..805e99c8ecde 100755 --- a/scripts/qmp/qom-fuse +++ b/scripts/qmp/qom-fuse @@ -23,7 +23,7 @@ from fuse import FUSE, FuseOSError, Operations =20 =20 sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'pytho= n')) -from qemu.qmp import QEMUMonitorProtocol +from qemu.qmp import QEMUMonitorProtocol, QMPResponseError =20 =20 fuse.fuse_python_api =3D (0, 2) @@ -47,7 +47,7 @@ class QOMFS(Operations): try: self.qmp.command('qom-list', path=3Dpath) return True - except: + except QMPResponseError: return False =20 def is_property(self, path): @@ -59,7 +59,7 @@ class QOMFS(Operations): if item['name'] =3D=3D prop: return True return False - except: + except QMPResponseError: return False =20 def is_link(self, path): @@ -73,10 +73,10 @@ class QOMFS(Operations): return True return False return False - except: + except QMPResponseError: return False =20 - def read(self, path, length, offset, fh): + def read(self, path, size, offset, fh): if not self.is_property(path): return -ENOENT =20 @@ -86,13 +86,13 @@ class QOMFS(Operations): try: data =3D self.qmp.command('qom-get', path=3Dpath, property=3Dp= rop) data +=3D '\n' # make values shell friendly - except: - raise FuseOSError(EPERM) + except QMPResponseError as err: + raise FuseOSError(EPERM) from err =20 if offset > len(data): return '' =20 - return bytes(data[offset:][:length], encoding=3D'utf-8') + return bytes(data[offset:][:size], encoding=3D'utf-8') =20 def readlink(self, path): if not self.is_link(path): --=20 2.26.2