From nobody Mon Feb 9 01:19:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604452348; cv=none; d=zohomail.com; s=zohoarc; b=hgxg6EtxEvQEH2Fcm/JlV4EX2FTcRM7xBMvXMfqbqdE/CdpPZPBqSkOJ2qLRT0Gc+wd2DP1S77lH93M3wz2qFvhADRE37eHdCDjUjNC1MVWHZR0IDLcxaWLj//ef0SIDJ0eZyFXTwwmcnDj67JyhXD2M2oL/mNQVRFtWaYfKuJ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604452348; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TIFuMouv3BevsTrVSomuc/EthhkE99OcgJhVE2XMzY8=; b=FhbE9VxszCqH+Vut9qSRvZVTEJ/X4L2gKy5d+HTPmouAqWccd+ddRJuhkID//dXpe6C8647P2O6LaFs00sOSsz6q4efszq5uScr7g3XFtiEkRmBfC4dXT2Kk/47FkbU09tNVeag7Vs+Tsfoo4EwxTkywpZDFOINrkcvkgijJImY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604452348938988.7299560389396; Tue, 3 Nov 2020 17:12:28 -0800 (PST) Received: from localhost ([::1]:41268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ka7Ld-0007ir-Pf for importer@patchew.org; Tue, 03 Nov 2020 20:12:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ka6nv-0007NR-Pc for qemu-devel@nongnu.org; Tue, 03 Nov 2020 19:37:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26687) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1ka6nt-0004xp-9u for qemu-devel@nongnu.org; Tue, 03 Nov 2020 19:37:35 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-343-qEaK0t9-Peei9aKrMiv0tg-1; Tue, 03 Nov 2020 19:37:31 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 29E301009E26 for ; Wed, 4 Nov 2020 00:37:30 +0000 (UTC) Received: from scv.redhat.com (ovpn-119-97.rdu2.redhat.com [10.10.119.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36C7E55766; Wed, 4 Nov 2020 00:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604450252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TIFuMouv3BevsTrVSomuc/EthhkE99OcgJhVE2XMzY8=; b=IvRImPQvAHmzTxlHhwT8QN0hfiomj2uDij75/m8vn4bpT4hTSVhJh2CUv71xyNkNMng+qb c8MSup/zoYTny8nYlHABAfCY9Yqg8XVFSbirmZFPpA8DIhhSGTF/AQDCgimSrqqwxSpxDG wGBEfGjFzTQuRF7SC+zSmSILuXE0jJY= X-MC-Unique: qEaK0t9-Peei9aKrMiv0tg-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 62/72] scripts/qmp-shell: use logging to show warnings Date: Tue, 3 Nov 2020 19:35:52 -0500 Message-Id: <20201104003602.1293560-63-jsnow@redhat.com> In-Reply-To: <20201104003602.1293560-1-jsnow@redhat.com> References: <20201104003602.1293560-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 00:03:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cleber Rosa , John Snow , Markus Armbruster , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Perfect candidate is non-fatal shell history messages. Signed-off-by: John Snow --- scripts/qmp/qmp-shell | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell index ec028d662e8e..0199a13a3428 100755 --- a/scripts/qmp/qmp-shell +++ b/scripts/qmp/qmp-shell @@ -67,6 +67,7 @@ import argparse import ast import json +import logging import os import re import readline @@ -85,6 +86,9 @@ from qemu import qmp from qemu.qmp import QMPMessage =20 =20 +LOG =3D logging.getLogger(__name__) + + class QMPCompleter: # NB: Python 3.9+ will probably allow us to subclass list[str] directl= y, # but pylint as of today does not know that List[str] is simply 'list'. @@ -167,13 +171,15 @@ class QMPShell(qmp.QEMUMonitorProtocol): except FileNotFoundError: pass except IOError as err: - print(f"Failed to read history '{self._histfile}': {err!s}") + msg =3D f"Failed to read history '{self._histfile}': {err!s}" + LOG.warning(msg) =20 def _save_history(self) -> None: try: readline.write_history_file(self._histfile) except IOError as err: - print(f"Failed to save history file '{self._histfile}': {err!s= }") + msg =3D f"Failed to save history file '{self._histfile}': {err= !s}" + LOG.warning(msg) =20 @classmethod def __parse_value(cls, val: str) -> object: --=20 2.26.2