From nobody Mon Feb 9 00:02:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604451040; cv=none; d=zohomail.com; s=zohoarc; b=EyvlQyFgWT/44RoCTpZA2qcZ03wuFpbIyyoBEGBF1YfuVXGBfLDj/EBpHhak3RAIERvbxDK4UVHP47mLASu0GWWtrRfnzfxzTSAc9k1x8hzDEEJhdyIZvjU3R9mzMyM7od73bGmfH/Td4Z3FgHwSEzsMxHKc4F1AYPuhOma0mto= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604451040; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Xk2DkEIlZ+iczJ/YzPivEFw8SkHzwnuTgTlMET5+zx8=; b=fhfqEw5EAleLBkoiT1KjWNhkJPWOXZcHDmY9oiPP0qIukb9vzf5DldWCKbikdFApyubveJ/CJnc0mBFMlawALPNN9FukhRc8mVai8aPINTSLdKiqOTRVuTHWEca3tzYQdmUG415b6l1nF3GO6erShwbMlnqTX+Wi7YQsr177taM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604451040165270.18118880204963; Tue, 3 Nov 2020 16:50:40 -0800 (PST) Received: from localhost ([::1]:47786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ka70Y-0000Vr-WC for importer@patchew.org; Tue, 03 Nov 2020 19:50:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ka6nO-0006XW-Uf for qemu-devel@nongnu.org; Tue, 03 Nov 2020 19:37:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29392) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1ka6nL-0004s1-Uw for qemu-devel@nongnu.org; Tue, 03 Nov 2020 19:37:02 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-209--6B8GRSJN66AE5wYCPdUng-1; Tue, 03 Nov 2020 19:36:57 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3AF5D1054FA2 for ; Wed, 4 Nov 2020 00:36:50 +0000 (UTC) Received: from scv.redhat.com (ovpn-119-97.rdu2.redhat.com [10.10.119.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C43755766; Wed, 4 Nov 2020 00:36:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604450219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xk2DkEIlZ+iczJ/YzPivEFw8SkHzwnuTgTlMET5+zx8=; b=UrKYLltT/M9byynTDqJ/77acPN+iEOeUiqUgvF9XpK5ACJU9PGmQVKzdOFUolPSL5Lw+iV vUjCNZ3ULocCPtvtEgHTQ8NrtMDfMrCXEZTTs05GqGnjNrQw3OwtQm5czT1oyOXWB7Gv0u yqwds7MbBgOdMVRYr+dPl3nSMRFht3U= X-MC-Unique: -6B8GRSJN66AE5wYCPdUng-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 32/72] scripts/qmp-shell: fix connect method signature Date: Tue, 3 Nov 2020 19:35:22 -0500 Message-Id: <20201104003602.1293560-33-jsnow@redhat.com> In-Reply-To: <20201104003602.1293560-1-jsnow@redhat.com> References: <20201104003602.1293560-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 00:03:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cleber Rosa , John Snow , Markus Armbruster , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" It needs to match the parent's. (The negotiate parameter must be optional.) Signed-off-by: John Snow --- scripts/qmp/qmp-shell | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell index 330f8b32f9c2..27632ed5fee7 100755 --- a/scripts/qmp/qmp-shell +++ b/scripts/qmp/qmp-shell @@ -297,7 +297,7 @@ class QMPShell(qmp.QEMUMonitorProtocol): self._print(resp) return True =20 - def connect(self, negotiate): + def connect(self, negotiate: bool =3D True): self._greeting =3D super(QMPShell, self).connect(negotiate) self.__completer_setup() =20 --=20 2.26.2