From nobody Mon Feb 9 02:13:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604450911; cv=none; d=zohomail.com; s=zohoarc; b=UsZKSOdDL04sV0iLCThnvds+vdLGwhImrFLMA1o1ZO4loZndpyEaUykaHSnhGdKH+hCVVllZ7w3zDMw5VAKlx77MvViPcJJSKKDHzq7tu5KjJFWNt17CEHZ0dzWPoxvF6mr2TDRkKlvfh3W+Ii9ek6cBXW6j6UdNsyk0hvY+w4M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604450911; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QOf6X564u68YDgrr4+ImRp2w40G6MZqV8eYk6Yyrpk4=; b=kpuoDdBN+KiK96OjRwL9tcenKuSgwrdQwhm49+v0l1KjOM6RP2RSIREZdX0WEghZZXDf4vcsvnDIMVhG3WbauZZj9ZxSfdKDEscUeshTa0EFSnMMBvS45/fveovo+ngNnEAwB84Bp6k9JN5O/bfH9zAhS5rMrjnzNTjB0EsIc/k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604450911849583.9969372059674; Tue, 3 Nov 2020 16:48:31 -0800 (PST) Received: from localhost ([::1]:39164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ka6yU-0005NP-EQ for importer@patchew.org; Tue, 03 Nov 2020 19:48:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ka6nB-0006Mr-PT for qemu-devel@nongnu.org; Tue, 03 Nov 2020 19:36:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1ka6n7-0004px-27 for qemu-devel@nongnu.org; Tue, 03 Nov 2020 19:36:49 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-55-EWfNmpFSPhSy29UJKR7V6w-1; Tue, 03 Nov 2020 19:36:40 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EDE071054FA5 for ; Wed, 4 Nov 2020 00:36:33 +0000 (UTC) Received: from scv.redhat.com (ovpn-119-97.rdu2.redhat.com [10.10.119.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C847747C6; Wed, 4 Nov 2020 00:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604450202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QOf6X564u68YDgrr4+ImRp2w40G6MZqV8eYk6Yyrpk4=; b=N/Yekjwiaezdrdy5bqOTDtGC4elhD4JCEhkuzF8G4AvMXWSfSp+AAAStrpuCyfy5kZb5Nf yuqI+hf7QCxd1RuK4syzrEzCT4t7Qc/j4WlJhmnPZdMrng4xMNUDIrBGfIdWp4vI9XMXdn ZwWNysTCYVEQgApJ47ktmq7r+zIP5I0= X-MC-Unique: EWfNmpFSPhSy29UJKR7V6w-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 18/72] scripts/qemu-ga-client: apply (most) flake8 rules Date: Tue, 3 Nov 2020 19:35:08 -0500 Message-Id: <20201104003602.1293560-19-jsnow@redhat.com> In-Reply-To: <20201104003602.1293560-1-jsnow@redhat.com> References: <20201104003602.1293560-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 00:03:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cleber Rosa , John Snow , Markus Armbruster , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" - Line length should be < 80 - You shouldn't perform unscoped imports except at the top of the module Notably, the sys.path hack creates problems with the import rule. This will be fixed later. Signed-off-by: John Snow --- scripts/qmp/qemu-ga-client | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/scripts/qmp/qemu-ga-client b/scripts/qmp/qemu-ga-client index ae71b30dfa43..a12e0e9b2a6e 100755 --- a/scripts/qmp/qemu-ga-client +++ b/scripts/qmp/qemu-ga-client @@ -12,7 +12,8 @@ # Start QEMU with: # # # qemu [...] -chardev socket,path=3D/tmp/qga.sock,server,nowait,id=3Dqga= 0 \ -# -device virtio-serial -device virtserialport,chardev=3Dqga0,name=3Dorg= .qemu.guest_agent.0 +# -device virtio-serial \ +# -device virtserialport,chardev=3Dqga0,name=3Dorg.qemu.guest_agent.0 # # Run the script: # @@ -37,6 +38,7 @@ # =20 import base64 +import optparse import os import random import sys @@ -94,9 +96,11 @@ class QemuGuestAgentClient: msgs =3D [] msgs.append('version: ' + info['version']) msgs.append('supported_commands:') - enabled =3D [c['name'] for c in info['supported_commands'] if c['e= nabled']] + enabled =3D [c['name'] for c in info['supported_commands'] + if c['enabled']] msgs.append('\tenabled: ' + ', '.join(enabled)) - disabled =3D [c['name'] for c in info['supported_commands'] if not= c['enabled']] + disabled =3D [c['name'] for c in info['supported_commands'] + if not c['enabled']] msgs.append('\tdisabled: ' + ', '.join(disabled)) =20 return '\n'.join(msgs) @@ -119,11 +123,11 @@ class QemuGuestAgentClient: if ipaddr['ip-address-type'] =3D=3D 'ipv4': addr =3D ipaddr['ip-address'] mask =3D self.__gen_ipv4_netmask(int(ipaddr['prefi= x'])) - msgs.append("\tinet %s netmask %s" % (addr, mask)) + msgs.append(f"\tinet {addr} netmask {mask}") elif ipaddr['ip-address-type'] =3D=3D 'ipv6': addr =3D ipaddr['ip-address'] prefix =3D ipaddr['prefix'] - msgs.append("\tinet6 %s prefixlen %s" % (addr, pr= efix)) + msgs.append(f"\tinet6 {addr} prefixlen {prefix}") if nif['hardware-address'] !=3D '00:00:00:00:00:00': msgs.append("\tether " + nif['hardware-address']) =20 @@ -237,6 +241,8 @@ def _cmd_suspend(client, args): =20 def _cmd_shutdown(client, args): client.shutdown() + + _cmd_powerdown =3D _cmd_shutdown =20 =20 @@ -280,17 +286,15 @@ def main(address, cmd, args): =20 =20 if __name__ =3D=3D '__main__': - import optparse - import os - import sys + address =3D os.environ.get('QGA_CLIENT_ADDRESS') =20 - address =3D os.environ['QGA_CLIENT_ADDRESS'] if 'QGA_CLIENT_ADDRESS' i= n os.environ else None - - usage =3D "%prog [--address=3D|] [a= rgs...]\n" + usage =3D ("%prog [--address=3D|]" + " [args...]\n") usage +=3D ': ' + ', '.join(commands) parser =3D optparse.OptionParser(usage=3Dusage) parser.add_option('--address', action=3D'store', type=3D'string', - default=3Daddress, help=3D'Specify a ip:port pair or= a unix socket path') + default=3Daddress, + help=3D'Specify a ip:port pair or a unix socket path= ') options, args =3D parser.parse_args() =20 address =3D options.address --=20 2.26.2