From nobody Mon Feb 9 02:28:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604450677; cv=none; d=zohomail.com; s=zohoarc; b=DR3m/mgkfueD+9mp/Q3fAxRF9qytBoIjpYGO0OZvzmjwUKnou3nXhN/3oWj+ILdkhG6g7sF0/6a5woT3HLyWS+XB4Ml04062cI7yilCx/zbcPddbeTFF78VA9TADzEe9HBhS7n0OuniLsG42bBb87XB/famjd7V/asWQUvX1ZVA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604450677; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sA6VFb1LRcC1wcG4j9cZhiPji9rUnXMqeMGltu8wD0k=; b=bGsnXW4XE9D+mcd7vptcP40Uqv26PSBHWr2ekTcp7aBuFBkM0DxBp9iSg2ursIZHiSh7f/vcyJM5IeJQa+DquWYmcQDhXzyRBodG76efs4ZrQ/XMkjO82ZerdDMeXqyXexhSP5I8NoB5gJD92JVg7wfj2udNKKYgYdHY6s/y9mU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604450677530342.4789508827623; Tue, 3 Nov 2020 16:44:37 -0800 (PST) Received: from localhost ([::1]:50816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ka6ui-0006xs-ET for importer@patchew.org; Tue, 03 Nov 2020 19:44:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ka6n3-0006KD-CJ for qemu-devel@nongnu.org; Tue, 03 Nov 2020 19:36:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60063) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1ka6mx-0004or-Cx for qemu-devel@nongnu.org; Tue, 03 Nov 2020 19:36:41 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-92-HOzc8W9zOiy-RrNPjAnIKA-1; Tue, 03 Nov 2020 19:36:32 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E1DBB11BD35A for ; Wed, 4 Nov 2020 00:36:24 +0000 (UTC) Received: from scv.redhat.com (ovpn-119-97.rdu2.redhat.com [10.10.119.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA8807512C; Wed, 4 Nov 2020 00:36:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604450193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sA6VFb1LRcC1wcG4j9cZhiPji9rUnXMqeMGltu8wD0k=; b=CmDRMu7mzrz4MU0fHCNCSt/LeqyunIHaF5T+P4K62vgDouqi2dyulc6oZofsGtAY9csWQl L3AFx4ds48nzjqpsKxykU/N5hQTN7AXnGxTM6xwNNoiWeWvrEuiV4LD7zbaf4Wl5LlNHmc YQsWHzLOS95r4wgo4wxpdKP9Vco/kBs= X-MC-Unique: HOzc8W9zOiy-RrNPjAnIKA-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 10/72] scripts/qom-fuse: use QOMCommand.qom_list() Date: Tue, 3 Nov 2020 19:35:00 -0500 Message-Id: <20201104003602.1293560-11-jsnow@redhat.com> In-Reply-To: <20201104003602.1293560-1-jsnow@redhat.com> References: <20201104003602.1293560-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 01:02:05 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cleber Rosa , John Snow , Markus Armbruster , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" the qom_list method provides a type-safe object that's easier to type check, so switch to using it. Signed-off-by: John Snow --- scripts/qmp/qom-fuse | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/scripts/qmp/qom-fuse b/scripts/qmp/qom-fuse index f9bf85f38217..b1030273efaa 100755 --- a/scripts/qmp/qom-fuse +++ b/scripts/qmp/qom-fuse @@ -95,7 +95,7 @@ class QOMFuse(QOMCommand, Operations): def is_object(self, path): """Is the given QOM path an object?""" try: - self.qmp.command('qom-list', path=3Dpath) + self.qom_list(path) return True except QMPResponseError: return False @@ -106,8 +106,8 @@ class QOMFuse(QOMCommand, Operations): if path =3D=3D '': path =3D '/' try: - for item in self.qmp.command('qom-list', path=3Dpath): - if item['name'] =3D=3D prop: + for item in self.qom_list(path): + if item.name =3D=3D prop: return True return False except QMPResponseError: @@ -119,11 +119,9 @@ class QOMFuse(QOMCommand, Operations): if path =3D=3D '': path =3D '/' try: - for item in self.qmp.command('qom-list', path=3Dpath): - if item['name'] =3D=3D prop: - if item['type'].startswith('link<'): - return True - return False + for item in self.qom_list(path): + if item.name =3D=3D prop and item.link: + return True return False except QMPResponseError: return False @@ -201,8 +199,8 @@ class QOMFuse(QOMCommand, Operations): def readdir(self, path, fh): yield '.' yield '..' - for item in self.qmp.command('qom-list', path=3Dpath): - yield str(item['name']) + for item in self.qom_list(path): + yield item.name =20 =20 if __name__ =3D=3D '__main__': --=20 2.26.2