From nobody Fri May 17 06:07:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1604413035; cv=none; d=zohomail.com; s=zohoarc; b=FM7hCJ6dYaGDUDRlGeuOocL1RUxJWdrNxEd2dDrm7TW/dM6Ut9u/qkjHaIay9qDDOWieo0DO8iEu4162vQiwkj61TfHemzqYCy+leSJwvDjCE7JoxsLWSC3OnkY36A2QgB/0ksW2ZC5dJv6YHS3w48qYQnwpYOsWX4THwg5r+Sc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604413035; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=GCaaj1QfbjtfUrsNgOKvPWlqrBINzAGn9vemG05ove4=; b=PODsDBhymIM+THiBlv4lC13LKIzKO8oHTN8e56VufRy5wzk/XH5DuH0kuK1YY5ornwwd+gC143/na+HI1708icV1rcky6YyNq8DhV3fPOFEpndRxx+AKPpQ+sWU6qRqNkn6Ib0EP+5xIa5bk+xapu+DLa2dbfe8SnPTyd5iNFwM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604413034948195.42723348673462; Tue, 3 Nov 2020 06:17:14 -0800 (PST) Received: from localhost ([::1]:39102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZx7a-0006EP-13 for importer@patchew.org; Tue, 03 Nov 2020 09:17:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZx63-0005F9-I9 for qemu-devel@nongnu.org; Tue, 03 Nov 2020 09:15:39 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:44661) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZx61-0007bg-OY for qemu-devel@nongnu.org; Tue, 03 Nov 2020 09:15:39 -0500 Received: by mail-wr1-x442.google.com with SMTP id b3so12821370wrx.11 for ; Tue, 03 Nov 2020 06:15:37 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id e6sm19225027wrs.7.2020.11.03.06.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 06:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GCaaj1QfbjtfUrsNgOKvPWlqrBINzAGn9vemG05ove4=; b=H4qiG/dWHBBu1Q+Bay0Fr6owZeDY5zX5bJC+jUCy5AdBWRIT7txkREbV0K39YAuL7s BhR14SiP2giUTgwjNd2vMKN/MeHlfr31JR0eLV17JHSAUaa181UU8h6JUGc+nu0vsclt 07fbfM2sPHF2w77x8HrUDSk/VvWUsN2DDP4T9UXyH+Gw4LZ+ltymr9tDfnL0uBeuLYoY NYmBdA8LeXiXs5SdDh+A1M7UOKtUPVLru2WNghDzMMCLts0aygBd2Mq5vC0faicjut+y f9oM8l4jaD2eyyLEX74H51koYT4h0za7X4n4E+hzxKLCPCZ3onknwGXpsr1byvWWa7H/ H92Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GCaaj1QfbjtfUrsNgOKvPWlqrBINzAGn9vemG05ove4=; b=RBVlD8Xb26elk8a7+W1BnrF09qNARew08VG1HTJ++IDgq5g2v/FY3QXAISDziC5IxQ WdudqxAQDwkyr8PvbgPtpOIyvxg7A7T4IJFIWhvErA6WhB9cM16lQk8dMJsEydgBhRBL bX4dQ9yZ8nKkdMFfK+zLhOGKqkD0nu7/+odSSUAd8gI6uTPiLHCDCABoCpm839kCta09 rxK3z4m1csuVXki/ZxK5AU3M7ChbzJNBtiLghLKKQXVAskbJtq66YaeFGNfa8H6ibzvR sbXjg4pcpWymLv2DXvSL9oEGjH7nTBQO9Bzk2HkPrdXKu3juzkQPi/VSJ5Ps+/RaqDKc dI5A== X-Gm-Message-State: AOAM531YK4+c/O10bJVh4X2y9kyIqbNN7DvWEsKHIGaDPN0bsf0cVFkF CY30ubY2ZNulQHilGuDsfxDwofyQmRqKqA== X-Google-Smtp-Source: ABdhPJzDyDJq1+ADPj6sgnF6ASerkiOp7Ivl9ECwt7BY/d8B87NRVubmb/y8LFe4vD817Vtuoys4Tw== X-Received: by 2002:a5d:5548:: with SMTP id g8mr26363343wrw.364.1604412935856; Tue, 03 Nov 2020 06:15:35 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH] linux-user: Check copy_from_user() return value in vma_dump_size() Date: Tue, 3 Nov 2020 14:15:32 +0000 Message-Id: <20201103141532.19912-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Coverity points out that we don't check the return value from copy_from_user() in vma_dump_size(). This is to some extent a "can't happen" error since we've already checked the page with an access_ok() call earlier, but it's simple enough to handle the error anyway. Fixes: Coverity CID 1432362 Signed-off-by: Peter Maydell Reviewed-by: Laurent Vivier --- linux-user/elfload.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index bf8c1bd2533..e19d0b5cb05 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -3484,7 +3484,9 @@ static abi_ulong vma_dump_size(const struct vm_area_s= truct *vma) if (vma->vma_flags & PROT_EXEC) { char page[TARGET_PAGE_SIZE]; =20 - copy_from_user(page, vma->vma_start, sizeof (page)); + if (copy_from_user(page, vma->vma_start, sizeof (page))) { + return 0; + } if ((page[EI_MAG0] =3D=3D ELFMAG0) && (page[EI_MAG1] =3D=3D ELFMAG1) && (page[EI_MAG2] =3D=3D ELFMAG2) && --=20 2.20.1