From nobody Fri May 17 05:54:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1604397271; cv=none; d=zohomail.com; s=zohoarc; b=bPnSUtiXu4IpbHjyEjKJtObOJg2qTvBGefFJaagvr7ZUTIiaiYe94dimvgB8PrVnnFZJLgM93cgGMefnMq1BN/lH2LoMZjB3Sc1YrKbEaUAZmfna4EtigHTw4KMcJITxjyH87fONZ1GUVWolW5bZdBDqEtQFihusAiKe+/boNNw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604397271; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=dIeYI3mGI6cWfazizk8AENnWAxKGhZ+ba0ddoi/kziQ=; b=T+wICra05+gBE/TpNKU5chxHaIvnUtj/t204lrAB51mInGSFo96w3PNelmpU+S7kZVizsdIN1ZT+EjEyZqukXgXwfnx4EEisRQKk/3JZqryyKCEh0rsTxs9gnuQkka3ASnGRbQWZPtrE4XbM3wvlmqBfQugUeq8Mmdhyar4EESI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16043972718816.3701088363779945; Tue, 3 Nov 2020 01:54:31 -0800 (PST) Received: from localhost ([::1]:36166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZt1K-0008H6-6f for importer@patchew.org; Tue, 03 Nov 2020 04:54:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZpZW-00009a-Iy for qemu-devel@nongnu.org; Tue, 03 Nov 2020 01:13:34 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2431) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZpZT-0004DV-2a for qemu-devel@nongnu.org; Tue, 03 Nov 2020 01:13:34 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CQKGC0v8DzLmc9; Tue, 3 Nov 2020 14:13:07 +0800 (CST) Received: from DESKTOP-F1615D3.china.huawei.com (10.174.186.85) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Tue, 3 Nov 2020 14:13:02 +0800 From: Zihao Chang To: , Subject: [PATCH] scsi: allow user to set werror as report Date: Tue, 3 Nov 2020 14:12:40 +0800 Message-ID: <20201103061240.1364-1-changzihao1@huawei.com> X-Mailer: git-send-email 2.22.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.186.85] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=changzihao1@huawei.com; helo=szxga05-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/02 20:52:53 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 03 Nov 2020 04:53:44 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: changzihao1@huawei.com, qemu-devel@nongnu.org, xiexiangyou@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" 'enospc' is the default for -drive, but qemu allows user to set drive option werror. If werror of scsi-generic is set to 'report' by user, qemu will not allow vm to start. This patch allow user to set werror as 'report' for scsi-generic. Signed-off-by: Zihao Chang Reviewed-by: Fam Zheng --- hw/scsi/scsi-generic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c index 2cb23ca891..2730e37d63 100644 --- a/hw/scsi/scsi-generic.c +++ b/hw/scsi/scsi-generic.c @@ -664,7 +664,8 @@ static void scsi_generic_realize(SCSIDevice *s, Error *= *errp) return; } =20 - if (blk_get_on_error(s->conf.blk, 0) !=3D BLOCKDEV_ON_ERROR_ENOSPC) { + if (blk_get_on_error(s->conf.blk, 0) !=3D BLOCKDEV_ON_ERROR_ENOSPC && + blk_get_on_error(s->conf.blk, 0) !=3D BLOCKDEV_ON_ERROR_REPORT) { error_setg(errp, "Device doesn't support drive option werror"); return; } --=20 2.28.0