From nobody Mon Feb 9 10:58:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604369267; cv=none; d=zohomail.com; s=zohoarc; b=ZGcdaCe1foBm11qov7PLfsd9sEfAz2Cja6mj+4B5Btj3rROdNzLaG5aXwH9zBAxRK+iVkc93YMZ5GYnUT91ZcloMaeSgQmKnXw3hzXLiTwChxJEOicOdSxFXFhZdYCEflyfRsC1VwjVdmMulfNk9ThfXC0+WwaX1mWRsgcxvNo4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604369267; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=v40hj3qY78whRoPdfOU/jnlm9Vu0+VmOWNSL1HaIBaY=; b=WjoDWf2xc2VCANTn0eb0Myctfm6L7ZA6XTnWHYcNZsReEjG/rTVizS1sE0KT1qEEKJg42JW59wzOCw131iGksSr/UxEbcgDj/eUB+4Ke5FP/17cWBaClg6HIyNsc2cnLkXzN9bs/Le5/pkNqPOBdtQ/7MDwKG4Ja3lN7zYZdaMA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1604369267038156.64246694204564; Mon, 2 Nov 2020 18:07:47 -0800 (PST) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-kaedjfTgPqyc8zRfWH83Hg-1; Mon, 02 Nov 2020 21:07:43 -0500 Received: by mail-wr1-f72.google.com with SMTP id t14so7250856wrs.2 for ; Mon, 02 Nov 2020 18:07:43 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id n4sm1270710wmi.32.2020.11.02.18.07.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 18:07:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604369265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v40hj3qY78whRoPdfOU/jnlm9Vu0+VmOWNSL1HaIBaY=; b=DoqOLsmGtEb6DzCfMBFsL6mjm8Iz/eMad8yit2l7Ettpdo5mci4wa+Pdr9u2XcT+wJ+jfx OfQGjgXSjN2UGT4VLShLC0JndEB2is03hjFEatEEOpxLB8a+B9xpz5zFtadtJKtrUD14GG 6NuOKg6oht2jYfynb7NXIJUziiBzDww= X-MC-Unique: kaedjfTgPqyc8zRfWH83Hg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v40hj3qY78whRoPdfOU/jnlm9Vu0+VmOWNSL1HaIBaY=; b=prnTCY0AMyKBXruIpq+EOjNa+Usv44mWXRc+LMZPMD8aDDibwHdzfqO9ZcgQEDl4ok uM1f+0Mj095ARDxZhUlpyGAKD9LJMmo9SVpy+XLOEcCyWSt2qoPgORm2MWRQjOvH85j1 GNe8cr8OYrUW3eizUCVkNp2vTiB8+YEVfndHCAIyla9Lk08pj9F0oNvnJIQRbIqStrkS Ue8CkxStN6T9RBthvpqox5KQg5PkK49oESMfWctjSl9V6VJ++7mwOAlCJ9ouXhJ6uerJ nDovERmqFR6LRIQVbWznYci0txoD3V4uZc2iA5jQQhm1LBW9QGfPZdmUiN79VHj/OugZ uAmA== X-Gm-Message-State: AOAM532D55JxkwqXfzaYBgpYETIZwMdf0nZMQ+BOqb8ACrpMv4UJwiyt wfTGfPMZXB45vLxWQ/Gucw2/uOyUWP0LTyigRVFlFIHUU4sEnk0kTeTUZBjZuriVAqJ2aUCIMOa qu5gC3WAArFIvGQ== X-Received: by 2002:a1c:20d0:: with SMTP id g199mr1017673wmg.68.1604369262033; Mon, 02 Nov 2020 18:07:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJz450qaEXBid9Vp8M8JguvttfT2sSjp/RpJ8d68k3Znh00PpBSFmmEbKwWxsNsWH3KJKRcZJA== X-Received: by 2002:a1c:20d0:: with SMTP id g199mr1017655wmg.68.1604369261850; Mon, 02 Nov 2020 18:07:41 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Stefan Hajnoczi , Kevin Wolf , Eric Auger , Max Reitz , Fam Zheng , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alex Williamson Subject: [PATCH-for-5.2 v3 1/7] util/vfio-helpers: Improve reporting unsupported IOMMU type Date: Tue, 3 Nov 2020 03:07:27 +0100 Message-Id: <20201103020733.2303148-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201103020733.2303148-1-philmd@redhat.com> References: <20201103020733.2303148-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Change the confuse "VFIO IOMMU check failed" error message by the explicit "VFIO IOMMU Type1 is not supported" once. Example on POWER: $ qemu-system-ppc64 -drive if=3Dnone,id=3Dnvme0,file=3Dnvme://0001:01:00.0= /1,format=3Draw qemu-system-ppc64: -drive if=3Dnone,id=3Dnvme0,file=3Dnvme://0001:01:00.0/= 1,format=3Draw: VFIO IOMMU Type1 is not supported Suggested-by: Alex Williamson Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- util/vfio-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c index c469beb0616..14a549510fe 100644 --- a/util/vfio-helpers.c +++ b/util/vfio-helpers.c @@ -300,7 +300,7 @@ static int qemu_vfio_init_pci(QEMUVFIOState *s, const c= har *device, } =20 if (!ioctl(s->container, VFIO_CHECK_EXTENSION, VFIO_TYPE1_IOMMU)) { - error_setg_errno(errp, errno, "VFIO IOMMU check failed"); + error_setg_errno(errp, errno, "VFIO IOMMU Type1 is not supported"); ret =3D -EINVAL; goto fail_container; } --=20 2.26.2