From nobody Tue Feb 10 14:32:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1604369485; cv=none; d=zohomail.com; s=zohoarc; b=MAYbmsFMctVs67CR7T3a+syzX9mnCB+7uBiEK7gHxmHYvMN6PK1NLI+NfmGrOnjmmRN1mPbEb4+PzZIXXay7tRr9We8xnz8m/fQOMyJt7HMH2Ez6XQFj4N6IJFyc7vOpxoDA8EDwHxMa+9THaujBRKTgCetuKwwe98AP9VsHmKA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604369485; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=okzYVp/lrhg5h73CqFrXalTrKpwAgdsNQcRtKsLFx6k=; b=MZqGMawfr3Nuuhcke2acAVGOAjDg68g0TZ8h42Bvx4QJpMI6if68pFj3CEH94mvFMFtYhNR2p4r51VG4L4a+XpSCWKtVMgpB2H+blJlOjAP2h7xo+ZB8TTDHSVSvWIT0DO+QZdwfJ8Y+9yefXAmEWAWPhyWDOYaCX87OAng7h3A= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604369485197652.9674740837091; Mon, 2 Nov 2020 18:11:25 -0800 (PST) Received: from localhost ([::1]:43098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZlnA-0003kd-1l for importer@patchew.org; Mon, 02 Nov 2020 21:11:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZlXh-0003Mv-3H; Mon, 02 Nov 2020 20:55:25 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZlVW-0001qK-Vk; Mon, 02 Nov 2020 20:55:24 -0500 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CQCV52BHyzhbQl; Tue, 3 Nov 2020 09:53:01 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Tue, 3 Nov 2020 09:52:52 +0800 From: Chen Qun To: , Subject: [PATCH 6/6] migration: fix uninitialized variable warning in migrate_send_rp_req_pages() Date: Tue, 3 Nov 2020 09:52:28 +0800 Message-ID: <20201103015228.2250547-7-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201103015228.2250547-1-kuhn.chenqun@huawei.com> References: <20201103015228.2250547-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=szxga05-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/02 20:52:53 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, Juan Quintela , "Dr. David Alan Gilbert" , ganqixin@huawei.com, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" After the WITH_QEMU_LOCK_GUARD macro is added, the compiler cannot identify that the statements in the macro must be executed. As a result, some varia= bles assignment statements in the macro may be considered as unexecuted by the = compiler. The compiler showed warning: migration/migration.c: In function =E2=80=98migrate_send_rp_req_pages=E2=80= =99: migration/migration.c:384:8: warning: =E2=80=98received=E2=80=99 may be use= d uninitialized in this function [-Wmaybe-uninitialized] 384 | if (received) { | ^ Add a default value for 'received' to prevented the warning. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 9bb4fee5ac..de90486a61 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -361,7 +361,7 @@ int migrate_send_rp_req_pages(MigrationIncomingState *m= is, RAMBlock *rb, ram_addr_t start, uint64_t had= dr) { void *aligned =3D (void *)(uintptr_t)(haddr & (-qemu_ram_pagesize(rb))= ); - bool received; + bool received =3D false; =20 WITH_QEMU_LOCK_GUARD(&mis->page_request_mutex) { received =3D ramblock_recv_bitmap_test_byte_offset(rb, start); --=20 2.27.0