From nobody Mon Feb 9 10:59:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) client-ip=209.85.221.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1604313946; cv=none; d=zohomail.com; s=zohoarc; b=IrsohOZJR0ucVLzVgtMlpQoB8KY7Js6YfTCwdFxNFW3vqSSCwMczbxUUyieLZztPpQDDROOVHDYG8AkcERRRmQuRO/hXzhsv+xWH5oPbegyaw2zZTYikiJvHKHi6nsMfBwQWjK9gL149oNXKxGCyF7H7iMtxmP/rUPuhhpfIg2c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604313946; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=bHvvPZ7OD8wLFp1gVlSt6ebk0jZS9TrWsAvI0LY+SFc=; b=YVvy0wEdZA4YYnj3Z7nQdUXhZguN1nNT2TknArEk31755Q8KPmNbF+7eZGeSPjir9J5QPdaHtG3TMdeWlNYzvmgYZHuVqort9bSEadStkX9/ITmDyZcMhQjNNgXmECGwej4CUcjrJ+USqBI/0X6copcK6OznWh0dE0QjBz+Cpl4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.zohomail.com with SMTPS id 160431394694222.259286803520695; Mon, 2 Nov 2020 02:45:46 -0800 (PST) Received: by mail-wr1-f42.google.com with SMTP id n15so14033758wrq.2 for ; Mon, 02 Nov 2020 02:45:46 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id b5sm21118940wrs.97.2020.11.02.02.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 02:45:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bHvvPZ7OD8wLFp1gVlSt6ebk0jZS9TrWsAvI0LY+SFc=; b=f6DC8TlHqeCUdQuDLTZZjTNOwZYc3wpmjPwy8XYR3KCuMhh/H0K9+BEOJoa3AAgv0O 66l/stRY1WLqshXCui6zz5rHV9OBF+h4KTMYqXO+5kPmBBaJLGePaouFFseiji6h7Pdv ntx0XnZFhRkFHPkKMkvkuTGX8+do5ay26Rhzj/uTCSJmEbol4fbijRKXUiom19oZ1yzu 8khxf0b8hBjX0VzYRJ+XLBQLSyNa5FZpkUllDKJcy5TGcrm8ejGWAisQ0MA0wm/mZOKF xDNWpkREZ2u2BSmrjuvbA/1MtlIzn06umV1CbOMtxQtOGE6GNR3WCzocvmb18fezixsG QWxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=bHvvPZ7OD8wLFp1gVlSt6ebk0jZS9TrWsAvI0LY+SFc=; b=KAUYjFroN0q70Gvqtzyk6bBj9jxWQsw78QZ9gfPLMXV1lU+zCujnhU6CfyCO8qXhml KbmXSUW2wKu9sKJBS5mPkXcuUsGeFiaXnin/33eQcZeMwEGqk91qX4n2yC3E8BliKdOM 89XwNlel+v4FLIXbn8gRCT2KLpOwvQZL+b5HHzCTCMJFtj1+8YbNMJah5P0pETAIWn9T ngcpp/iOzjnsH+r0LwlYr8ITCNq+XVQpZ7hhD+3dcf1SEfUXoAQ6kP9lhUDUHPa1fCL3 345V6JJjFbWZeE33qGj6wFuwpq6vVl2xtcY+DCd6gR3JMgo++VuUTeKRpXChX1plNwWe ycPQ== X-Gm-Message-State: AOAM531PtJyNA68FKFDoVERr27mOJyjfnX/WvYOMNw1qkmfnsjjpf7T2 NOCo2/58gW2AZsrDTCXp/lY= X-Google-Smtp-Source: ABdhPJyqWN7zNza45G1srCC3ozVw0EDG2fmYljxAg5xpo5m9UjtlsL141sefMeUXtQb7H8NQGJxgzA== X-Received: by 2002:adf:a557:: with SMTP id j23mr20321683wrb.95.1604313945124; Mon, 02 Nov 2020 02:45:45 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Richard Henderson , qemu-trivial@nongnu.org, Peter Maydell , Markus Armbruster , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH-for-5.2 v3] hw/rx/rx-gdbsim: Fix memory leak Date: Mon, 2 Nov 2020 11:45:42 +0100 Message-Id: <20201102104542.2064745-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) As load_device_tree() returns allocated memory, we need to free it. Cc: Yoshinori Sato Fixes: bda19d7bb56 ("hw/rx: Add RX GDB simulator") Reported-by: Coverity (CID 1432307: RESOURCE_LEAK) Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v3: Directly initialize the variable on declaration (Richard) --- hw/rx/rx-gdbsim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/rx/rx-gdbsim.c b/hw/rx/rx-gdbsim.c index 417ec0564b3..285549c79b5 100644 --- a/hw/rx/rx-gdbsim.c +++ b/hw/rx/rx-gdbsim.c @@ -122,9 +122,8 @@ static void rx_gdbsim_init(MachineState *machine) if (dtb_filename) { ram_addr_t dtb_offset; int dtb_size; - void *dtb; + g_autofree void *dtb =3D load_device_tree(dtb_filename, &dtb_s= ize); =20 - dtb =3D load_device_tree(dtb_filename, &dtb_size); if (dtb =3D=3D NULL) { error_report("Couldn't open dtb file %s", dtb_filename); exit(1); --=20 2.26.2