From nobody Mon Feb 9 09:16:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604310887; cv=none; d=zohomail.com; s=zohoarc; b=ioUBpWJx+/Wa05QnIasaeEV7h2dYIOAtjOpoX96tNHJ0tqJY0HlYyRc4I66NX+jAbDUnprrfwdvTM18ZB3wWI162vJIRO9tH+KQ9a/cUIQSuT7Pk22x8ry+tpLc5RgEaBIkQgQ3I8GBY3kp3vxe3Gz3C85LD/022tHBvT7Jpu14= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604310887; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=s/iTVRaIzOY/mgJ8/aSKhEmETvJffoG9bGnxnoeikeo=; b=WaXk8ayoChI01tuY0B0lc9lyHvdZpfexrm2ngzwXuD0Kd6ZvzTh2OJX+XVVe1VYfdh2eomd7BDPx3Ow2f1+FBYXHIeUG7MfSmKSTBCRTlrhcDK4GdMDLQc6KK8prtruE0tnmg2ilWwO3pxO9ZijyCjgkM6DGpiHTudLZnKfGg7M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604310887938275.6541627877866; Mon, 2 Nov 2020 01:54:47 -0800 (PST) Received: from localhost ([::1]:38162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZWY2-0005z0-JF for importer@patchew.org; Mon, 02 Nov 2020 04:54:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZWOF-0002RM-0n for qemu-devel@nongnu.org; Mon, 02 Nov 2020 04:44:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kZWOC-00057M-Oa for qemu-devel@nongnu.org; Mon, 02 Nov 2020 04:44:38 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-540-4KnofYrAPUyjUfrdBRRgbg-1; Mon, 02 Nov 2020 04:44:34 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 237698030C0; Mon, 2 Nov 2020 09:44:33 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-103.ams2.redhat.com [10.36.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E5A7060CCC; Mon, 2 Nov 2020 09:44:32 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 0789210EE553; Mon, 2 Nov 2020 10:44:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604310275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s/iTVRaIzOY/mgJ8/aSKhEmETvJffoG9bGnxnoeikeo=; b=Uar978yC8YojWI0QAAYzV0kljEGk9eaq8kEkjNX1+FCaZCxiDhrAZXkpi8vSSzrBvXzsiu 3CHS5zsqHn0HJhp9Gy7x7Lgjiit58rPqos8yCaN7UBDv0tEg0apIfyC765NpgdBaLZptV4 7U1vrs6UjZOKSibX/X4RIkHfFj4w2lI= X-MC-Unique: 4KnofYrAPUyjUfrdBRRgbg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH v2 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets Date: Mon, 2 Nov 2020 10:44:21 +0100 Message-Id: <20201102094422.173975-11-armbru@redhat.com> In-Reply-To: <20201102094422.173975-1-armbru@redhat.com> References: <20201102094422.173975-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/02 03:02:24 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, berrange@redhat.com, zxq_yx_007@163.com, kraxel@redhat.com, pbonzini@redhat.com, marcandre.lureau@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" unix_listen_saddr() replaces empty @path by unique value. It obtains the value by creating and deleting a unique temporary file with mkstemp(). This is racy, as the comment explains. It's also entirely undocumented as far as I can tell. Goes back to commit d247d25f18 "sockets: helper functions for qemu (Gerd Hoffman)", v0.10.0. Since abstract socket addresses have no connection with filesystem pathnames, making them up with mkstemp() seems inappropriate. Bypass the replacement of empty @path. Reviewed-by: Eric Blake Reviewed-by: Paolo Bonzini Signed-off-by: Markus Armbruster --- util/qemu-sockets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index a578c434c2..671717499f 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -877,7 +877,7 @@ static int unix_listen_saddr(UnixSocketAddress *saddr, return -1; } =20 - if (saddr->path && saddr->path[0]) { + if (saddr->path[0] || saddr->abstract) { path =3D saddr->path; } else { const char *tmpdir =3D getenv("TMPDIR"); --=20 2.26.2