From nobody Mon Feb 9 02:27:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604090287; cv=none; d=zohomail.com; s=zohoarc; b=SglHI0HfvqVpYxXjkT7PJk6yvmUkfXiGpwoUS8/aI9L/nYz711278iPeFEvT9VimjdkUahtCATnE//osBcP36jSIF1PccUU680a0dFDuoTCcx1BTOSPg/XqiHQmVM1S28ZyQiutcFmsfxUFU3l79AVlz85z9WWgz7j4WbaB0RkA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604090287; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HSOOxfNhrZ9l5ZrJ8GMDAt4DHKLA5YsaRSPlCu3byRQ=; b=ntlsbPdq7PQsnYNObuZmHotnE01kTt4rUR35Lkhh85D3l6u1yJMvI/K4lzr0eapP+XU8i/uZuXFyjeCl0OBx/pSMFgDPwjT/tL+nqgXBzyf1ypDud+n9fWwY7u4yegUM5WTRU5qKxT+7TntmbVprFkueBXl91JJn3QIX2Iuh/2w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604090287845859.6143515415005; Fri, 30 Oct 2020 13:38:07 -0700 (PDT) Received: from localhost ([::1]:33926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYb9y-0004GA-Ke for importer@patchew.org; Fri, 30 Oct 2020 16:38:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYaua-0000uW-GI for qemu-devel@nongnu.org; Fri, 30 Oct 2020 16:22:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kYauV-0007lb-T3 for qemu-devel@nongnu.org; Fri, 30 Oct 2020 16:22:11 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-45-HPeGaDuTN2ilc2nQhs-VrQ-1; Fri, 30 Oct 2020 16:22:04 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1A7D107AFB2; Fri, 30 Oct 2020 20:22:03 +0000 (UTC) Received: from localhost (ovpn-114-68.rdu2.redhat.com [10.10.114.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21F1B6198D; Fri, 30 Oct 2020 20:22:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604089326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HSOOxfNhrZ9l5ZrJ8GMDAt4DHKLA5YsaRSPlCu3byRQ=; b=SNcdYgpiTLNAPFLy6ScFif/bQxb4m/Gtu51n0eT7qv0eE+STnYcPCgXyLQSLi3nMCl9gKW c/WI6rhKmW5OKN0CRLkzz0J3wCZAwNyFD8FE8bG/l2owm/bTt+MlZX3bJJCA/nZQpQKGI6 /8PLy9NQ9uRkGxSkmBgfHcTo3Lsw1Ss= X-MC-Unique: HPeGaDuTN2ilc2nQhs-VrQ-1 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH 17/20] colo-compare: Remove unnecessary prefix from error message Date: Fri, 30 Oct 2020 16:21:28 -0400 Message-Id: <20201030202131.796967-18-ehabkost@redhat.com> In-Reply-To: <20201030202131.796967-1-ehabkost@redhat.com> References: <20201030202131.796967-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/30 16:21:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Jason Wang , Markus Armbruster , Li Zhijian Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" object_property_parse() will add a "Property '.' can't take value ''" prefix automatically for us. Signed-off-by: Eduardo Habkost --- Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Cc: qemu-devel@nongnu.org --- net/colo-compare.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 3a45d64175..ae61e32c5b 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -1097,8 +1097,7 @@ static void compare_set_timeout(Object *obj, Visitor = *v, return; } if (!value) { - error_setg(errp, "Property '%s.%s' requires a positive value", - object_get_typename(obj), name); + error_setg(errp, "timeout can't be zero"); return; } s->compare_timeout =3D value; @@ -1125,8 +1124,7 @@ static void compare_set_expired_scan_cycle(Object *ob= j, Visitor *v, return; } if (!value) { - error_setg(errp, "Property '%s.%s' requires a positive value", - object_get_typename(obj), name); + error_setg(errp, "expired_scan_cycle can't be zero"); return; } s->expired_scan_cycle =3D value; @@ -1153,8 +1151,7 @@ static void set_max_queue_size(Object *obj, Visitor *= v, goto out; } if (!value) { - error_setg(&local_err, "Property '%s.%s' requires a positive value= ", - object_get_typename(obj), name); + error_setg(errp, "queue size can't be zero"); goto out; } max_queue_size =3D value; --=20 2.28.0