From nobody Fri May 17 23:24:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604070599; cv=none; d=zohomail.com; s=zohoarc; b=EOkF8cJX4SblsObn71FsC8qogez46/6Gh8mN+cOoqU2dkYo1AC61VpHOt2UQNGUJWl+2fybb2iv3q87+3WREuN2/ydF42LjXmTsN0pPas0itTZqgdTGrmIC2M8To3cEHsv6UAT6nR85cdiMxftLEYNEEWdliqbavbaNhUVOrBBM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604070599; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=NslL+8MYXzNC6tAMGQfCXeMzktZ0gagTiI4JSbA18W8=; b=jTxMmIMLs6yAaSp6SqKvQCHajjv81Tspdq9SLNCvW1LeBptW9nnntk856YTyxhLMRW08eyiaPoBQbDUlJskzgk+LrnMOn4qC5LKt5ltHR061JC05DIGg5FV1TohYQMYLWuXfGd1uxyPYcsOGmcGtoOCVZ8WmFkVl/AhzjSevBzM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1604070599171286.41630100113946; Fri, 30 Oct 2020 08:09:59 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-097P75NAO-mpIox4WPFgPQ-1; Fri, 30 Oct 2020 11:09:55 -0400 Received: by mail-wr1-f69.google.com with SMTP id i1so2755635wrb.18 for ; Fri, 30 Oct 2020 08:09:54 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id r3sm11201258wrm.51.2020.10.30.08.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 08:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604070596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NslL+8MYXzNC6tAMGQfCXeMzktZ0gagTiI4JSbA18W8=; b=ZvBuidanGOEzO1ADyWwmeq88zdE2eRyZ+799Yx6Lqj7AzLEaDshspxO8/c0EZveZdlA+1i zeC+90MpmYWocqdJvq+ZT9rbkLMMFcUsQJKOIIOiwKcfPg8XKRcjH+08iwg/06QwX1mwfr X7o53NJ8zpUW5qA5SqMSIMri0hZTnZo= X-MC-Unique: 097P75NAO-mpIox4WPFgPQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NslL+8MYXzNC6tAMGQfCXeMzktZ0gagTiI4JSbA18W8=; b=EAQPr6MwC7yc9pjjP9zjbJAy5DswQpwir9QR8NaZ6L6DnPl/xNw8KLMMepccDUQagl flLNR09Afx82cN4VdD9G+ajJxWIyLCy7r7MS2v9iw/2j3XJIr8mxYwIKbxaftGokdHvE DirJGdvTCof9b3RZ8/5R3C+FlsbBAB01cCYyjzHGzJR2VJZEopytB5iLkS2oZGdCOzi7 rLFOCBC1c6Zai+jkG2Y66aPnINkKR3Jsi4SktNO7yeVBMLoifzlyEksOqz3zAhMgejxh tG7QRSMfKM7Vq+0dtDdzXKUsBNBxPmsOlUYdkd6bobPALRe/VafvBfc71huBUBKvrucV tVSg== X-Gm-Message-State: AOAM532oDOg5E7YqRiHhe8gu6zQJEUbDpIw7x+8VxJe8Sv/u73JCoFOG RL1pU4qQ4PYY+CHe4dJU892bWo29XGnIWayY+bTstRc47ZgwwGuWHFgGxndqAHZV0HZPmd5dixs nhtK3rgRgkN3ySg== X-Received: by 2002:a5d:4f0b:: with SMTP id c11mr3711626wru.316.1604070593860; Fri, 30 Oct 2020 08:09:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy08572UuSUWEeSTw0/5piLBtMPI1ONmMzgcSLEM/xGd+3me2lR8GDNrpGpbFFn7UfWUdBDnQ== X-Received: by 2002:a5d:4f0b:: with SMTP id c11mr3711608wru.316.1604070593710; Fri, 30 Oct 2020 08:09:53 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , "Dr. David Alan Gilbert" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH-for-5.2] tools/virtiofsd: Check vu_init() return value (CID 1435958) Date: Fri, 30 Oct 2020 16:09:51 +0100 Message-Id: <20201030150951.1542382-1-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Since commit 6f5fd837889, vu_init() can fail if malloc() returns NULL. This fixes the following Coverity warning: CID 1435958 (#1 of 1): Unchecked return value (CHECKED_RETURN) Fixes: 6f5fd837889 ("libvhost-user: support many virtqueues") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_virtio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index 324936948d3..3a32256e7af 100644 --- a/tools/virtiofsd/fuse_virtio.c +++ b/tools/virtiofsd/fuse_virtio.c @@ -1013,8 +1013,10 @@ int virtio_session_mount(struct fuse_session *se) se->vu_socketfd =3D data_sock; se->virtio_dev->se =3D se; pthread_rwlock_init(&se->virtio_dev->vu_dispatch_rwlock, NULL); - vu_init(&se->virtio_dev->dev, 2, se->vu_socketfd, fv_panic, NULL, - fv_set_watch, fv_remove_watch, &fv_iface); + if (!vu_init(&se->virtio_dev->dev, 2, se->vu_socketfd, fv_panic, NULL, + fv_set_watch, fv_remove_watch, &fv_iface)) { + return -1; + } =20 return 0; } --=20 2.26.2