From nobody Mon May 20 21:14:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) client-ip=209.85.221.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1604065764; cv=none; d=zohomail.com; s=zohoarc; b=HfhWcJ9MJYW9HcYzxxBNbD0yc2SbX+Ii64t2VCo35DPGPPY0janeRMIE8lB6HDf+HcZWLauTai0ARW9Ozgp+sxglwmqeJolqI0SFY9TGEkGvhsOBLTCXVAX4Q4utomWEgbDwRkBfkYbEamcdeKEViy0XD49wBLcn7EStG8a2w3Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604065764; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=enUHVE6/PhcWn+p+KJmbDxlEVfrqGZDvXq7Vvykiais=; b=Bho/PkDvbX1NJmSF4JrOXf+p+4gK8/kvw+WZekiRxXKJImc75MmARQ2y2wShOLcda7lo7duP5dXVQoimx5A6hRSD5AmNboJsaDACP9m4/oKIxbzw32Sy1aoLm4pxPJqwCgU22+Rx1EYZYTfwXZAeaakpxkClHttEYuwt07w04p0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.zohomail.com with SMTPS id 160406576397686.42708274805523; Fri, 30 Oct 2020 06:49:23 -0700 (PDT) Received: by mail-wr1-f51.google.com with SMTP id y12so6543852wrp.6 for ; Fri, 30 Oct 2020 06:49:23 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id 205sm4905578wme.38.2020.10.30.06.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 06:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=enUHVE6/PhcWn+p+KJmbDxlEVfrqGZDvXq7Vvykiais=; b=l15NxchqxHP32IrV97Oaxdtzr3ovzT8yLhgt2wRUvgCAe+k7EG0A73U8V/OnUV6knl mW/82zxGRrjpSgDx7j1UkrKtlzvzYUawaXKtHGo8/LSClAxg8aCDf/RZzVdPCUdkMj3b RogjorSz2dAWz6uTvdGdEFSkbua9jx1OVGT36A1S9IfT+SPOxUutc4IhJ7NnO2MYT/2Y bZCVhECEs/7oiCr0lwZQKBuVCLrnQYhU88EhWS6eURYfaI0wDq7yGToLcgvTLQ16mbW4 suzBM5oZg/umkpm0UGQzttAQlQcXDf0whC0PQGST+nYHCJ5oss0T7MkM1smJBYAE27MP ztbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=enUHVE6/PhcWn+p+KJmbDxlEVfrqGZDvXq7Vvykiais=; b=GsiwHWO+kWNeV7zfDQQpN0B0PM0OAi+FBxLKxI+h+H2rXM9z8K4KuMvg/1xo81Otkc UgSscnPg1AxBGv0GnSBa3hol+X7euLsuUuL/ZbYZtHUdVw9dfEO6qNMlj9/uYhXDHS3u kAuWEf1u5erPh5MU7wiF7MaieF4Jjcwty7YUPzCPi0/gnminRdaLp15n2bxvLOQoInXE SzjdSjTxuRqLczAjh8ctnpoMNy23JkeQipn2QTuet2Mb3XHIT01NsrvtHEaUVIoat4z/ nUp2h+aVmS3VeSZb6I0un46nmIjNb5PPN6x9Ww+qIR2bpGAGQ3EuWmQ8vfR4dyPg+pJB Uk2w== X-Gm-Message-State: AOAM533WQP/HCBYEWYKmF5Iknia1mPH91PJuiMuvGE0R1beA9uFSxj0B tqEM1VP2BonjT5b5AY9Dv3E= X-Google-Smtp-Source: ABdhPJw0zNnE0bCthm0WUdrS9gHjSkaetEIKU5DDAWJXPMiZblBQdUYRYj47r5Vlufe4HkxmVOm9NA== X-Received: by 2002:a5d:4f8c:: with SMTP id d12mr3369673wru.351.1604065762105; Fri, 30 Oct 2020 06:49:22 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Richard Henderson , Peter Maydell , qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-5.2 v2] hw/rx/rx-gdbsim: Fix memory leak Date: Fri, 30 Oct 2020 14:49:18 +0100 Message-Id: <20201030134918.1518930-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) As load_device_tree() returns allocated memory, we need to free it. Cc: Yoshinori Sato Fixes: bda19d7bb56 ("hw/rx: Add RX GDB simulator") Reported-by: Coverity (CID 1432307: RESOURCE_LEAK) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: NULL-initialize (Richard) --- hw/rx/rx-gdbsim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rx/rx-gdbsim.c b/hw/rx/rx-gdbsim.c index 417ec0564b3..d70865962e8 100644 --- a/hw/rx/rx-gdbsim.c +++ b/hw/rx/rx-gdbsim.c @@ -122,7 +122,7 @@ static void rx_gdbsim_init(MachineState *machine) if (dtb_filename) { ram_addr_t dtb_offset; int dtb_size; - void *dtb; + g_autofree void *dtb =3D NULL; =20 dtb =3D load_device_tree(dtb_filename, &dtb_size); if (dtb =3D=3D NULL) { --=20 2.26.2