From nobody Mon Feb 9 06:49:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604009976; cv=none; d=zohomail.com; s=zohoarc; b=iLDbbMKyghZKH/+BElcutjcXLiy2LXS9bx6ntvXP0YQTZnDt9JOzgBHPXnDe3zA7zoIQPaO37Q0U90+wNbLjSt7DXpP7dyVj7Zb0Zp/OE/xADZnzwRkOYLo46OyRVZEI3N4l9nfCBo6caKaYr+CNO4ZFfPG42raXiNL+ATqT3Oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604009976; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sgwEPM/lfC5i3EXhA07sXzEDbOJAoJ6t3BEQVnT1duU=; b=Sb+9bing65Kt1ntaEGcf+q+LVreoFEU5bOqWHdGOq7Ij2oBvVn0XCb8SbhJVjq5s7A8z2D4O2n5zgZlYkfbe2SqrNj9jfYaixHLpgBJ5Wrw94JPo3gL7wfUumWixyXCW48kkYg8kr/KVCHt7nAydJiCzHV9CrvDEZWgfmPiwC5I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604009976617323.3715064765638; Thu, 29 Oct 2020 15:19:36 -0700 (PDT) Received: from localhost ([::1]:50580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYGGd-0000Ta-JX for importer@patchew.org; Thu, 29 Oct 2020 18:19:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYG1N-0003aI-6u for qemu-devel@nongnu.org; Thu, 29 Oct 2020 18:03:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30639) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kYG1H-0006bA-8s for qemu-devel@nongnu.org; Thu, 29 Oct 2020 18:03:48 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-529-pJr4Qc8mN-y9ET5S-SuGiQ-1; Thu, 29 Oct 2020 18:03:33 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E72F89CC00 for ; Thu, 29 Oct 2020 22:03:32 +0000 (UTC) Received: from localhost (ovpn-114-68.rdu2.redhat.com [10.10.114.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id A88D75578C; Thu, 29 Oct 2020 22:03:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604009015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sgwEPM/lfC5i3EXhA07sXzEDbOJAoJ6t3BEQVnT1duU=; b=atLRqjQqtxnKZrYV9uVK2dd5eb0zY/TswrzAD9xNleBlYZAEsoUCUOhAy7/1RQjtSI2xlN A1Rk+hSpkCYXFrf96cOe9nh5yFOz2WIgKMJadIhOvSOWchGXpi5FVWpv4XbFTHjqQB33NQ 4Qi7h0kPismrBCQJdWPnZO0FHCpD31I= X-MC-Unique: pJr4Qc8mN-y9ET5S-SuGiQ-1 From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH 18/36] qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen() Date: Thu, 29 Oct 2020 18:02:28 -0400 Message-Id: <20201029220246.472693-19-ehabkost@redhat.com> In-Reply-To: <20201029220246.472693-1-ehabkost@redhat.com> References: <20201029220246.472693-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/29 00:47:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P. Berrange" , John Snow , Markus Armbruster , Igor Mammedov , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) We're just doing pointer math with the device pointer, we can simply use obj instead. Signed-off-by: Eduardo Habkost --- Cc: Paolo Bonzini Cc: "Daniel P. Berrang=C3=A9" Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- hw/core/qdev-properties.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 68b1666e14..27c09255d7 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -610,10 +610,9 @@ static void set_prop_arraylen(Object *obj, Visitor *v,= const char *name, * array-length field in the device struct, we have to create the * array itself and dynamically add the corresponding properties. */ - DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; uint32_t *alenptr =3D qdev_get_prop_ptr(obj, prop); - void **arrayptr =3D (void *)dev + prop->arrayoffset; + void **arrayptr =3D (void *)obj + prop->arrayoffset; void *eltptr; const char *arrayname; int i; @@ -653,7 +652,7 @@ static void set_prop_arraylen(Object *obj, Visitor *v, = const char *name, * they get the right answer despite the array element not actually * being inside the device struct. */ - arrayprop->prop.offset =3D eltptr - (void *)dev; + arrayprop->prop.offset =3D eltptr - (void *)obj; assert(qdev_get_prop_ptr(obj, &arrayprop->prop) =3D=3D eltptr); object_property_add(obj, propname, arrayprop->prop.info->name, --=20 2.28.0