From nobody Mon Feb 9 11:34:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.68 as permitted sender) client-ip=209.85.208.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1603997712; cv=none; d=zohomail.com; s=zohoarc; b=YhWBec/PZJGgzlJ+LxUIsZ+58UCVtBqHiAzi8qoIAF1vIdgyhNe9vCHu0UjG4YSKjwuH92uIvFWnMUfMP1uDceOFPrHsqsH35CA9eR8+vJQHMTOh/EEkt9WDnmspbfFfFoI0Xh1xKnYr5MQK8wlsTUWw6LTXNU+a3xQoaXJDNAk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603997712; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=IJFpktSa/8kby6D0fReWnEGX7kDurZe78cM6aB2YW5Y=; b=HdOseLGl3KqvxyDlSP0szH4D/rYnCb8lHpgb+hOA2emnu98vC6dYbdG2OempW3bKwpyYvp7H620s8+Sak6aXH/298VSgdp83qb9QLZ7jPJRgMp585EF6yIody0L4qwqPyduCoYliOPQ3GhPmsBAA+jSOpsJ/ByekOhF94NTRik4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by mx.zohomail.com with SMTPS id 1603997712571244.98914469848603; Thu, 29 Oct 2020 11:55:12 -0700 (PDT) Received: by mail-ed1-f68.google.com with SMTP id l16so4170249eds.3 for ; Thu, 29 Oct 2020 11:55:10 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id x22sm1932435ejc.102.2020.10.29.11.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 11:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IJFpktSa/8kby6D0fReWnEGX7kDurZe78cM6aB2YW5Y=; b=lo6hWyYwcbd9Oeguy6CSu6xXxX0+oAKQk0In/HQVIcNaTZ39nknFBvGjLgXKcx2MZ5 9zbEu9jhihCZzzerqDIylMP6eYDtVGIGUor0AiygIdHclEFSjEmfm0Rb95YNJuMqRSMb /UDzk299VGNb5A321vBBZjUjOGyHxVGT7bUgUY4i0GkJjauQdcXpsG332NA67NmfFSvA OyAqp9zVcQ4XXiEVj+XuENRvT+Xahtow7NTyYV3BglrPFry+ll2WNDeFhsos3Vye5P8z rJ5UVnnos/K19EoPD93ys0B8iEb4ZyofTRmpboMo49+wrMwo2R96uTHTfYM20n7BNdRi pL4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=IJFpktSa/8kby6D0fReWnEGX7kDurZe78cM6aB2YW5Y=; b=p7GyS2YkNc7KEjZjxt6v1fWm6TL4OEaEXvqBW2riXu+wI5pWdtGysISEYU4KpLWKoU Q+o41i7/iPrYeGXg0JpccFZfQo5xuKKwlT7F5FFLNQP/MU34SbtjSHFtRWZoe7oDJpyx leSthcbbApIGGNwYW02PuiEA+GwSPzPrE+4EqSZMKkm07e55ZlTb6ghQqt+cLyPO6PXR 0jxm9Y+doPwyxX3mgHXhl1NXbkMmQkxeIwieDJj/GKDwIuhkEux5edTtENVosYIGWg2v aSda3/+d97UXcDqz9g7oTZqWAksbD2Q7NIKMTTOPCZnJBOQxmBWzRFv7O2ZamS6I4nus TbMA== X-Gm-Message-State: AOAM531d42rVDiShBJgxkAh9yAWVtyviPyjTs8PUbfTLC2bhpezb2xxx NE0hAxlc1fYdl54Bz91yRy0= X-Google-Smtp-Source: ABdhPJy3BhkoClbm4QX7Bpb5fIT1N6uHwI2iAIctmqJ4Rje6PbWo+HKB7+Egl96gJD86eGH+UeXXuw== X-Received: by 2002:aa7:c2d8:: with SMTP id m24mr5724396edp.90.1603997708665; Thu, 29 Oct 2020 11:55:08 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Eric Blake , Alistair Francis , Richard Henderson , Luc Michel , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost Subject: [PATCH] util/cutils: Silent Coverity array overrun warning in freq_to_str() Date: Thu, 29 Oct 2020 19:55:06 +0100 Message-Id: <20201029185506.1241912-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The biggest input value freq_to_str() can accept is UINT64_MAX, which is ~18.446 EHz, less than 1000 EHz. Add an assertion to help Coverity. This silents CID 1435957: Memory - illegal accesses (OVERRUN): >>> Overrunning array "suffixes" of 7 8-byte elements at element index 7 (byte offset 63) using index "idx" (which evaluates to 7). Reported-by: Eduardo Habkost Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- util/cutils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/cutils.c b/util/cutils.c index c395974fab4..69c0ad7f888 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -891,6 +891,7 @@ char *freq_to_str(uint64_t freq_hz) double freq =3D freq_hz; size_t idx =3D 0; =20 + assert(freq <=3D UINT64_MAX); /* Max 64-bit value is less than 1000 EH= z */ while (freq >=3D 1000.0 && idx < ARRAY_SIZE(suffixes)) { freq /=3D 1000.0; idx++; --=20 2.26.2