From nobody Sat May 18 22:31:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603970036; cv=none; d=zohomail.com; s=zohoarc; b=hBvz5R9eEQfVVUmrQwxAmqX09ZckWggOp/YMiprw66IWPlwddopSx49plPk/bAadpbjqywmpIuK2Lu9S4rOjsLNkluYPzFQUdIUNMy2GzxlLzh/V/4bcIoStIugrJRjiQ+ZaANT+3G+zbzxMoCk6bOJytxBiZnYtOs+UjmjVZ1E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603970036; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4DOGsdntV/cKp0CovcUifZOag+2nYfHYS2F9nfpqRKE=; b=CnUxG/MAMM6y4K9rKVD5h5O/quX8+YB8lC5oVoiLb/+Pzheo80ShIn0Ifx1cdnnHNp+apgZTRA6/22xeROYBIEKEZEQsAp8MgNlbpmgCeaZ/IOBrDsLzd24NUFFoFbBpPiYq+rl9UOrKLpKvr4Q4MgODopugFIw3JxVs/gKFS4w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160397003633790.83342157401057; Thu, 29 Oct 2020 04:13:56 -0700 (PDT) Received: from localhost ([::1]:53042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kY5sQ-0007EG-8h for importer@patchew.org; Thu, 29 Oct 2020 07:13:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY5or-0004Le-8e for qemu-devel@nongnu.org; Thu, 29 Oct 2020 07:10:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26170) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kY5on-0007gq-Rl for qemu-devel@nongnu.org; Thu, 29 Oct 2020 07:10:12 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-20-ZVdtZFcUMGWQCLsWP9sGgw-1; Thu, 29 Oct 2020 07:10:05 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A77331882FB3 for ; Thu, 29 Oct 2020 11:10:04 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1852B1974D; Thu, 29 Oct 2020 11:09:58 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4367F9D74; Thu, 29 Oct 2020 12:09:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603969807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4DOGsdntV/cKp0CovcUifZOag+2nYfHYS2F9nfpqRKE=; b=IixVhFfewrH/UwxkULiz+S1HyawxEyn2IXzuZKO8WhHu0tmHgm5xexxzkGD7NK1Y9OS7f1 bdgFktx+kERAugVwYj8z/9q49+hwN1MmILgJ7Fv1wVyYSvn0AtukwtmWvx023sdaiebHtf gS4jGvhITFF+VvfT2rri8zGOMKCheDM= X-MC-Unique: ZVdtZFcUMGWQCLsWP9sGgw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 1/5] virtio-gpu: add virtio-gpu-pci module Date: Thu, 29 Oct 2020 12:09:53 +0100 Message-Id: <20201029110957.11062-2-kraxel@redhat.com> In-Reply-To: <20201029110957.11062-1-kraxel@redhat.com> References: <20201029110957.11062-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/29 01:47:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Build virtio-gpu pci devices modular. Must be a separate module because not all qemu softmmu variants come with PCI support. Signed-off-by: Gerd Hoffmann Message-id: 20201023064618.21409-2-kraxel@redhat.com --- util/module.c | 3 +++ hw/display/meson.build | 11 +++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/util/module.c b/util/module.c index fe3b82dd4d37..9490f975d303 100644 --- a/util/module.c +++ b/util/module.c @@ -301,6 +301,9 @@ static struct { { "qxl", "hw-", "display-qxl" }, { "virtio-gpu-device", "hw-", "display-virtio-gpu" }, { "vhost-user-gpu", "hw-", "display-virtio-gpu" }, + { "virtio-gpu-pci-base", "hw-", "display-virtio-gpu-pci" }, + { "virtio-gpu-pci", "hw-", "display-virtio-gpu-pci" }, + { "vhost-user-gpu-pci", "hw-", "display-virtio-gpu-pci" }, { "chardev-braille", "chardev-", "baum" }, { "chardev-spicevmc", "chardev-", "spice" }, { "chardev-spiceport", "chardev-", "spice" }, diff --git a/hw/display/meson.build b/hw/display/meson.build index 0d5ddecd6503..669935371335 100644 --- a/hw/display/meson.build +++ b/hw/display/meson.build @@ -62,8 +62,15 @@ if config_all_devices.has_key('CONFIG_VIRTIO_GPU') hw_display_modules +=3D {'virtio-gpu': virtio_gpu_ss} endif =20 -softmmu_ss.add(when: ['CONFIG_VIRTIO_GPU', 'CONFIG_VIRTIO_PCI'], if_true: = files('virtio-gpu-pci.c')) -softmmu_ss.add(when: ['CONFIG_VHOST_USER_GPU', 'CONFIG_VIRTIO_PCI'], if_tr= ue: files('vhost-user-gpu-pci.c')) +if config_all_devices.has_key('CONFIG_VIRTIO_PCI') + virtio_gpu_pci_ss =3D ss.source_set() + virtio_gpu_pci_ss.add(when: ['CONFIG_VIRTIO_GPU', 'CONFIG_VIRTIO_PCI'], + if_true: [files('virtio-gpu-pci.c'), pixman]) + virtio_gpu_pci_ss.add(when: ['CONFIG_VHOST_USER_GPU', 'CONFIG_VIRTIO_PCI= '], + if_true: files('vhost-user-gpu-pci.c')) + hw_display_modules +=3D {'virtio-gpu-pci': virtio_gpu_pci_ss} +endif + softmmu_ss.add(when: 'CONFIG_VIRTIO_VGA', if_true: files('virtio-vga.c')) softmmu_ss.add(when: 'CONFIG_VHOST_USER_VGA', if_true: files('vhost-user-v= ga.c')) =20 --=20 2.27.0 From nobody Sat May 18 22:31:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603970144; cv=none; d=zohomail.com; s=zohoarc; b=HpEghG8npgOr9izN7xybQmXMQa/JVl15ab6HlxUx+uVpTVNjMERz+uuYVwqIbAzhmyrcvpaXA/+CGlw+mt1hEc6Xu66gSnV2HdYHRujkO8uYoGLHQctg+SGPVG653bmjUkMkl/9lWwW9Cq4JCzUU5glsOIT7aSfPlc5BKiYSagk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603970144; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=blvAeadQEj5T+rSb+VOay4hehN/8U9jU+0z8C9GxjC4=; b=krFB6S5VmhTEU1UcLtXzknovjxeEBe0vKBGz9fjB7M3M0FWlnkCh5U2p+ntfGP/Kg/Nc2pMhLD2CU3F6UOpkjvdPGDapBUXhyXE6Mg8jH3YIJGe2MtXLNsQn0BkFDzuWXz2ab94RnBiZeihiBgVLhwFuLpZaS7MZnh5YCVPQmHg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603970144102951.6815400734016; Thu, 29 Oct 2020 04:15:44 -0700 (PDT) Received: from localhost ([::1]:57494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kY5uB-0000eP-20 for importer@patchew.org; Thu, 29 Oct 2020 07:15:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY5or-0004La-4w for qemu-devel@nongnu.org; Thu, 29 Oct 2020 07:10:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23961) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kY5on-0007hG-Sz for qemu-devel@nongnu.org; Thu, 29 Oct 2020 07:10:12 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-Z7louZC3NCGBdecLIWz6_w-1; Thu, 29 Oct 2020 07:10:05 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ABBE557039 for ; Thu, 29 Oct 2020 11:10:04 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 194671975E; Thu, 29 Oct 2020 11:09:58 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4E06D9D0D; Thu, 29 Oct 2020 12:09:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603969807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=blvAeadQEj5T+rSb+VOay4hehN/8U9jU+0z8C9GxjC4=; b=fG848nm4tVKCntpelrYwt9TupRem1Q94INJUJPHC9mU+WQBYYq7M903rjfoG1VMvEhneWS tvq0Ns4MGn3awRghSJ0Vth42WLTct2HHpBaNdtf1BxBTCl0E5++xbg/Huqjv+cekP6c2eU RKnFgDgzqklvedli0meb7PfDVJhDRWQ= X-MC-Unique: Z7louZC3NCGBdecLIWz6_w-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 2/5] virtio-gpu: add virtio-vga module Date: Thu, 29 Oct 2020 12:09:54 +0100 Message-Id: <20201029110957.11062-3-kraxel@redhat.com> In-Reply-To: <20201029110957.11062-1-kraxel@redhat.com> References: <20201029110957.11062-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/29 01:47:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Build virtio-gpu vga devices modular. Must be a separate module because not all qemu softmmu variants come with VGA support. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-Andr=C3=A9 Lureau Message-id: 20201023064618.21409-3-kraxel@redhat.com --- util/module.c | 3 +++ hw/display/meson.build | 10 ++++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/util/module.c b/util/module.c index 9490f975d303..503c399421c5 100644 --- a/util/module.c +++ b/util/module.c @@ -304,6 +304,9 @@ static struct { { "virtio-gpu-pci-base", "hw-", "display-virtio-gpu-pci" }, { "virtio-gpu-pci", "hw-", "display-virtio-gpu-pci" }, { "vhost-user-gpu-pci", "hw-", "display-virtio-gpu-pci" }, + { "virtio-vga-base", "hw-", "display-virtio-vga" }, + { "virtio-vga", "hw-", "display-virtio-vga" }, + { "vhost-user-vga", "hw-", "display-virtio-vga" }, { "chardev-braille", "chardev-", "baum" }, { "chardev-spicevmc", "chardev-", "spice" }, { "chardev-spiceport", "chardev-", "spice" }, diff --git a/hw/display/meson.build b/hw/display/meson.build index 669935371335..11ea2895c5fe 100644 --- a/hw/display/meson.build +++ b/hw/display/meson.build @@ -71,8 +71,14 @@ if config_all_devices.has_key('CONFIG_VIRTIO_PCI') hw_display_modules +=3D {'virtio-gpu-pci': virtio_gpu_pci_ss} endif =20 -softmmu_ss.add(when: 'CONFIG_VIRTIO_VGA', if_true: files('virtio-vga.c')) -softmmu_ss.add(when: 'CONFIG_VHOST_USER_VGA', if_true: files('vhost-user-v= ga.c')) +if config_all_devices.has_key('CONFIG_VIRTIO_VGA') + virtio_vga_ss =3D ss.source_set() + virtio_vga_ss.add(when: 'CONFIG_VIRTIO_VGA', + if_true: [files('virtio-vga.c'), pixman]) + virtio_vga_ss.add(when: 'CONFIG_VHOST_USER_VGA', + if_true: files('vhost-user-vga.c')) + hw_display_modules +=3D {'virtio-vga': virtio_vga_ss} +endif =20 specific_ss.add(when: [x11, opengl, 'CONFIG_MILKYMIST_TMU2'], if_true: fil= es('milkymist-tmu2.c')) specific_ss.add(when: 'CONFIG_OMAP', if_true: files('omap_lcdc.c')) --=20 2.27.0 From nobody Sat May 18 22:31:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603970071; cv=none; d=zohomail.com; s=zohoarc; b=LP65vk+8DRhS0mnQtK1qGOc1rDYoEboMzhLdVlwN0bPvk/cgpDz5BBoMoY/INlVLB4haimCDyXuoGhDzXCCb4NNaD+0sgUVFh2MXTsd9M77TN43/+9rrpdWlHHB84sp+VU5NmfK6lUhIzClR5ao8NTvtPnafgTqd8FT9+I5L1Mg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603970071; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=f1vOJ63AudGIsg4/hFAcXsaUPmWd1EhvZj8XVJc1Zqs=; b=COCi/I1vKNl5XMAVXSCOFoXkePO3FM329YtvJgnKI9Ge6gQkKfxyjTJfhCMt9RwE4Lidpn6Q3fdtCuCtluzyFGDRrnwEw5T0fy8pUfnrdM/BqnPVMC2qGrMr+EUugaIdZ4xlnrWHSpnOoVH1rMIZlHqH+1CWm+M7WlgCFY8M9e8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603970071507651.3351160812829; Thu, 29 Oct 2020 04:14:31 -0700 (PDT) Received: from localhost ([::1]:54590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kY5t0-0007sR-EO for importer@patchew.org; Thu, 29 Oct 2020 07:14:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY5os-0004Ms-8w for qemu-devel@nongnu.org; Thu, 29 Oct 2020 07:10:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:58147) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kY5oo-0007he-3g for qemu-devel@nongnu.org; Thu, 29 Oct 2020 07:10:13 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-4z6oxn5zOxiCiqwZ16oDlg-1; Thu, 29 Oct 2020 07:10:06 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 182395703D for ; Thu, 29 Oct 2020 11:10:05 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E6095C1D0; Thu, 29 Oct 2020 11:09:58 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 58AF79D0E; Thu, 29 Oct 2020 12:09:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603969807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f1vOJ63AudGIsg4/hFAcXsaUPmWd1EhvZj8XVJc1Zqs=; b=PC1e9MqUs7LKC/B2U7EvVxThpSkcTVEiOm6wwoy0ukm+leIjg0l2HcWLUPBUu+n/T4TuHM QoYuS6gWL/o7xnovaKsYbBgm2cKPyMpAukP8aH9rCae97DOAP1uVSgDe4/yOTTLqXL/wfV b2LIBUbqVClQtqEFsrhlCeeARR4wpUQ= X-MC-Unique: 4z6oxn5zOxiCiqwZ16oDlg-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 3/5] virtio-gpu: only compile virtio-gpu-3d.c for CONFIG_VIRGL=y Date: Thu, 29 Oct 2020 12:09:55 +0100 Message-Id: <20201029110957.11062-4-kraxel@redhat.com> In-Reply-To: <20201029110957.11062-1-kraxel@redhat.com> References: <20201029110957.11062-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/29 01:47:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) There is no actual code in the CONFIG_VIRGL=3Dn case. So building is (a) pointless and (b) makes macos ranlib complain. Reported-by: Paolo Bonzini Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-Andr=C3=A9 Lureau Message-id: 20201026142851.28735-1-kraxel@redhat.com --- hw/display/virtio-gpu-3d.c | 4 ---- hw/display/meson.build | 4 +++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index 1bd33d7aedc6..0b0c11474dd3 100644 --- a/hw/display/virtio-gpu-3d.c +++ b/hw/display/virtio-gpu-3d.c @@ -17,8 +17,6 @@ #include "hw/virtio/virtio.h" #include "hw/virtio/virtio-gpu.h" =20 -#ifdef CONFIG_VIRGL - #include =20 static struct virgl_renderer_callbacks virtio_gpu_3d_cbs; @@ -633,5 +631,3 @@ int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g) =20 return capset2_max_ver ? 2 : 1; } - -#endif /* CONFIG_VIRGL */ diff --git a/hw/display/meson.build b/hw/display/meson.build index 11ea2895c5fe..dad3bd2b414b 100644 --- a/hw/display/meson.build +++ b/hw/display/meson.build @@ -57,7 +57,9 @@ softmmu_ss.add(when: [pixman, 'CONFIG_ATI_VGA'], if_true:= files('ati.c', 'ati_2d if config_all_devices.has_key('CONFIG_VIRTIO_GPU') virtio_gpu_ss =3D ss.source_set() virtio_gpu_ss.add(when: 'CONFIG_VIRTIO_GPU', - if_true: [files('virtio-gpu-base.c', 'virtio-gpu.c', '= virtio-gpu-3d.c'), pixman, virgl]) + if_true: [files('virtio-gpu-base.c', 'virtio-gpu.c'), = pixman, virgl]) + virtio_gpu_ss.add(when: ['CONFIG_VIRTIO_GPU', 'CONFIG_VIRGL'], + if_true: [files('virtio-gpu-3d.c'), pixman, virgl]) virtio_gpu_ss.add(when: 'CONFIG_VHOST_USER_GPU', if_true: files('vhost-u= ser-gpu.c')) hw_display_modules +=3D {'virtio-gpu': virtio_gpu_ss} endif --=20 2.27.0 From nobody Sat May 18 22:31:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603969890; cv=none; d=zohomail.com; s=zohoarc; b=dJmoe1muP3bmCM6ix226nLnH8pZWU7YhXrJmiO/9SmkMS0I0eAjHastLKpjIMo7xCtJX0SswUDidqEJ15MT4voaHnLV1C7shsaXvgjcXkyW0h5B+mWwT/5bpgsqMiosmktxbtYIbm8xZWjPhHkaGtwQAKgWd2657LhzX6QuWzUs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603969890; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A47iyUrQOmrPhm7wOWiOvkmMu6xk8xxKAcxFi5chMu8=; b=ehNRVepSCZfu1Q9IwDHiu6HY4rEQtp52B9+x88ax41X1YzUvpslbndg2fdfZCF/2Y0PVBfqGWZ7RhDaqYFeZjbjyxik5FG2Uw98fUDUb0iU+BJGPEdOLj5OiWSxkoSGR6XPrPc33U/H/B3sGr36NYgRU0tv+bY1qsPKoiLMvzZg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603969890556886.0822179069334; Thu, 29 Oct 2020 04:11:30 -0700 (PDT) Received: from localhost ([::1]:48496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kY5q4-0005Iz-DU for importer@patchew.org; Thu, 29 Oct 2020 07:11:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY5or-0004LY-1C for qemu-devel@nongnu.org; Thu, 29 Oct 2020 07:10:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kY5on-0007hF-OF for qemu-devel@nongnu.org; Thu, 29 Oct 2020 07:10:12 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-KDVYDN1ZPzKhuthUY5-LXg-1; Thu, 29 Oct 2020 07:10:05 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BC76A10E218D for ; Thu, 29 Oct 2020 11:10:04 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 28EB82C31E; Thu, 29 Oct 2020 11:09:58 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6171F9D0F; Thu, 29 Oct 2020 12:09:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603969807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A47iyUrQOmrPhm7wOWiOvkmMu6xk8xxKAcxFi5chMu8=; b=VRcIrTp3saa79Enqe7D6xPJR5ReFXq9+K8f2MlFHfBUz+Jy5nBv9818lAC+rOhuHdsRDO+ 3Bnra6MWrx/9fI3P0U2rOMTb3GNI+Q8pktV/shYJocRNp6TrgOWvfhSnxJ21L76jtWkGXd 16wcCBlrPopmjYr6VtT6zfQM7xKXU5Y= X-MC-Unique: KDVYDN1ZPzKhuthUY5-LXg-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 4/5] modules: unbreak them on macos Date: Thu, 29 Oct 2020 12:09:56 +0100 Message-Id: <20201029110957.11062-5-kraxel@redhat.com> In-Reply-To: <20201029110957.11062-1-kraxel@redhat.com> References: <20201029110957.11062-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/29 00:47:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Using the correct shared library suffix helps ;) Signed-off-by: Gerd Hoffmann Message-id: 20201027120603.3625-1-kraxel@redhat.com --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 83610b0db8ea..6df4306c884f 100755 --- a/configure +++ b/configure @@ -618,6 +618,7 @@ Darwin) if test -z "$cpu" && test "$(sysctl -n hw.optional.x86_64)" =3D "1"; then cpu=3D"x86_64" fi + HOST_DSOSUF=3D".dylib" ;; SunOS) # $(uname -m) returns i86pc even on an x86_64 box, so default based on i= sainfo --=20 2.27.0 From nobody Sat May 18 22:31:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603969890; cv=none; d=zohomail.com; s=zohoarc; b=MsFlhMz88bxIw+BVPTiJMF5aBqVz/BzR0azJk+tA1V04RQRT2oywQv42ck+/pBSOkEV3R53cwQDhRE8/EUOgjoeJlk+24ahRQUE4yh7vRzS0TiEWM6r3aRPal55DyWw2LKzzeF6UMLN/I7CdMOgfXRn3KvdpGMqx7w6is3dnhJU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603969890; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ehm26ElGtFAdk5lLj5AhslhtQ6/Lc562tDg+nclAGso=; b=AAchynSQ/xwOq+c51BfvDkSdZqecHQ4ho4Qt5mWWpChH/vEQlmKg+Tr55H3lO0fC9FL13Qy1I5J1JeaXAJdIkxPmME/dEBdqmfkWFo4VcPgQw4FYoYXJ5GrTWVKaaZgJ/KT0bG6DGqC7xsjXaevN/isNaNV00FHJQ/UHR4ChUWY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603969890339689.3892886753856; Thu, 29 Oct 2020 04:11:30 -0700 (PDT) Received: from localhost ([::1]:48518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kY5q4-0005K1-Jl for importer@patchew.org; Thu, 29 Oct 2020 07:11:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY5oq-0004LK-4F for qemu-devel@nongnu.org; Thu, 29 Oct 2020 07:10:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:42427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kY5on-0007i5-PD for qemu-devel@nongnu.org; Thu, 29 Oct 2020 07:10:11 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-538-2qB9JrmLNd-QsIybcAvqoQ-1; Thu, 29 Oct 2020 07:10:06 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 03E238030AB for ; Thu, 29 Oct 2020 11:10:06 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id BC5742C31E; Thu, 29 Oct 2020 11:10:05 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6A7AB9D10; Thu, 29 Oct 2020 12:09:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603969808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ehm26ElGtFAdk5lLj5AhslhtQ6/Lc562tDg+nclAGso=; b=cKpKns2dBfXDdfRSvYd93TYAqwh1BL5ep9i/y0D8RM+EqN1KRsLVGzzuKrUJFwIpBPNVtO 1u5qsAJJNyBQzO2BU8lYJyUEHQ5h9edwveopOWne2baBGr/wQ2a3eZYIMIm063PoNQVewH 7mikWDXHoaqf/2mBI3MhuTVOkIKtGjc= X-MC-Unique: 2qB9JrmLNd-QsIybcAvqoQ-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 5/5] modules: turn off lazy binding Date: Thu, 29 Oct 2020 12:09:57 +0100 Message-Id: <20201029110957.11062-6-kraxel@redhat.com> In-Reply-To: <20201029110957.11062-1-kraxel@redhat.com> References: <20201029110957.11062-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/29 01:47:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We want missing symbols fail module load right away instead of having qemu abort later on in case lazy binding fails. Can happen -- for example -- when trying to load a module for a pci device (virtio-gpu-pci) into a qemu without pci support (qemu-system-avr). Signed-off-by: Gerd Hoffmann Message-id: 20201028054944.5772-1-kraxel@redhat.com --- util/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/module.c b/util/module.c index 503c399421c5..c65060c167df 100644 --- a/util/module.c +++ b/util/module.c @@ -132,7 +132,7 @@ static int module_load_file(const char *fname, bool may= fail, bool export_symbols =20 assert(QTAILQ_EMPTY(&dso_init_list)); =20 - flags =3D G_MODULE_BIND_LAZY; + flags =3D 0; if (!export_symbols) { flags |=3D G_MODULE_BIND_LOCAL; } --=20 2.27.0