From nobody Sat May 18 22:31:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.66 as permitted sender) client-ip=209.85.218.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1603912943; cv=none; d=zohomail.com; s=zohoarc; b=gcxm0Z7rpIKzrwmH6r2KuEgErQuROT4nbEvT5JNlXj/c4J2jZZ124cwPV9qng395sS85kU2syob9CyoztqE4KOSc7/Mv8R9WchD8cYFSaSH5a7GorZXR9Fd5UM20UdCmG3hcd6k1Ha9wWCYXQ5vmo7OrIi6Kuz0FrsdFw5QsF4M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603912943; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=9SFWGQzy7DoB1AdG6aiIW/5zMdxght220eg1eHdpHZg=; b=ZrXWhTC1RQO+1Kc3sfU7M7IYVzHhoDYKKPWSj98cF4cE7VvT817AMAlYPuqlP+zvhBxeU96DdyZGeG4WCXUcf9TMF7LAbuHgVH9jBte8sjuTKq1AV2dL+HdALWokCCbeDcVl1RJM6sC9vVXmHnVO6GRlV3LEyhOg2W+YuF7/c5s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by mx.zohomail.com with SMTPS id 1603912943545779.5736342551894; Wed, 28 Oct 2020 12:22:23 -0700 (PDT) Received: by mail-ej1-f66.google.com with SMTP id j24so438408ejc.11 for ; Wed, 28 Oct 2020 12:22:22 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id u18sm227058ejn.122.2020.10.28.12.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 12:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9SFWGQzy7DoB1AdG6aiIW/5zMdxght220eg1eHdpHZg=; b=hEw0364YT8MS769kJhqX7csgHNHKztfhxQKgq9tyxcWwwCICKY/eoA7BSHw9nk6OsK IihoUkMlqmhh5mWLgdeDMdn+S2yCjn7N8SHrtrEwBgyGcR/AcK+k1v636RQZj3U1cUIb ianRqi8IesJCC6Y3DzScHekasBhau+KnO3dOM9AKdn8bjUUzKuSmA2OQdAZTTzhC9q1i L6PSP39QJSX4U2Ap8jll4S6x01ztuZrUyLJgIq/y2V9xRiZCtwwg7SglNCIHUKVr2r+1 khXGCE5pyJ11JJ5itPWoFbRBJE9d+hJ+G7rd4/wy+z7zvDHtRvtYWU0Rm8RW21cIpDM2 w/Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=9SFWGQzy7DoB1AdG6aiIW/5zMdxght220eg1eHdpHZg=; b=kW6J9xJzwicRv/QMn0NIRfJx3JAdltJnhE6TJUtHEZdHVHJ+UPMlngmr+uQhCBSAHZ cIiksyklnPeNInl7KMctLRJLQ9d64mM9E2rcTwUDI7HCFjvc8Su2vPkc+S/ZS1WPqZYC FDZNd4P96H+Sd1wjSxs4YP862izcqAx7g9LGPXcBxtLBUQ+jLbZzqdlENU4qcEltZfRL GGL2zk8olrquDH5WsCzd1JVtRwQVD7D7w72A6N6rwlDiX76Ufbc0CGkVEY/EK9URwYe0 II2/xLPC2YJGghdFOXYdCUAwVDBIQ2y8r0DYlZ5tW/lsVsyEnmAjzkKR6kaIC6nZhPd6 AfIA== X-Gm-Message-State: AOAM5334dALfNeuw2krb/MTZ48FzXpKD1TvGeAQBwpHHJPSBd31k+oPB tCGVb0/tyA6t5gPZmDLDRWg= X-Google-Smtp-Source: ABdhPJzANS6EnXd/CrETXjKkkFmD9ebZiU5CoU49iSmrmJJqdAZ62X8y94HNczhZu9jExuwxi2lYIA== X-Received: by 2002:a17:906:22c6:: with SMTP id q6mr574072eja.433.1603912941651; Wed, 28 Oct 2020 12:22:21 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Peter Maydell , Yoshinori Sato , Markus Armbruster , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-5.2] hw/rx/rx-gdbsim: Fix memory leak Date: Wed, 28 Oct 2020 20:22:19 +0100 Message-Id: <20201028192219.833329-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) As load_device_tree() returns allocated memory, we need to free it. Cc: Yoshinori Sato Fixes: bda19d7bb56 ("hw/rx: Add RX GDB simulator") Reported-by: Coverity (CID 1432307: RESOURCE_LEAK) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- Peter mentioned this issue almost 2 months ago: https://www.mail-archive.com/qemu-devel@nongnu.org/msg737946.html Having helped Yoshinori to get his code merged, I feel the reponsibility of fixing this before the release. I know I am wrong, but since he is not responding to the review comments and we are in soft-freeze, I prefer to do the dirty laundry before we release. --- hw/rx/rx-gdbsim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rx/rx-gdbsim.c b/hw/rx/rx-gdbsim.c index 417ec0564b3..67c413f9de2 100644 --- a/hw/rx/rx-gdbsim.c +++ b/hw/rx/rx-gdbsim.c @@ -122,7 +122,7 @@ static void rx_gdbsim_init(MachineState *machine) if (dtb_filename) { ram_addr_t dtb_offset; int dtb_size; - void *dtb; + g_autofree void *dtb; =20 dtb =3D load_device_tree(dtb_filename, &dtb_size); if (dtb =3D=3D NULL) { --=20 2.26.2