From nobody Sat May 18 22:54:11 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603864486; cv=none; d=zohomail.com; s=zohoarc; b=kQmS1ahehptBa1ZF8X5AtT/EiZy/fT0ByANU5tIhAx5+fC5uRo2DzoQJOJsfH094GuQrmlh1xw7ShUteXFZgmmirD5Lv6eqMziwFjMy6WZ5ysBX/Uh5jVX8OzB3oehemw1YrXQdiv9rMrNcvjfvrhmR9UyAjIKDSrXMOJc3U7k0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603864486; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=BdMDIlOz4gLjzfPw3Gj95vqLwOL5mENay5oBbp6vQSw=; b=Uqtv6ZwoXJOagmTCaPjFtecPKIzpCF9yxiMiS/mYiMFlecrLYXbZgV3k/GIzmINQxZE/0dznG9iiofmxcZtN5RPD2QnvP9vAW5Lyo8QRwrfWar6Xxu+/4vlLYhQmPLG/wFK3Qy0t2sWfV8iHqBiwdfNRASjG254OoBwoeXKPKaQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603864486545666.0242581350745; Tue, 27 Oct 2020 22:54:46 -0700 (PDT) Received: from localhost ([::1]:47902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXeQ1-0004Wc-C9 for importer@patchew.org; Wed, 28 Oct 2020 01:54:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXeMy-0002rk-Id; Wed, 28 Oct 2020 01:51:38 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2303) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXeMw-0007hv-Gf; Wed, 28 Oct 2020 01:51:36 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CLd436Dr8zkZWS; Wed, 28 Oct 2020 13:51:31 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 13:51:17 +0800 From: Chen Qun To: , Subject: [PATCH] target/ppc/excp_helper: Add a fallthrough for fix compiler warning Date: Wed, 28 Oct 2020 13:51:07 +0800 Message-ID: <20201028055107.2170401-1-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=szxga04-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 00:18:54 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, clg@kaod.org, ganqixin@huawei.com, Euler Robot , Chen Qun , david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: ../target/ppc/excp_helper.c: In function =E2=80=98powerpc_excp=E2=80=99: ../target/ppc/excp_helper.c:529:13: warning: this statement may fall throug= h [-Wimplicit-fallthrough=3D] 529 | msr |=3D env->error_code; | ~~~~^~~~~~~~~~~~~~~~~~ ../target/ppc/excp_helper.c:530:5: note: here 530 | case POWERPC_EXCP_HDECR: /* Hypervisor decrementer exceptio= n */ | ^~~~ Add the corresponding "fall through" comment to fix it. Reported-by: Euler Robot Signed-off-by: Chen Qun --- target/ppc/excp_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index a988ba15f4..c639516399 100644 --- a/target/ppc/excp_helper.c +++ b/target/ppc/excp_helper.c @@ -527,6 +527,7 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int ex= cp_model, int excp) break; case POWERPC_EXCP_HISI: /* Hypervisor instruction storage excepti= on */ msr |=3D env->error_code; + /* fall through */ case POWERPC_EXCP_HDECR: /* Hypervisor decrementer exception = */ case POWERPC_EXCP_HDSI: /* Hypervisor data storage exception = */ case POWERPC_EXCP_HDSEG: /* Hypervisor data segment exception = */ --=20 2.23.0