From nobody Mon Feb 9 18:45:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603859325; cv=none; d=zohomail.com; s=zohoarc; b=EHfae5+AiCtebnItt2L6ONa4BTPZ9h109a9erdZP3hb26lNO6kWOr2G7ISDxUyy0hIZQErX7NdqBX82797le2vg79vP/yy2ua0pZ5gIlJDyMpSfEa2EXqXI2a3PUEjVbMNQtc8mj7v4shomUbwywmVsmgk+5kOwXeqCwP0CJaeg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603859325; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dMSFtMYQnuFS6Y9Iz0pnPDTJWxIii9DbBZtEa73JHMI=; b=lRFEmQ+Oh9auM1BMjF4JnxP2dq+NW5deHavLpt0wwco/ZxiNUGb+Yk0WJoIBEcvqj6Jf6rMl2Fb4OYOQz3U8ftu/FRtHpTBS8FhUigK0ORDTT1Tg8zwHs7irD3uADYj4mJDvi+1dacEXPp+WqGXNFl0mj2Nv6wl1PpnigGGu8go= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603859325836564.051931372964; Tue, 27 Oct 2020 21:28:45 -0700 (PDT) Received: from localhost ([::1]:34294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXd4m-0003p9-Gl for importer@patchew.org; Wed, 28 Oct 2020 00:28:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvg-0001nD-2o; Wed, 28 Oct 2020 00:19:20 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:2052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvZ-0007bW-A0; Wed, 28 Oct 2020 00:19:19 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CLb1Y3Xw2zhc6K; Wed, 28 Oct 2020 12:19:13 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 12:18:59 +0800 From: Chen Qun To: , Subject: [PATCH 4/9] linux-user/mips/cpu_loop: silence the compiler warnings Date: Wed, 28 Oct 2020 12:18:14 +0800 Message-ID: <20201028041819.2169003-5-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> References: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=kuhn.chenqun@huawei.com; helo=szxga06-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 00:19:09 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen Qun , Laurent Vivier , zhang.zhanghailiang@huawei.com, ganqixin@huawei.com, Euler Robot Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: linux-user/mips/cpu_loop.c: In function =E2=80=98cpu_loop=E2=80=99: linux-user/mips/cpu_loop.c:104:24: warning: this statement may fall through= [-Wimplicit-fallthrough=3D] 104 | if ((ret =3D get_user_ual(arg8, sp_reg + 28)) != =3D 0) { | ^ linux-user/mips/cpu_loop.c:107:17: note: here 107 | case 7: | ^~~~ linux-user/mips/cpu_loop.c:108:24: warning: this statement may fall through= [-Wimplicit-fallthrough=3D] 108 | if ((ret =3D get_user_ual(arg7, sp_reg + 24)) != =3D 0) { | ^ linux-user/mips/cpu_loop.c:111:17: note: here 111 | case 6: | ^~~~ linux-user/mips/cpu_loop.c:112:24: warning: this statement may fall through= [-Wimplicit-fallthrough=3D] 112 | if ((ret =3D get_user_ual(arg6, sp_reg + 20)) != =3D 0) { | ^ linux-user/mips/cpu_loop.c:115:17: note: here 115 | case 5: | ^~~~ Add the corresponding "fall through" comment to fix it. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Thomas Huth --- Cc: Laurent Vivier --- linux-user/mips/cpu_loop.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/linux-user/mips/cpu_loop.c b/linux-user/mips/cpu_loop.c index 553e8ca7f5..cfe7ba5c47 100644 --- a/linux-user/mips/cpu_loop.c +++ b/linux-user/mips/cpu_loop.c @@ -104,18 +104,22 @@ void cpu_loop(CPUMIPSState *env) if ((ret =3D get_user_ual(arg8, sp_reg + 28)) !=3D 0) { goto done_syscall; } + /* fall through */ case 7: if ((ret =3D get_user_ual(arg7, sp_reg + 24)) !=3D 0) { goto done_syscall; } + /* fall through */ case 6: if ((ret =3D get_user_ual(arg6, sp_reg + 20)) !=3D 0) { goto done_syscall; } + /* fall through */ case 5: if ((ret =3D get_user_ual(arg5, sp_reg + 16)) !=3D 0) { goto done_syscall; } + /* fall through */ default: break; } --=20 2.27.0