From nobody Sat May 18 15:08:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603858950; cv=none; d=zohomail.com; s=zohoarc; b=ighI4ZhFHZzC3C+OPLZsQ6By8b0gKW7dpJXK0R2zsyBW5M/0NZHRPRx+VzX2bC7/GuFOhv4Z40NBsAuIM0x4JN9uuQ0nOcCho1Gy6wzpiZr/BmY2uqAtMMaLSEUcViP8ezSsikQJUqpag+CdGNUkXhCYg3+y3a85NY5vBdBD9As= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603858950; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zgXMiOk846W/up7P9Zz5TEIQQk3yR3dTj063qyZ9GFo=; b=VnkfGJxAdYuBhUoc9Y1gQzaehpRd13ei1QyMwXJPTCLvH5vpL6BICz3xiIeWf0MVoGmu4G74A1fhMnvMMMcVCBJfCs82jOtb3m7aJWMhIgN0OGh1m73FStLay4XdgRpGl1JhWOfGaRNRwpikyVE7cFNW0xmr4uw2XnES3+zNZfA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603858950561568.2698374448652; Tue, 27 Oct 2020 21:22:30 -0700 (PDT) Received: from localhost ([::1]:44852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXcyh-0004mX-Rh for importer@patchew.org; Wed, 28 Oct 2020 00:22:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcve-0001l5-Lu; Wed, 28 Oct 2020 00:19:18 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvV-0007Zt-Jm; Wed, 28 Oct 2020 00:19:18 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CLb1R4bndzhcd3; Wed, 28 Oct 2020 12:19:07 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 12:18:55 +0800 From: Chen Qun To: , Subject: [PATCH 1/9] target/i386: silence the compiler warnings in gen_shiftd_rm_T1 Date: Wed, 28 Oct 2020 12:18:11 +0800 Message-ID: <20201028041819.2169003-2-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> References: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=kuhn.chenqun@huawei.com; helo=szxga05-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 00:16:39 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, Euler Robot , Richard Henderson , ganqixin@huawei.com, Paolo Bonzini , Chen Qun , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" The current "#ifdef TARGET_X86_64" statement affects the compiler's determination of fall through. When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: target/i386/translate.c: In function =E2=80=98gen_shiftd_rm_T1=E2=80=99: target/i386/translate.c:1773:12: warning: this statement may fall through [= -Wimplicit-fallthrough=3D] if (is_right) { ^ target/i386/translate.c:1782:5: note: here case MO_32: ^~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost --- target/i386/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index caea6f5fb1..4c353427d7 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -1777,9 +1777,9 @@ static void gen_shiftd_rm_T1(DisasContext *s, MemOp o= t, int op1, } else { tcg_gen_deposit_tl(s->T1, s->T0, s->T1, 16, 16); } - /* FALLTHRU */ -#ifdef TARGET_X86_64 + /* fall through */ case MO_32: +#ifdef TARGET_X86_64 /* Concatenate the two 32-bit values and use a 64-bit shift. */ tcg_gen_subi_tl(s->tmp0, count, 1); if (is_right) { --=20 2.27.0 From nobody Sat May 18 15:08:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603859113; cv=none; d=zohomail.com; s=zohoarc; b=PxSG35kWLIsaCozsG8OjiOO3CVQvnnGB+Zzf/ZDHAGlmhci0NC8P/gBSUFlCmQJt0eV1yxR9L12N+A8gBe3MIFmcA6Z8hXvKYW6S56bSZS4wSohPna+Jm/9Nhwqg0p68Cr7ODjwB9s8GRyttTZEYKAawy6FNtL8qnuAhhRwUyJI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603859113; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iJ19WOixeyToGv4q8r6mviloAXq0ecBl+9C25Nrpi90=; b=F8IUcPYrBtQDu9YxUVWovuH8vuP/YZGfuop26FvogXe9MLqIm2oVBIvuLMHXYMleCrxhyfyP9rpEg+6dUy5qfMa9wRHBpR0sR9Z+W7tc/u3VscryrvrZOrMNsLow4fTMi1O8QeoF7lrLeq1Qp11WqyDbvtb12tm+sOYTOH3MEs4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603859113003236.21033817571458; Tue, 27 Oct 2020 21:25:13 -0700 (PDT) Received: from localhost ([::1]:50876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXd1L-0007L2-Tm for importer@patchew.org; Wed, 28 Oct 2020 00:25:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvX-0001hy-05; Wed, 28 Oct 2020 00:19:11 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2302) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvU-0007aI-El; Wed, 28 Oct 2020 00:19:10 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CLb1R3ZNDzkXyB; Wed, 28 Oct 2020 12:19:07 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 12:18:56 +0800 From: Chen Qun To: , Subject: [PATCH 2/9] hw/intc/arm_gicv3_kvm: silence the compiler warnings Date: Wed, 28 Oct 2020 12:18:12 +0800 Message-ID: <20201028041819.2169003-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> References: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=kuhn.chenqun@huawei.com; helo=szxga04-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 00:18:54 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, qemu-arm@nongnu.org, ganqixin@huawei.com, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: hw/intc/arm_gicv3_kvm.c: In function =E2=80=98kvm_arm_gicv3_put=E2=80=99: hw/intc/arm_gicv3_kvm.c:484:13: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] kvm_gicc_access(s, ICC_AP0R_EL1(1), ncpu, ®64, true); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/intc/arm_gicv3_kvm.c:485:9: note: here default: ^~~~~~~ hw/intc/arm_gicv3_kvm.c:495:13: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] kvm_gicc_access(s, ICC_AP1R_EL1(2), ncpu, ®64, true); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/intc/arm_gicv3_kvm.c:496:9: note: here case 6: ^~~~ hw/intc/arm_gicv3_kvm.c:498:13: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] kvm_gicc_access(s, ICC_AP1R_EL1(1), ncpu, ®64, true); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/intc/arm_gicv3_kvm.c:499:9: note: here default: ^~~~~~~ hw/intc/arm_gicv3_kvm.c: In function =E2=80=98kvm_arm_gicv3_get=E2=80=99: hw/intc/arm_gicv3_kvm.c:634:37: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] c->icc_apr[GICV3_G0][2] =3D reg64; ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ hw/intc/arm_gicv3_kvm.c:635:9: note: here case 6: ^~~~ hw/intc/arm_gicv3_kvm.c:637:37: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] c->icc_apr[GICV3_G0][1] =3D reg64; ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ hw/intc/arm_gicv3_kvm.c:638:9: note: here default: ^~~~~~~ hw/intc/arm_gicv3_kvm.c:648:39: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] c->icc_apr[GICV3_G1NS][2] =3D reg64; ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ hw/intc/arm_gicv3_kvm.c:649:9: note: here case 6: ^~~~ hw/intc/arm_gicv3_kvm.c:651:39: warning: this statement may fall through [-= Wimplicit-fallthrough=3D] c->icc_apr[GICV3_G1NS][1] =3D reg64; ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ hw/intc/arm_gicv3_kvm.c:652:9: note: here default: ^~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Peter Maydell --- Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- hw/intc/arm_gicv3_kvm.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c index 187eb054e0..d040a5d1e9 100644 --- a/hw/intc/arm_gicv3_kvm.c +++ b/hw/intc/arm_gicv3_kvm.c @@ -478,9 +478,11 @@ static void kvm_arm_gicv3_put(GICv3State *s) kvm_gicc_access(s, ICC_AP0R_EL1(3), ncpu, ®64, true); reg64 =3D c->icc_apr[GICV3_G0][2]; kvm_gicc_access(s, ICC_AP0R_EL1(2), ncpu, ®64, true); + /* fall through */ case 6: reg64 =3D c->icc_apr[GICV3_G0][1]; kvm_gicc_access(s, ICC_AP0R_EL1(1), ncpu, ®64, true); + /* fall through */ default: reg64 =3D c->icc_apr[GICV3_G0][0]; kvm_gicc_access(s, ICC_AP0R_EL1(0), ncpu, ®64, true); @@ -492,9 +494,11 @@ static void kvm_arm_gicv3_put(GICv3State *s) kvm_gicc_access(s, ICC_AP1R_EL1(3), ncpu, ®64, true); reg64 =3D c->icc_apr[GICV3_G1NS][2]; kvm_gicc_access(s, ICC_AP1R_EL1(2), ncpu, ®64, true); + /* fall through */ case 6: reg64 =3D c->icc_apr[GICV3_G1NS][1]; kvm_gicc_access(s, ICC_AP1R_EL1(1), ncpu, ®64, true); + /* fall through */ default: reg64 =3D c->icc_apr[GICV3_G1NS][0]; kvm_gicc_access(s, ICC_AP1R_EL1(0), ncpu, ®64, true); @@ -631,9 +635,11 @@ static void kvm_arm_gicv3_get(GICv3State *s) c->icc_apr[GICV3_G0][3] =3D reg64; kvm_gicc_access(s, ICC_AP0R_EL1(2), ncpu, ®64, false); c->icc_apr[GICV3_G0][2] =3D reg64; + /* fall through */ case 6: kvm_gicc_access(s, ICC_AP0R_EL1(1), ncpu, ®64, false); c->icc_apr[GICV3_G0][1] =3D reg64; + /* fall through */ default: kvm_gicc_access(s, ICC_AP0R_EL1(0), ncpu, ®64, false); c->icc_apr[GICV3_G0][0] =3D reg64; @@ -645,9 +651,11 @@ static void kvm_arm_gicv3_get(GICv3State *s) c->icc_apr[GICV3_G1NS][3] =3D reg64; kvm_gicc_access(s, ICC_AP1R_EL1(2), ncpu, ®64, false); c->icc_apr[GICV3_G1NS][2] =3D reg64; + /* fall through */ case 6: kvm_gicc_access(s, ICC_AP1R_EL1(1), ncpu, ®64, false); c->icc_apr[GICV3_G1NS][1] =3D reg64; + /* fall through */ default: kvm_gicc_access(s, ICC_AP1R_EL1(0), ncpu, ®64, false); c->icc_apr[GICV3_G1NS][0] =3D reg64; --=20 2.27.0 From nobody Sat May 18 15:08:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603859230; cv=none; d=zohomail.com; s=zohoarc; b=a9JfFO0A5cQ1RYiTnVnI3xdFPJpbqfl2I2vSVbaxdi/BxVZWEN6pJh0qS1akEYZe7aaX57BxWJQiqHxYjgqLcHYPiwg72NycrLAv1WMRgxVIDDYbEYyuUCeUDZIMbOp2z8D6uIqc2y1XfYdc7vYVJLLfQYK8F7Oy9zJ135QuyFc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603859230; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HqIFeRAJld2W06/L2Oo7IR0mYWjmrWhJBntyWsWYcLY=; b=fVMv2Hy+09Tg4+YgtHzu42gcpJkFqNZG2QMDtrYim5vH1TWWRQxR8QJcyLDHWWVLzPg62M1Foc/fNa3kCJ3K0W8Bio4lweraOlhOpeKl4yOZkQva5zDg81yX7O7jQHEbv8ZWZAMmtXi30c7qslhzzEMsP4N0zdOG0exJLfyFMDc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603859230756473.5096546782528; Tue, 27 Oct 2020 21:27:10 -0700 (PDT) Received: from localhost ([::1]:58080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXd3F-0001yt-Ln for importer@patchew.org; Wed, 28 Oct 2020 00:27:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvj-0001qA-GT; Wed, 28 Oct 2020 00:19:23 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:2053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvZ-0007bX-9h; Wed, 28 Oct 2020 00:19:23 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CLb1Y3FnlzhbXc; Wed, 28 Oct 2020 12:19:13 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 12:18:58 +0800 From: Chen Qun To: , Subject: [PATCH 3/9] accel/tcg/user-exec: silence the compiler warnings Date: Wed, 28 Oct 2020 12:18:13 +0800 Message-ID: <20201028041819.2169003-4-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> References: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=kuhn.chenqun@huawei.com; helo=szxga06-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 00:19:09 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, Riku Voipio , Richard Henderson , Paolo Bonzini , ganqixin@huawei.com, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: ../accel/tcg/user-exec.c: In function =E2=80=98handle_cpu_signal=E2=80=99: ../accel/tcg/user-exec.c:169:13: warning: this statement may fall through [= -Wimplicit-fallthrough=3D] 169 | cpu_exit_tb_from_sighandler(cpu, old_set); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../accel/tcg/user-exec.c:172:9: note: here 172 | default: This exception branch fall through the 'default' branch and run the 'g_asse= rt_not_reached' statement. So we could use "fall through" instead of "NORETURN" here. Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Riku Voipio Cc: Richard Henderson Cc: Paolo Bonzini --- accel/tcg/user-exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c index 4ebe25461a..330468e990 100644 --- a/accel/tcg/user-exec.c +++ b/accel/tcg/user-exec.c @@ -167,7 +167,7 @@ static inline int handle_cpu_signal(uintptr_t pc, sigin= fo_t *info, */ clear_helper_retaddr(); cpu_exit_tb_from_sighandler(cpu, old_set); - /* NORETURN */ + /* fall through */ =20 default: g_assert_not_reached(); --=20 2.27.0 From nobody Sat May 18 15:08:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603859325; cv=none; d=zohomail.com; s=zohoarc; b=EHfae5+AiCtebnItt2L6ONa4BTPZ9h109a9erdZP3hb26lNO6kWOr2G7ISDxUyy0hIZQErX7NdqBX82797le2vg79vP/yy2ua0pZ5gIlJDyMpSfEa2EXqXI2a3PUEjVbMNQtc8mj7v4shomUbwywmVsmgk+5kOwXeqCwP0CJaeg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603859325; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dMSFtMYQnuFS6Y9Iz0pnPDTJWxIii9DbBZtEa73JHMI=; b=lRFEmQ+Oh9auM1BMjF4JnxP2dq+NW5deHavLpt0wwco/ZxiNUGb+Yk0WJoIBEcvqj6Jf6rMl2Fb4OYOQz3U8ftu/FRtHpTBS8FhUigK0ORDTT1Tg8zwHs7irD3uADYj4mJDvi+1dacEXPp+WqGXNFl0mj2Nv6wl1PpnigGGu8go= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603859325836564.051931372964; Tue, 27 Oct 2020 21:28:45 -0700 (PDT) Received: from localhost ([::1]:34294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXd4m-0003p9-Gl for importer@patchew.org; Wed, 28 Oct 2020 00:28:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvg-0001nD-2o; Wed, 28 Oct 2020 00:19:20 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:2052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvZ-0007bW-A0; Wed, 28 Oct 2020 00:19:19 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CLb1Y3Xw2zhc6K; Wed, 28 Oct 2020 12:19:13 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 12:18:59 +0800 From: Chen Qun To: , Subject: [PATCH 4/9] linux-user/mips/cpu_loop: silence the compiler warnings Date: Wed, 28 Oct 2020 12:18:14 +0800 Message-ID: <20201028041819.2169003-5-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> References: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=kuhn.chenqun@huawei.com; helo=szxga06-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 00:19:09 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen Qun , Laurent Vivier , zhang.zhanghailiang@huawei.com, ganqixin@huawei.com, Euler Robot Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: linux-user/mips/cpu_loop.c: In function =E2=80=98cpu_loop=E2=80=99: linux-user/mips/cpu_loop.c:104:24: warning: this statement may fall through= [-Wimplicit-fallthrough=3D] 104 | if ((ret =3D get_user_ual(arg8, sp_reg + 28)) != =3D 0) { | ^ linux-user/mips/cpu_loop.c:107:17: note: here 107 | case 7: | ^~~~ linux-user/mips/cpu_loop.c:108:24: warning: this statement may fall through= [-Wimplicit-fallthrough=3D] 108 | if ((ret =3D get_user_ual(arg7, sp_reg + 24)) != =3D 0) { | ^ linux-user/mips/cpu_loop.c:111:17: note: here 111 | case 6: | ^~~~ linux-user/mips/cpu_loop.c:112:24: warning: this statement may fall through= [-Wimplicit-fallthrough=3D] 112 | if ((ret =3D get_user_ual(arg6, sp_reg + 20)) != =3D 0) { | ^ linux-user/mips/cpu_loop.c:115:17: note: here 115 | case 5: | ^~~~ Add the corresponding "fall through" comment to fix it. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Thomas Huth --- Cc: Laurent Vivier --- linux-user/mips/cpu_loop.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/linux-user/mips/cpu_loop.c b/linux-user/mips/cpu_loop.c index 553e8ca7f5..cfe7ba5c47 100644 --- a/linux-user/mips/cpu_loop.c +++ b/linux-user/mips/cpu_loop.c @@ -104,18 +104,22 @@ void cpu_loop(CPUMIPSState *env) if ((ret =3D get_user_ual(arg8, sp_reg + 28)) !=3D 0) { goto done_syscall; } + /* fall through */ case 7: if ((ret =3D get_user_ual(arg7, sp_reg + 24)) !=3D 0) { goto done_syscall; } + /* fall through */ case 6: if ((ret =3D get_user_ual(arg6, sp_reg + 20)) !=3D 0) { goto done_syscall; } + /* fall through */ case 5: if ((ret =3D get_user_ual(arg5, sp_reg + 16)) !=3D 0) { goto done_syscall; } + /* fall through */ default: break; } --=20 2.27.0 From nobody Sat May 18 15:08:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603859117; cv=none; d=zohomail.com; s=zohoarc; b=G/9uA9fWrxbHnLaCvGYmeRytqb9QlsMtdW9FJ3IwJyrPYbgh+JR8Ri8vx6b4YZUZDRxbjzmW+Hqu3MIhMqrmvqD04tIM1lm4qT5eqTaxqniIT8XDqi8HjyLDhBHuhPAxItfSKqWXJ+L7yAu/VSEEZcU3SQF1gCZj09ow2CQq0v0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603859117; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DIVpescTflSDbmr//EbYlGktc9dfXTxnLNMIWciIvK4=; b=mYAuWfuwVQjOZBskwpT0q8M5DwF87K64cAHR+kRvXP82f8+ixnNN4rmXTnKz8SspIvql05lZaata7Uy/8NFNq3ZTZfv1bL/wz+JTASOZ8DbMrC7VUlP0WJt70a6B4p9sUTv59hR3EG91x8waYoqv004fIJcj9HDxwcnYwjZZVTM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160385911746527.710381468216042; Tue, 27 Oct 2020 21:25:17 -0700 (PDT) Received: from localhost ([::1]:51326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXd1Q-0007W5-CX for importer@patchew.org; Wed, 28 Oct 2020 00:25:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcve-0001lW-ON; Wed, 28 Oct 2020 00:19:18 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:2050) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvZ-0007bU-9f; Wed, 28 Oct 2020 00:19:18 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CLb1Y3Phbzhc1F; Wed, 28 Oct 2020 12:19:13 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 12:19:01 +0800 From: Chen Qun To: , Subject: [PATCH 5/9] target/sparc/translate: silence the compiler warnings Date: Wed, 28 Oct 2020 12:18:15 +0800 Message-ID: <20201028041819.2169003-6-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> References: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=kuhn.chenqun@huawei.com; helo=szxga06-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 00:19:09 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, Mark Cave-Ayland , ganqixin@huawei.com, Euler Robot , Chen Qun , Artyom Tarasenko Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: target/sparc/translate.c: In function =E2=80=98gen_st_asi=E2=80=99: target/sparc/translate.c:2320:12: warning: this statement may fall through = [-Wimplicit-fallthrough=3D] 2320 | if (!(dc->def->features & CPU_FEATURE_HYPV)) { | ^ target/sparc/translate.c:2329:5: note: here 2329 | case GET_ASI_DIRECT: | ^~~~ The "fall through" statement place is not correctly identified by the compi= ler. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Artyom Tarasenko Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Mark Cave-Ayland Cc: Artyom Tarasenko --- target/sparc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 1a4efd4ed6..a3d9aaa46b 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -2324,8 +2324,8 @@ static void gen_st_asi(DisasContext *dc, TCGv src, TC= Gv addr, } /* in OpenSPARC T1+ CPUs TWINX ASIs in store instructions * are ST_BLKINIT_ ASIs */ - /* fall through */ #endif + /* fall through */ case GET_ASI_DIRECT: gen_address_mask(dc, addr); tcg_gen_qemu_st_tl(src, addr, da.mem_idx, da.memop); --=20 2.27.0 From nobody Sat May 18 15:08:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603859156; cv=none; d=zohomail.com; s=zohoarc; b=Z7AWxdqu27kkkxZwJtI6jr0aoY2d7jC8kvUC09B+u+SGaDYCb1diC5Mea4XcDzVv+tCLl9Jy9OPv95i6OWdDN2O57AFRLl5e7+v7Q9advGHq5cuRv7XlAqH7y/wMXQMIQpnDRHZ2OPtJv9l1/4RijTGYzmZiqvO7fcXK5dio2+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603859156; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RurtqUhDhy4xXMhMhYvaU8tdTZSKTEyKLvePe+dLoJY=; b=EJsu/zb8T8twUoQtBCy/b25gSfuC+GBnzO49aJ4CeGFGfruLtmXw2jKGKTyH3trfLg4fhbFESl4MGCyA68uV/mq3Dgy4C29yru4EiaasNChrCC945/SFzuxU2E+Y2TZMhiGH8N+ASrtafhzHiO498ZwbKKZBfCOvwGf6gyhQfEc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603859156514267.00199060476484; Tue, 27 Oct 2020 21:25:56 -0700 (PDT) Received: from localhost ([::1]:53134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXd22-0008Jn-EN for importer@patchew.org; Wed, 28 Oct 2020 00:25:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvf-0001mY-AV; Wed, 28 Oct 2020 00:19:19 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:2051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvZ-0007bV-Af; Wed, 28 Oct 2020 00:19:19 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CLb1Y36GNzhbN0; Wed, 28 Oct 2020 12:19:13 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 12:19:02 +0800 From: Chen Qun To: , Subject: [PATCH 6/9] target/sparc/win_helper: silence the compiler warnings Date: Wed, 28 Oct 2020 12:18:16 +0800 Message-ID: <20201028041819.2169003-7-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> References: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=kuhn.chenqun@huawei.com; helo=szxga06-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 00:19:09 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, Mark Cave-Ayland , ganqixin@huawei.com, Euler Robot , Chen Qun , Artyom Tarasenko Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: target/sparc/win_helper.c: In function =E2=80=98get_gregset=E2=80=99: target/sparc/win_helper.c:304:9: warning: this statement may fall through [= -Wimplicit-fallthrough=3D] 304 | trace_win_helper_gregset_error(pstate); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ target/sparc/win_helper.c:306:5: note: here 306 | case 0: | ^~~~ Add the corresponding "fall through" comment to fix it. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Artyom Tarasenko --- Cc: Mark Cave-Ayland Cc: Artyom Tarasenko --- target/sparc/win_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/sparc/win_helper.c b/target/sparc/win_helper.c index 8290a21142..32eacc05e6 100644 --- a/target/sparc/win_helper.c +++ b/target/sparc/win_helper.c @@ -303,6 +303,7 @@ static inline uint64_t *get_gregset(CPUSPARCState *env,= uint32_t pstate) default: trace_win_helper_gregset_error(pstate); /* pass through to normal set of global registers */ + /* fall through */ case 0: return env->bgregs; case PS_AG: --=20 2.27.0 From nobody Sat May 18 15:08:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603859417; cv=none; d=zohomail.com; s=zohoarc; b=gOQtQ1eH26nitk93S5LCJ5xxy2x02sjIYY6+V42jkQZCdDEVP+nok9rPWzIJyiuiKvruoG0t48Q35xZYC0xo1j0ZJBQpNt1iUcsqopSHPPyjY327uHPPCZy2MuCQIUTJAEJ4ZAiBuKEGnEdZBqPFvVTibPoKznWZSd1qJ0b+wDs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603859417; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NXecwnpuq0Vbf8Wnz8pS/6hCh9qHSruysS6TymnjpaU=; b=UlcaYBN9DlhxEhMH/sHb8raMIjHffYYNgWzwEsRVfNyAq12dlTh7qFVenexA6HLRmkNFV0a588KSaKC276TiMHdaoscSfDMoJxcUsxxmPmKeKbS5Hu5XJl2NVjz8637IC5oAtXmZpIMHTXge+iABBANxbS+1vk1JsAb1rUJp7pg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603859417534860.0706967987968; Tue, 27 Oct 2020 21:30:17 -0700 (PDT) Received: from localhost ([::1]:38306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXd6G-0005WW-CZ for importer@patchew.org; Wed, 28 Oct 2020 00:30:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvi-0001pF-Fs; Wed, 28 Oct 2020 00:19:22 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:2113) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcve-0007cx-If; Wed, 28 Oct 2020 00:19:22 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CLb1f0d8mz6y74; Wed, 28 Oct 2020 12:19:18 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 12:19:04 +0800 From: Chen Qun To: , Subject: [PATCH 7/9] ppc: silence the compiler warnings Date: Wed, 28 Oct 2020 12:18:17 +0800 Message-ID: <20201028041819.2169003-8-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> References: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=kuhn.chenqun@huawei.com; helo=szxga07-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 00:19:14 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen Qun , David Gibson , zhang.zhanghailiang@huawei.com, ganqixin@huawei.com, Euler Robot Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: hw/ppc/ppc.c: In function =E2=80=98ppc6xx_set_irq=E2=80=99: hw/ppc/ppc.c:118:16: warning: this statement may fall through [-Wimplicit-f= allthrough=3D] 118 | if (level) { | ^ hw/ppc/ppc.c:123:9: note: here 123 | case PPC6xx_INPUT_INT: | ^~~~ Add the corresponding "fall through" comment to fix it. Reported-by: Euler Robot Signed-off-by: Chen Qun Acked-by: David Gibson --- Cc: David Gibson --- hw/ppc/ppc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 4a11fb1640..f9eb8f21b4 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int l= evel) } else { cpu_ppc_tb_stop(env); } + /* fall through */ case PPC6xx_INPUT_INT: /* Level sensitive - active high */ LOG_IRQ("%s: set the external IRQ state to %d\n", --=20 2.27.0 From nobody Sat May 18 15:08:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603859359; cv=none; d=zohomail.com; s=zohoarc; b=SjtsDNad5hUMn+trpQ1+j5zViIiQ8NZCU2UAIav1ZdcdTa60XZbc1LxkRK/Kf/SMdsr4dHFzVM86WtpWsZdxFztMGLtet9rkfDvsRyHDxEpMLsGgNJEVyNkLC7JNqvPuF1yoiB9qGJsyynZ067rirZ2BBuXBPqiG14AgNT8ldaQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603859359; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=J9Kc+0vrWGrmxV7n5gZwDZfs7/SFWEzyGBagnKwbygk=; b=Oo8NxsgBUivJyrH3g2TTPIexe+rqBmY7wkh22NIU02TfbQz1g5rka0hPjOPbK3JD4v4CVwbHC1287LnD5InYTz7gfRjOoUBCFAuektrmWGNfiog99iYsGG6y6VrqRji27LgZ+H1FQzG3LB+WEyrgm1trkJgiwLVyATWz2U4hbGI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603859359621587.6347773095758; Tue, 27 Oct 2020 21:29:19 -0700 (PDT) Received: from localhost ([::1]:36422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXd5J-0004jF-8f for importer@patchew.org; Wed, 28 Oct 2020 00:29:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvk-0001rm-FE; Wed, 28 Oct 2020 00:19:24 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:2112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcve-0007cw-Ke; Wed, 28 Oct 2020 00:19:24 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CLb1f0MMlz6y4W; Wed, 28 Oct 2020 12:19:18 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 12:19:06 +0800 From: Chen Qun To: , Subject: [PATCH 8/9] target/ppc: silence the compiler warnings Date: Wed, 28 Oct 2020 12:18:18 +0800 Message-ID: <20201028041819.2169003-9-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> References: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=kuhn.chenqun@huawei.com; helo=szxga07-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 00:19:14 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen Qun , David Gibson , zhang.zhanghailiang@huawei.com, ganqixin@huawei.com, Euler Robot Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: target/ppc/mmu_helper.c: In function =E2=80=98dump_mmu=E2=80=99: target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through [= -Wimplicit-fallthrough=3D] 1351 | if (ppc64_v3_radix(env_archcpu(env))) { | ^ target/ppc/mmu_helper.c:1358:5: note: here 1358 | default: | ^~~~~~~ Add the corresponding "fall through" comment to fix it. Reported-by: Euler Robot Signed-off-by: Chen Qun Acked-by: David Gibson --- Cc: David Gibson --- target/ppc/mmu_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index 8972714775..51749b62df 100644 --- a/target/ppc/mmu_helper.c +++ b/target/ppc/mmu_helper.c @@ -1355,6 +1355,7 @@ void dump_mmu(CPUPPCState *env) break; } #endif + /* fall through */ default: qemu_log_mask(LOG_UNIMP, "%s: unimplemented\n", __func__); } --=20 2.27.0 From nobody Sat May 18 15:08:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603859274; cv=none; d=zohomail.com; s=zohoarc; b=D3JsEAAQPF7WeNCXIJj0OZ/DY/Wv1/iqhY+Z0NNWbgnA3Hhtc1RzOZRVoRSKVsRXkrxL7zHrEEifDLgvd5pU1j1JEV9ikHdh8vATxS8v1UnajVZg9j15N7Xdb0ahBJ3EXASui70Hh0OaWGnHDj3T5jeqd1CAqs5LTNlIVkuGe8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603859274; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+2PftT8e3diDgmdfMWxuyEitbJw1FfbN49WGABtKXBo=; b=mWB5dLD/pPgfZWxuW289Vxwmv2WhEebamj0ImqH77JwppVwLVSMoEtCkCgjLdjJI9HqGSn61t2r5fo/6cQ+Z1IzPzVZ8cMf/WVneIFObh6Q0yS+i71COYodzkH7KSgP+hgR/0MV0KFHRXOm9BFGouDfd52A4bctAMvNfQTwdXvE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603859274506396.12970946040207; Tue, 27 Oct 2020 21:27:54 -0700 (PDT) Received: from localhost ([::1]:60224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXd3x-0002py-FE for importer@patchew.org; Wed, 28 Oct 2020 00:27:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcvh-0001oY-Jm; Wed, 28 Oct 2020 00:19:22 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:2114) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXcve-0007cy-J6; Wed, 28 Oct 2020 00:19:21 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CLb1f0VN1z6y5r; Wed, 28 Oct 2020 12:19:18 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 28 Oct 2020 12:19:07 +0800 From: Chen Qun To: , Subject: [PATCH 9/9] hw/timer/renesas_tmr: silence the compiler warnings Date: Wed, 28 Oct 2020 12:18:19 +0800 Message-ID: <20201028041819.2169003-10-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> References: <20201028041819.2169003-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=kuhn.chenqun@huawei.com; helo=szxga07-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 00:19:14 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, Yoshinori Sato , Magnus Damm , ganqixin@huawei.com, Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: ../hw/timer/renesas_tmr.c: In function =E2=80=98tmr_read=E2=80=99: ../hw/timer/renesas_tmr.c:221:19: warning: this statement may fall through = [-Wimplicit-fallthrough=3D] 221 | } else if (ch =3D=3D 0) {i | ^ ../hw/timer/renesas_tmr.c:224:5: note: here 224 | case A_TCORB: | ^~~~ Add the corresponding "fall through" comment to fix it. Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Yoshinori Sato Cc: Magnus Damm --- hw/timer/renesas_tmr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/timer/renesas_tmr.c b/hw/timer/renesas_tmr.c index 446f2eacdd..e03a8155b2 100644 --- a/hw/timer/renesas_tmr.c +++ b/hw/timer/renesas_tmr.c @@ -221,6 +221,7 @@ static uint64_t tmr_read(void *opaque, hwaddr addr, uns= igned size) } else if (ch =3D=3D 0) { return concat_reg(tmr->tcora); } + /* fall through */ case A_TCORB: if (size =3D=3D 1) { return tmr->tcorb[ch]; --=20 2.27.0