From nobody Mon Feb 9 16:02:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603820294; cv=none; d=zohomail.com; s=zohoarc; b=lLpxWU6SUd0lALlyw+t5tH0U8ZSue9JRWdXQD++L03Fm6icFV6UE1VtslQNqMKVFA/mGHtEvQ/z6yYKSXWVQDa7tp1+XD0ZtortFevEjAirltfdTQztSFNd5/J3gfEOy0Lrk+9cjCOUvdWFdfUegwFuL2jPnHTAE82IWHqEomVw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603820294; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=c5RYeMON6vIyuF1dEBXjN+Z/Dnv69ZgDcVyLlBVyl/0=; b=iduhhEA/YZm1IWI5F3MIZC/kaPNK6EuBQIhfdwH25RAAh7yqcaaozvjUQMG3sTqEq4csHxhS2TPeSFufZzSm2oryec3gkknL06y2oHEbQAcKGwpZqTX3BbTohiOtet14s3tE7e6E72JmvFp8p0q2v2Je1qaePuAlEttpGc/2vbs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603820294724227.55061869266535; Tue, 27 Oct 2020 10:38:14 -0700 (PDT) Received: from localhost ([::1]:45772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXSvF-0007v0-Tc for importer@patchew.org; Tue, 27 Oct 2020 13:38:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXStX-0005xb-DQ for qemu-devel@nongnu.org; Tue, 27 Oct 2020 13:36:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55714) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kXStV-0003IC-1k for qemu-devel@nongnu.org; Tue, 27 Oct 2020 13:36:27 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-ygixxskVNPCglBhjqsEGlw-1; Tue, 27 Oct 2020 13:36:21 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 564AC107466C; Tue, 27 Oct 2020 17:36:16 +0000 (UTC) Received: from localhost (ovpn-115-166.ams2.redhat.com [10.36.115.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id D4A9C19C4F; Tue, 27 Oct 2020 17:36:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603820184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c5RYeMON6vIyuF1dEBXjN+Z/Dnv69ZgDcVyLlBVyl/0=; b=a6f7kFkjVWVOvYPYU5nG1qfAkDbLWpVpHDVVN2yAMF60MMX6773xtgI+h6zjgj0wraWZNQ xQiCecnspT480AnAMzYOetQ1hyxsIO78ljHhB9iSngNFXhRKN5gy6OE9b9rnzqQb62BZCp +xfm0v2EOjErluHkpQM8aFyZ23BvCNw= X-MC-Unique: ygixxskVNPCglBhjqsEGlw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 03/12] block/export: make vhost-user-blk config space little-endian Date: Tue, 27 Oct 2020 17:35:19 +0000 Message-Id: <20201027173528.213464-4-stefanha@redhat.com> In-Reply-To: <20201027173528.213464-1-stefanha@redhat.com> References: <20201027173528.213464-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 01:06:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Kevin Wolf , Thomas Huth , qemu-block@nongnu.org, "Michael S. Tsirkin" , Coiby Xu , Raphael Norwitz , Stefan Hajnoczi , Paolo Bonzini , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" VIRTIO 1.0 devices have little-endian configuration space. The vhost-user-blk-server.c code already uses little-endian for virtqueue processing but not for the configuration space fields. Fix this so the vhost-user-blk export works on big-endian hosts. Signed-off-by: Stefan Hajnoczi --- block/export/vhost-user-blk-server.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user= -blk-server.c index 41f4933d6e..33cc0818b8 100644 --- a/block/export/vhost-user-blk-server.c +++ b/block/export/vhost-user-blk-server.c @@ -264,7 +264,6 @@ static uint64_t vu_blk_get_protocol_features(VuDev *dev) static int vu_blk_get_config(VuDev *vu_dev, uint8_t *config, uint32_t len) { - /* TODO blkcfg must be little-endian for VIRTIO 1.0 */ VuServer *server =3D container_of(vu_dev, VuServer, vu_dev); VuBlkExport *vexp =3D container_of(server, VuBlkExport, vu_server); memcpy(config, &vexp->blkcfg, len); @@ -343,18 +342,18 @@ vu_blk_initialize_config(BlockDriverState *bs, uint32_t blk_size, uint16_t num_queues) { - config->capacity =3D bdrv_getlength(bs) >> BDRV_SECTOR_BITS; - config->blk_size =3D blk_size; - config->size_max =3D 0; - config->seg_max =3D 128 - 2; - config->min_io_size =3D 1; - config->opt_io_size =3D 1; - config->num_queues =3D num_queues; - config->max_discard_sectors =3D 32768; - config->max_discard_seg =3D 1; - config->discard_sector_alignment =3D config->blk_size >> 9; - config->max_write_zeroes_sectors =3D 32768; - config->max_write_zeroes_seg =3D 1; + config->capacity =3D cpu_to_le64(bdrv_getlength(bs) >> BDRV_SECTOR_BIT= S); + config->blk_size =3D cpu_to_le32(blk_size); + config->size_max =3D cpu_to_le32(0); + config->seg_max =3D cpu_to_le32(128 - 2); + config->min_io_size =3D cpu_to_le16(1); + config->opt_io_size =3D cpu_to_le32(1); + config->num_queues =3D cpu_to_le16(num_queues); + config->max_discard_sectors =3D cpu_to_le32(32768); + config->max_discard_seg =3D cpu_to_le32(1); + config->discard_sector_alignment =3D cpu_to_le32(config->blk_size >> 9= ); + config->max_write_zeroes_sectors =3D cpu_to_le32(32768); + config->max_write_zeroes_seg =3D cpu_to_le32(1); } =20 static void vu_blk_exp_request_shutdown(BlockExport *exp) --=20 2.26.2