From nobody Sun Feb 8 07:24:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603811390; cv=none; d=zohomail.com; s=zohoarc; b=IJxekE/LtJr9eXq2DZ/SpCL7wk1nN1SHUPvS5RQaYoWyX0UilYr8IhQjI4EtxxSHSJv3KMqX/NoPPQs8KYDWsRHbTjgjs64oE1ZuOcCSyczMJtJhfgiPdQuV/2uPmNuEud7Dj2v7S+pvs9gvuqZCV2hQc7BY3rtNDlo5MDO5g+I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603811390; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jduw8ZOUndNkfMNXerU9fkPHDFjkVREPAS0BU5dvN6g=; b=aZNP0sUpFHsCOsqOxhWdx4RFwIsYXa3Hw9q+OQkUrAKPkKYCoAwjsp9/FMT67+neyDnDVdt0g7g1+H6ZkEE+G4OiFUcf+Hw9izfoFBqewRv2XoHZ9PVHi2KFl10bDaJ4R2vWvfDhs1Rlhd4GQUL+jq3vGaCMDI/YEeBltN05jeo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160381139064465.7620505641512; Tue, 27 Oct 2020 08:09:50 -0700 (PDT) Received: from localhost ([::1]:55404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXQbd-000739-G6 for importer@patchew.org; Tue, 27 Oct 2020 11:09:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXQBx-0008Uu-Hb for qemu-devel@nongnu.org; Tue, 27 Oct 2020 10:43:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kXQBv-0002ri-RS for qemu-devel@nongnu.org; Tue, 27 Oct 2020 10:43:17 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-83-K8SWLjMcPeOwQgDvPem3nQ-1; Tue, 27 Oct 2020 10:43:11 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B00421009E57; Tue, 27 Oct 2020 14:43:08 +0000 (UTC) Received: from scv.redhat.com (ovpn-118-238.rdu2.redhat.com [10.10.118.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 38BD060C11; Tue, 27 Oct 2020 14:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603809795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jduw8ZOUndNkfMNXerU9fkPHDFjkVREPAS0BU5dvN6g=; b=ebpEZtP0vmD26QkO5U2lnd9IwBRbLL5yVRD2exKbMyONbaXulPp2eaRDsG8BB6w+kXfYF0 7+kIPuTta2fB/ovsvKB+gx+vLq6iIJKaIthIWmqhLrUJVu3ikh1kp/ltT1vM4TZX6hL7fs ZTMG05l00UnaQzePATZ9GQ0nmkoxlVE= X-MC-Unique: K8SWLjMcPeOwQgDvPem3nQ-1 From: John Snow To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 3/3] ide: clear SRST after SRST finishes Date: Tue, 27 Oct 2020 10:42:55 -0400 Message-Id: <20201027144255.77478-4-jsnow@redhat.com> In-Reply-To: <20201027144255.77478-1-jsnow@redhat.com> References: <20201027144255.77478-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 01:06:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , John Snow , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The SRST protocol states that after diagnostics are complete and the status is posted, we should clear the SRST bit if it should so happen to be set. The reset method itself should handle this, but just in case -- make our intention explicit here. Signed-off-by: John Snow Tested-by: Mark Cave-Ayland Message-id: 20201020200242.1497705-4-jsnow@redhat.com Signed-off-by: John Snow --- hw/ide/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index 98cea7ad4507..e85821637c96 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2268,6 +2268,8 @@ static void ide_bus_perform_srst(void *opaque) s =3D &bus->ifs[i]; ide_perform_srst(s); } + + bus->cmd &=3D ~IDE_CTRL_RESET; } =20 void ide_ctrl_write(void *opaque, uint32_t addr, uint32_t val) --=20 2.26.2