From nobody Sat Feb 7 08:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603810665; cv=none; d=zohomail.com; s=zohoarc; b=ayzMAXAK4lIzOIIockBEfs7ZfGvDx+Ll2XLqPSq8kAe0lQBmOp7Jz97LitYRGymT8csPlVEZL9JVeDiQy772tGQsUewSxs7x8Y52uqSMWXyd0pC2lMjGLi/WxlVyfF/RCFLisJcSAkJZ4tL+rO8q6N5oAdN/33uFrorwgKGol6g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603810665; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5FSc1MpqNQ7nejVknozCZQV90G41DiBQOssJdbLFVt0=; b=m5Rkt2EGf2vhBdP6wsI0Jq9G8kcPSmE0RmS2vZXfYlLEbu+SXNZBO5Uk7v9Ctl328rn46U2YM3B/1MeoOUoSY3oTrXNXpcx7BRdEEeRkrEV9m8vS6R8QsbauzE5qFuHLzi71peuIvjca4yx34DumXFbA8U0jpyM1rawNmtvBaEo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16038106658401005.6815364967839; Tue, 27 Oct 2020 07:57:45 -0700 (PDT) Received: from localhost ([::1]:49948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXQPx-0000Xv-06 for importer@patchew.org; Tue, 27 Oct 2020 10:57:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXQBq-0008Es-U9 for qemu-devel@nongnu.org; Tue, 27 Oct 2020 10:43:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kXQBo-0002qN-7Q for qemu-devel@nongnu.org; Tue, 27 Oct 2020 10:43:10 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-383-EVqd5puMNzmvix68J4WdMA-1; Tue, 27 Oct 2020 10:43:05 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1EA6C18CB750; Tue, 27 Oct 2020 14:43:04 +0000 (UTC) Received: from scv.redhat.com (ovpn-118-238.rdu2.redhat.com [10.10.118.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8303B60FC2; Tue, 27 Oct 2020 14:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603809787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5FSc1MpqNQ7nejVknozCZQV90G41DiBQOssJdbLFVt0=; b=QS8ph7xsN9Q6rD+Y2KSdrm1CoDHpIH2b+nuEvveDMqN46Yzm9c6laKnc695oZHLMs5idbI +sEJkLdlXQvBaEEyl8qofVRCl5KTaX+CYCLJQdDV6VNsXDIw5x7qclIY5aSeHd12sWYymR 9wgtb90NPLVT6glfAosYWVj0Mrjx9nw= X-MC-Unique: EVqd5puMNzmvix68J4WdMA-1 From: John Snow To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 2/3] ide: perform SRST as early as possible Date: Tue, 27 Oct 2020 10:42:54 -0400 Message-Id: <20201027144255.77478-3-jsnow@redhat.com> In-Reply-To: <20201027144255.77478-1-jsnow@redhat.com> References: <20201027144255.77478-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 01:06:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , John Snow , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We don't need to wait for the falling edge. We can set BSY as soon as possible and begin immediately resetting the drive. Devices don't appear to need to take any specific action on the falling edge. Signed-off-by: John Snow Tested-by: Mark Cave-Ayland Message-id: 20201020200242.1497705-3-jsnow@redhat.com Signed-off-by: John Snow --- hw/ide/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 84e887d4269d..98cea7ad4507 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2280,9 +2280,7 @@ void ide_ctrl_write(void *opaque, uint32_t addr, uint= 32_t val) =20 /* Device0 and Device1 each have their own control register, * but QEMU models it as just one register in the controller. */ - if ((bus->cmd & IDE_CTRL_RESET) && - !(val & IDE_CTRL_RESET)) { - /* SRST triggers on falling edge */ + if (!(bus->cmd & IDE_CTRL_RESET) && (val & IDE_CTRL_RESET)) { for (i =3D 0; i < 2; i++) { s =3D &bus->ifs[i]; s->status |=3D BUSY_STAT; --=20 2.26.2