From nobody Sun Feb 8 14:41:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603810976; cv=none; d=zohomail.com; s=zohoarc; b=XRNwlXnSNIzI9OjLPIhYfGQXctqvhZEem0IYB13dBGA/MHhcGQKoJxFmuISsjUPRWFd/TDnXYB/C0aAcWUGKB85DHAU8sEfvcQq/fohZk2eNMO8S0wuUiLbq4qc1eIBXhMGGDF0fnWj139mIVlMRbIARPWeiXecNqEqSklUBmKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603810976; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HkqYK+FCZzyQCXMt1HxLj/oggA8spTm9ZlsR34yCK/M=; b=BMS9w5pxoipDdHg639U6XMiGquZOOGbcvhyabZr3e8CmVy32SQ1p8EBAo9KsVJyWLhuPkmnx2g0Axy8Rl6bLKOkGMhiv13uMkEX4aPGuYQwFyxGa3mlah8TdWS9yILsJ/FO1QxrD11E/Zz0dcmiYt1D7GTX1BKjt2PujbijQEjQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603810976384776.5974771737193; Tue, 27 Oct 2020 08:02:56 -0700 (PDT) Received: from localhost ([::1]:33642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXQUw-0005iA-Vz for importer@patchew.org; Tue, 27 Oct 2020 11:02:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXQBs-0008Hg-2H for qemu-devel@nongnu.org; Tue, 27 Oct 2020 10:43:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kXQBo-0002qV-H3 for qemu-devel@nongnu.org; Tue, 27 Oct 2020 10:43:11 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-ZF8b3BRjNx-jgcE1N9cUIw-1; Tue, 27 Oct 2020 10:43:01 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 60316101963A; Tue, 27 Oct 2020 14:43:00 +0000 (UTC) Received: from scv.redhat.com (ovpn-118-238.rdu2.redhat.com [10.10.118.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C51560C47; Tue, 27 Oct 2020 14:42:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603809787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HkqYK+FCZzyQCXMt1HxLj/oggA8spTm9ZlsR34yCK/M=; b=dDZW0EbSSgk4qiU2dGG/JtCwSTVmIo1ij/JAAjl6y4qJRzo5vP4c2UoXQblVhy34nnmU2F CHnYofWhlWnY+X2IkvGjmYXsziZDqQ/dLsz8xbWxXMEz6SEbVklrIIn2yL1jLfQ1UtAazI topNvVv1TC8waNi06Wq2JtGlYShGMNw= X-MC-Unique: ZF8b3BRjNx-jgcE1N9cUIw-1 From: John Snow To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 1/3] ide: run diagnostic after SRST Date: Tue, 27 Oct 2020 10:42:53 -0400 Message-Id: <20201027144255.77478-2-jsnow@redhat.com> In-Reply-To: <20201027144255.77478-1-jsnow@redhat.com> References: <20201027144255.77478-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 01:06:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , John Snow , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Software reset (SRST) should cause the diagnostic command to be run. Make an explicit call to that routine. Reported-by: Mark Cave-Ayland Tested-by: Mark Cave-Ayland Signed-off-by: John Snow Message-id: 20201020200242.1497705-2-jsnow@redhat.com Fixes: 55adb3c45620c31f29978f209e2a44a08d34e2da Fixes: https://bugs.launchpad.net/bugs/1900155 Tested-by: Mark Cave-Ayland Signed-off-by: John Snow --- hw/ide/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 693b352d5ebe..84e887d4269d 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2254,10 +2254,8 @@ static void ide_perform_srst(IDEState *s) /* Cancel PIO callback, reset registers/signature, etc */ ide_reset(s); =20 - if (s->drive_kind =3D=3D IDE_CD) { - /* ATAPI drives do not set READY or SEEK */ - s->status =3D 0x00; - } + /* perform diagnostic */ + cmd_exec_dev_diagnostic(s, WIN_DIAGNOSE); } =20 static void ide_bus_perform_srst(void *opaque) --=20 2.26.2