From nobody Mon Nov 17 12:06:33 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1603809309; cv=none; d=zohomail.com; s=zohoarc; b=RkeITSTgk1swHsSMo6PQzqwu/SxYfckb92HAS6apj7EKFJGywpJxi/VaBCO0Ru2PaQcW9WwQAShhfbYHpFvpRJt+uyYG09D7DCW1KAp30BNFtqj1HnES4Glyj+bVXu+KN3M0oBQZnVYI/DHZ4MFZKhBS3McOtH5G96aScaObqlU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603809309; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UW1Wk3cL10Vf+xXHlcWUtM/b2jUjamezKHSQX3eRAuU=; b=T8Yvp98fFWa8AMM5YCB4I4xDM+HtMuknxaDIe62enyrM2s6sNvM9IUjDurZ+F3UeDpYoFkROarVjx3u269yXbc5m1aixVkHZ90sti8qbwC9l0yAE1e3ROxXyCEJEm7dqs3IRb1LiwaVbjZzp8/zdakN4EutHWYXAO6hvWamARnA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603809308196313.0101018028105; Tue, 27 Oct 2020 07:35:08 -0700 (PDT) Received: from localhost ([::1]:38478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXQ43-0005PY-5f for importer@patchew.org; Tue, 27 Oct 2020 10:35:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXPnO-0001lI-2a; Tue, 27 Oct 2020 10:17:54 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:48703 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXPnJ-0007Yr-TE; Tue, 27 Oct 2020 10:17:53 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4CLDLb4DxVz9sfF; Wed, 28 Oct 2020 01:17:41 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1603808263; bh=TOdw5JH2Yz5af80pQkkTcNDiEbkuiIiC/9BWjLk3qOU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A7ipTlfTzudn13/6pLBs38SPVwVnjTy6puHhwHrGvulQyYvkibMyOUS+MrCWnlvZR 3RBG5/WgAz3zqLLPdiCORy6GpolItuOwi1rYaFK253FelyPatJgQGFCgCwiSdpa5+d wg2OgSfAz/LpNc2XeruIf0J+/TlhN3tZUAw051lQ= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 02/18] ppc/spapr: re-assert IRQs during event-scan if there are pending Date: Wed, 28 Oct 2020 01:17:19 +1100 Message-Id: <20201027141735.728821-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201027141735.728821-1-david@gibson.dropbear.id.au> References: <20201027141735.728821-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Laurent Vivier If we hotplug a CPU during the first second of the kernel boot, the IRQ can be sent to the kernel while the RTAS event handler is not installed. The event is queued, but the kernel doesn't collect it and ignores the new CPU. As the code relies on edge-triggered IRQ, we can re-assert it during the event-scan RTAS call if there are still pending events (as it is already done in check-exception). Signed-off-by: Laurent Vivier Message-Id: <20201015210318.117386-1-lvivier@redhat.com> Reviewed-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr_events.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 1069d0197b..1add53547e 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -1000,10 +1000,22 @@ static void event_scan(PowerPCCPU *cpu, SpaprMachin= eState *spapr, target_ulong args, uint32_t nret, target_ulong rets) { + int i; if (nargs !=3D 4 || nret !=3D 1) { rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR); return; } + + for (i =3D 0; i < EVENT_CLASS_MAX; i++) { + if (rtas_event_log_contains(EVENT_CLASS_MASK(i))) { + const SpaprEventSource *source =3D + spapr_event_sources_get_source(spapr->event_sources, i); + + g_assert(source->enabled); + qemu_irq_pulse(spapr_qirq(spapr, source->irq)); + } + } + rtas_st(rets, 0, RTAS_OUT_NO_ERRORS_FOUND); } =20 --=20 2.26.2