From nobody Mon Nov 17 11:49:41 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603806997; cv=none; d=zohomail.com; s=zohoarc; b=lAbl4Xaf6HD4AH4AlrC+sGTNUBpF506KiIm2UTaHAhcJYHIuSnGxhhVGTcPPtbAYj7Stirb/7nSLP08pQv8EZJn5KM9o3Bk/skmA/7yNG0lcxCdpV2A11+FV6THNgxC2NECVpoJmYSr7qODP/g5ja9/HSc3rkCcCuilbb2zj6WA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603806997; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=H+ZJ92q9c8sHM7tIK104/2szOIvYpUY13gacvPM2KaM=; b=DcHEjRt61uh2jPwlzFBKPpcG//WxZZegJyjQnZXOaF8tmrxazf+2BdMTzU0bhbpfZV9B2pJpyY9X8yXDVm3hBsgXq62cZ0UnR+Kq8w7vgh5EOO7gpzDCmMaKw7AJ5hTwpuSc9tBAFubRzeOajgKcEK095s+3HocWqKD9zqcZThY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 160380699791179.76657520393178; Tue, 27 Oct 2020 06:56:37 -0700 (PDT) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-313-I1KpUGbGNtW6XHht-U26Cg-1; Tue, 27 Oct 2020 09:56:35 -0400 Received: by mail-ej1-f72.google.com with SMTP id p19so903315ejy.11 for ; Tue, 27 Oct 2020 06:56:34 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id r1sm1094650eju.40.2020.10.27.06.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 06:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603806997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H+ZJ92q9c8sHM7tIK104/2szOIvYpUY13gacvPM2KaM=; b=fqJEUmTF5RetYB704NJwudyDuCaZ8KYaHVwABTtMog4kowKqfqDcWHcLFCP7FbwQ+mKn6r 6wrfRQQ/M03z1Jbilq2yq4QbPGgzPEkfGBJqGFrmjx5dX4f7Ql/cY6rykcwUZiVWjKP5CY faDKqmxOdv1CyTx1UHPu5xhv6AsNRQY= X-MC-Unique: I1KpUGbGNtW6XHht-U26Cg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H+ZJ92q9c8sHM7tIK104/2szOIvYpUY13gacvPM2KaM=; b=GbipfKcqRShqwAb9PZxADLx1oLNxAY0i3/33HiVK3K6vBYM9kHWEZ71OG8nAd5JAZb GoN2zZt9Su71VyhrQtKz/mT+oZiewe2WtM6WS6tQ6q2zcuv8gyRR3l4QxwA3OeBSQ4KR Xypmc36VBNtxSUjaREdFMSeqqSCborWJUrbG5nUAqACoIoUdtHT92i2WgieWILFlPnec kIAqvzuKmFLJDgBTUDv6obBgrWfl4ao5PZM/kId4DoRqiMiJXNa/xLAp7PQN2qrn2f/3 /5zYzd+aYyoyXjVenaPKWwOGULRA/q8umZuaraGbRPnAGhgg2WjbrBfCrXNmUQ7JOBvp 2c0w== X-Gm-Message-State: AOAM531r5elZzokI7XU6Buu7E9wQ7lZOKd8TufOVgKMBelmnvW4VfcGv GVw54WD6hrMawrMHa/GxXYzq/AFbBz+C9peRDDcKQWUdWs8FaTuXEylrTZYLWWLXqOtRIGZUL2z 5HZdoxxw5GaZpmg== X-Received: by 2002:a50:b023:: with SMTP id i32mr2279425edd.377.1603806993702; Tue, 27 Oct 2020 06:56:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBHskYR7MdFyujMfh7jJZtXEwL7Sga5wgF1zNKHEZcbBSH0cK23mgenucEppfPBb6oRjPsaw== X-Received: by 2002:a50:b023:: with SMTP id i32mr2279410edd.377.1603806993546; Tue, 27 Oct 2020 06:56:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Klaus Jensen , qemu-block@nongnu.org, Fam Zheng , Keith Busch , Eric Auger , Stefan Hajnoczi , Kevin Wolf , Max Reitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 08/25] block/nvme: Simplify device reset Date: Tue, 27 Oct 2020 14:55:30 +0100 Message-Id: <20201027135547.374946-9-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201027135547.374946-1-philmd@redhat.com> References: <20201027135547.374946-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Avoid multiple endianess conversion by using device endianess. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nvme.c b/block/nvme.c index e95d59d3126..be14350f959 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -755,7 +755,7 @@ static int nvme_init(BlockDriverState *bs, const char *= device, int namespace, timeout_ms =3D MIN(500 * NVME_CAP_TO(cap), 30000); =20 /* Reset device to get a clean state. */ - regs->cc =3D cpu_to_le32(le32_to_cpu(regs->cc) & 0xFE); + regs->cc &=3D const_le32(0xFE); /* Wait for CSTS.RDY =3D 0. */ deadline =3D qemu_clock_get_ns(QEMU_CLOCK_REALTIME) + timeout_ms * SCA= LE_MS; while (NVME_CSTS_RDY(le32_to_cpu(regs->csts))) { --=20 2.26.2