From nobody Mon Nov 17 11:49:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603806975; cv=none; d=zohomail.com; s=zohoarc; b=dRLgLyOQdRpDLWhiRCo/RLv9eOU7fI+LlDevItvAOq58M4IsECMFpu/p90sLE/TMh+V3TPug9eWS8Fl6nQwLg55l1u8xKI3piEs1XPiDaeIoFNQpanm8WwWyejL1vvP6wg2L5N6Sf0KRYdNV1h0quOQrljooDgq8N5iMxGH9lFY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603806975; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=a7fBCIQ/1BkfqoPLON3TqQaNLgboMKILqf/ROXQloYA=; b=nOrZY7pvjawLXHrYC5YkB3gzEI2UJnCgtR2ASfSEAX5rY5qNhCSqhZ1OFvCCR/9RWXm1uvOxN5YN7L+feUDxGcdMVU/rgNWq74GNR3mXjEEr5zCicKiWCobf9HU6xZAnO7c5YPcwpmiQt4Gxzq+gzYHj+gXveRDmpsfLrsIWlms= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1603806975615356.36367215799714; Tue, 27 Oct 2020 06:56:15 -0700 (PDT) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-91-zKzgM_JpNOWxDgC4rRbwtQ-1; Tue, 27 Oct 2020 09:56:13 -0400 Received: by mail-ed1-f70.google.com with SMTP id dm20so735852edb.2 for ; Tue, 27 Oct 2020 06:56:13 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id qq10sm1126501ejb.31.2020.10.27.06.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 06:56:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603806974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a7fBCIQ/1BkfqoPLON3TqQaNLgboMKILqf/ROXQloYA=; b=azP4WQBQb7vn2ZCM7JH8c6JzBP59m30R+HfFcdbkR3eF6WwsFnKwQVh35kXfEulBzPTyUR 51YfVdVHdO3wquWYwh6rz2gYwqhgMcHB9cYF/tFRyYdAXhVBtQgS9iIdZcBdFv9aVHn5fb JcONT4ZfmrHMX+ls1M59AvyQEpXMwaA= X-MC-Unique: zKzgM_JpNOWxDgC4rRbwtQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a7fBCIQ/1BkfqoPLON3TqQaNLgboMKILqf/ROXQloYA=; b=WeZBp3WqUUVzn2hmZckFZ158kElJbEXK0KAkoGo2rSwLU432qVYLjGE6kg6mhnO7Eg oJDMhVHbRbz2v0bLivDIkFdRm2h4DkKoUKryTXPKE6tjGRCcENXM1zsBFFpNDsMNMtoQ dC7dBHVqtmXapM1qpHOewSyB+rCxp3x7Kx/aVHiZvNEawMQmVDPGyYB/ArbgSQDjekzP AyxW4r5yhGMq6XmqCx+PpIzOffwNiPghHuoL4AEdOI21oQuPY8ztBe9X4/htIla0VQqn KsSti96ua5h0+wNXsCuvckd+DPy6H05Ze7Fc3OTYTXXqSWZJUfSXC5GDn50eolXWihtM ++VA== X-Gm-Message-State: AOAM530SzyaNPNQ6FDptTbAswfMDtUgK08ugA0IGuSF9RDs87P4Tk9JR 58jOSnV4KdKNSdsAB98+xfxd27TI+95Efje+M0R7RjtsiV5WuLI3YTD7p0TUwOEvgdWn7ZbxyvO qyhTV94JkfpJCcw== X-Received: by 2002:a17:906:1804:: with SMTP id v4mr2593846eje.201.1603806972000; Tue, 27 Oct 2020 06:56:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZgJ0Yhl0g+IaSqdnBKcqOlMQmDkgQVickfFpeBkLGikNBaXcoPQA5gqttgXSEN0pAPYoMDg== X-Received: by 2002:a17:906:1804:: with SMTP id v4mr2593829eje.201.1603806971794; Tue, 27 Oct 2020 06:56:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Klaus Jensen , qemu-block@nongnu.org, Fam Zheng , Keith Busch , Eric Auger , Stefan Hajnoczi , Kevin Wolf , Max Reitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 04/25] block/nvme: Trace controller capabilities Date: Tue, 27 Oct 2020 14:55:26 +0100 Message-Id: <20201027135547.374946-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201027135547.374946-1-philmd@redhat.com> References: <20201027135547.374946-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Controllers have different capabilities and report them in the CAP register. We are particularly interested by the page size limits. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Eric Auger --- block/nvme.c | 13 +++++++++++++ block/trace-events | 2 ++ 2 files changed, 15 insertions(+) diff --git a/block/nvme.c b/block/nvme.c index 6f1d7f9b2a1..361b5772b7a 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -727,6 +727,19 @@ static int nvme_init(BlockDriverState *bs, const char = *device, int namespace, * Initialization". */ =20 cap =3D le64_to_cpu(regs->cap); + trace_nvme_controller_capability_raw(cap); + trace_nvme_controller_capability("Maximum Queue Entries Supported", + 1 + NVME_CAP_MQES(cap)); + trace_nvme_controller_capability("Contiguous Queues Required", + NVME_CAP_CQR(cap)); + trace_nvme_controller_capability("Doorbell Stride", + 2 << (2 + NVME_CAP_DSTRD(cap))); + trace_nvme_controller_capability("Subsystem Reset Supported", + NVME_CAP_NSSRS(cap)); + trace_nvme_controller_capability("Memory Page Size Minimum", + 1 << (12 + NVME_CAP_MPSMIN(cap))); + trace_nvme_controller_capability("Memory Page Size Maximum", + 1 << (12 + NVME_CAP_MPSMAX(cap))); if (!NVME_CAP_CSS(cap)) { error_setg(errp, "Device doesn't support NVMe command set"); ret =3D -EINVAL; diff --git a/block/trace-events b/block/trace-events index 0955c85c783..b90b07b15fa 100644 --- a/block/trace-events +++ b/block/trace-events @@ -134,6 +134,8 @@ qed_aio_write_postfill(void *s, void *acb, uint64_t sta= rt, size_t len, uint64_t qed_aio_write_main(void *s, void *acb, int ret, uint64_t offset, size_t le= n) "s %p acb %p ret %d offset %"PRIu64" len %zu" =20 # nvme.c +nvme_controller_capability_raw(uint64_t value) "0x%08"PRIx64 +nvme_controller_capability(const char *desc, uint64_t value) "%s: %"PRIu64 nvme_kick(void *s, int queue) "s %p queue %d" nvme_dma_flush_queue_wait(void *s) "s %p" nvme_error(int cmd_specific, int sq_head, int sqid, int cid, int status) "= cmd_specific %d sq_head %d sqid %d cid %d status 0x%x" --=20 2.26.2