From nobody Mon Nov 17 12:05:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603807059; cv=none; d=zohomail.com; s=zohoarc; b=X5yROZtL23VRonhIw3bSvHfeUg4jqdr0vNVEUlvnR6MzgRBYlOkjkAYW0mKS94qJNuv2B1+VDVWCLJgLplt7gmi2d42AfXkdMPwpk+spxcKclsBs9vz+CmzfLjBNEVRUwzpwabScIiwtRXoNNQ4Jwceke6cA9ySqvR90UiYE+Jw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603807059; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=RJk75AmI6iZBxAGRnOfhQsAkiS0PriXiInR+pfpFLCQ=; b=S4GGe8ExYbRQ+JOXCOw2ITT+0l5ZKQVrSemHLs92Qnwy6zyBsscmV9Bw8J0S3Tt8v0KSy49SwysOKpuL7zRxC4H7mC6/kKQDnKA3vMJbG3+ygpiR7eGedCed2U1gXlH2DbPkfVu1JMil5G8S44DkoxPjKgt+g97xqflwAm7W1Cc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1603807059156281.05513099905784; Tue, 27 Oct 2020 06:57:39 -0700 (PDT) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-552-8TSp-SebMTmx_GjZkbIZOw-1; Tue, 27 Oct 2020 09:57:34 -0400 Received: by mail-ed1-f70.google.com with SMTP id t7so742517edt.0 for ; Tue, 27 Oct 2020 06:57:34 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id e14sm1103100ejc.15.2020.10.27.06.57.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 06:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603807058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RJk75AmI6iZBxAGRnOfhQsAkiS0PriXiInR+pfpFLCQ=; b=dAE2WmgylwyDnz/3lgpkCa/KzOUI1kEj6tmujjQurgj2gMlnsiKn1AnI0kazOeXpYzXXAu S5Fa67tLxo85j0U8WvYJEGBlBCB0opnW505JVftN6SNBnFOHuh2VgVyEDBKJ+h6lNjOYW/ HklZvfJYj/roHWyumbsdtqvXowL7BK0= X-MC-Unique: 8TSp-SebMTmx_GjZkbIZOw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RJk75AmI6iZBxAGRnOfhQsAkiS0PriXiInR+pfpFLCQ=; b=uPGTooNske28DnsCS26Ap0wE0EfwKmcGYcbcWvU5LZ+QYnnCqNHmNru93rx7gVMg6Q lGUKbak+1Ie2n8fbiffabSS0/wig1eY97KZfawV816glHUongQFDTsnHZ+o77z4WZH0O IhNRTgYi4DQWc3mSX3e9t9MSewxc6RGhynfaoE0ufT0nH9tilTFaEZ+MHHEdG1unnb/x I1b0cai4DM67br6Ay4/Z7/lgi22LKYp9A9Zu68irStQJd6M5lOAlA1QEApe+QNxJlk73 Lw/ALvMq3Vmx8vhF2gXC9TWbk8DV0e3PNRXlx+xWb0fut/CDyYXi7c37sQV51uFE0T/U EdgQ== X-Gm-Message-State: AOAM533RdIRioeuiv/28ZdPxMLRVKqRckxUtmbCvRoMjRguOj6YbDLDE raBIUQxIkex/uLUAoWPRBRqNXyn46kGvnlLzHc7ry5E7oX288OCucPTjEAxqgalqbhiwrwzCEzq fWVL4RvYAy3YhRA== X-Received: by 2002:a17:906:3a1a:: with SMTP id z26mr2434450eje.519.1603807053072; Tue, 27 Oct 2020 06:57:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCxeBepJouLr4JjCDbEz6RpAdJu0yoFSQNNFmO/lwqirty5H/MDmwxCDZyYzpFfwQLbILEhA== X-Received: by 2002:a17:906:3a1a:: with SMTP id z26mr2434430eje.519.1603807052865; Tue, 27 Oct 2020 06:57:32 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Klaus Jensen , qemu-block@nongnu.org, Fam Zheng , Keith Busch , Eric Auger , Stefan Hajnoczi , Kevin Wolf , Max Reitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 19/25] block/nvme: Set request_alignment at initialization Date: Tue, 27 Oct 2020 14:55:41 +0100 Message-Id: <20201027135547.374946-20-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201027135547.374946-1-philmd@redhat.com> References: <20201027135547.374946-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Commit bdd6a90a9e5 ("block: Add VFIO based NVMe driver") sets the request_alignment in nvme_refresh_limits(). For consistency, also set it during initialization. Reported-by: Stefan Hajnoczi Reviewed-by: Eric Auger Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- block/nvme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nvme.c b/block/nvme.c index a0871fc2a81..682946ad840 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -759,6 +759,7 @@ static int nvme_init(BlockDriverState *bs, const char *= device, int namespace, s->page_size =3D MAX(4096, 1 << NVME_CAP_MPSMIN(cap)); s->doorbell_scale =3D (4 << NVME_CAP_DSTRD(cap)) / sizeof(uint32_t); bs->bl.opt_mem_alignment =3D s->page_size; + bs->bl.request_alignment =3D s->page_size; timeout_ms =3D MIN(500 * NVME_CAP_TO(cap), 30000); =20 /* Reset device to get a clean state. */ --=20 2.26.2