From nobody Fri May 9 21:58:09 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=linaro.org
ARC-Seal: i=1; a=rsa-sha256; t=1603803907; cv=none;
d=zohomail.com; s=zohoarc;
b=lfoZTdOrRaNVa997SdCcW5quaS03iBJnOej+5b1Rceq0EkQVsr0qTdSU2x7+GT/0Ip3haMOlpoR1kJuAclSRH5WQuSuMvochHF2lk6GRa8PZghU6DNlRy/XqbmgG8yF/N9mNs5QJL0uS5xxZ/2ISd3YvwbeYQOInHqm3ZU+t/ic=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1603803907;
h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
bh=31oB8adlz3FHMBAML1Jxi6tZhh8Z+m5TwWywAmM/pII=;
b=CTAr7Y7N2isx5by0IlogJCvZNKfH4csL04bX5nW9oll8ZPXBuraWwKGt6OhsPT7FbTcGfroW1Tnfz6Tp5i0nrDyyjwG4z7DHu1KC+iUh1dqlSUG/+puDdaUlEbEVFKTumJ3ebofMpP2g9U2BA1tNIr9DFZBTO32Aj7EJOQnYn7U=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<peter.maydell@linaro.org> (p=none dis=none)
header.from=<peter.maydell@linaro.org>
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 160380390739355.955006483554826;
Tue, 27 Oct 2020 06:05:07 -0700 (PDT)
Received: from localhost ([::1]:57196 helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces+importer=patchew.org@nongnu.org>)
id 1kXOew-0004i4-8u
for importer@patchew.org; Tue, 27 Oct 2020 09:05:06 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:52308)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)
id 1kXNPs-0001pm-Fj
for qemu-devel@nongnu.org; Tue, 27 Oct 2020 07:45:28 -0400
Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:44420)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)
id 1kXNPp-0004gY-AX
for qemu-devel@nongnu.org; Tue, 27 Oct 2020 07:45:27 -0400
Received: by mail-wr1-x42b.google.com with SMTP id t9so1499825wrq.11
for <qemu-devel@nongnu.org>; Tue, 27 Oct 2020 04:45:21 -0700 (PDT)
Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148])
by smtp.gmail.com with ESMTPSA id 32sm1712203wro.31.2020.10.27.04.45.19
for <qemu-devel@nongnu.org>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 27 Oct 2020 04:45:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
h=from:to:subject:date:message-id:in-reply-to:references:mime-version
:content-transfer-encoding;
bh=31oB8adlz3FHMBAML1Jxi6tZhh8Z+m5TwWywAmM/pII=;
b=O5qZs9Jon0x+5AL/5i2pTHgEiaQdyjo4cO2m/S5AzL3bMFR3wlxr4/62bDj1UgK1g8
NJNA0zweuazvEVucJxrFLm8nuo2+3y2IPb9pA+z0pfRSlH57McyPx5/RvYOOvYLqaHbF
j1Tz+d5CNYx96eah8RtuSK7sT2sGWlKtyT6tI7G246LhbvtVktKV9+0rV0UUl9MlZoei
+niuoem4LtPMC7z9gntuvOD3oLL4pqq+U5wYzaOmEOJgyoYxbpJQrwiismMRNyS4BK3v
C6uOO1Glbz1hjGmk4/+PTl91axveFYlsoz5d0duy4+Brcx891OqaTXjMOeEUj2NucGEO
KEFg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=31oB8adlz3FHMBAML1Jxi6tZhh8Z+m5TwWywAmM/pII=;
b=teCg8dMdAUEhHTXQzKf/r0Wune1m8xJgre+hSt9pSwzyjGgCHKdfq7DqpmQ0q3djZJ
JQ58G2KXTxIqNwyscd8WPq6Y5FfW367EbuoKBHi3b0VUoh8vVxd9QHrnjET/QmCxPGK5
Nc/m+zVTWItYyEhJ3+U5DO1LumiMzfNOjUo3/X7Kd0CPVY5EkjeL5jfal3QZEFEKDhBL
oeSj/tQtkNfqXapVxEBOmjHbmwH+2ZZd3KQMJ/54S6+2I9pFEu0qtNs6BcdOgd0Ldkmm
8hLkbqh9cQd5Ccjrwr1PmKr51Dq3x4o107+ZtCV2Wv8who8aN41+et877BR89L6CxIUP
hNUQ==
X-Gm-Message-State: AOAM530TJIepYDFPpPEkGGjUnGDs6hHqwIeaIguJgrlC1NEEtVyerrCJ
uP1fHGNN4lV4Ls4j/h50MnFmU4+5whO+eg==
X-Google-Smtp-Source:
ABdhPJwM8O3i6VDD+69crFqAziMFR++dwgevBZgvQqD0hjNtU6wv/918KT0QL03Rxd4o6p+gnKFdEw==
X-Received: by 2002:a05:6000:1051:: with SMTP id
c17mr2278494wrx.290.1603799120368;
Tue, 27 Oct 2020 04:45:20 -0700 (PDT)
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 32/48] hw/core/clock: trace clock values in Hz instead of ns
Date: Tue, 27 Oct 2020 11:44:22 +0000
Message-Id: <20201027114438.17662-33-peter.maydell@linaro.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20201027114438.17662-1-peter.maydell@linaro.org>
References: <20201027114438.17662-1-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=2a00:1450:4864:20::42b;
envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42b.google.com
X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache.
That's all we know.
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+importer=patchew.org@nongnu.org>
X-ZohoMail-DKIM: pass (identity @linaro.org)
From: Luc Michel <luc@lmichel.fr>
The nanosecond unit greatly limits the dynamic range we can display in
clock value traces, for values in the order of 1GHz and more. The
internal representation can go way beyond this value and it is quite
common for today's clocks to be within those ranges.
For example, a frequency between 500MHz+ and 1GHz will be displayed as
1ns. Beyond 1GHz, it will show up as 0ns.
Replace nanosecond periods traces with frequencies in the Hz unit
to have more dynamic range in the trace output.
Reviewed-by: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org>
Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
Signed-off-by: Luc Michel <luc@lmichel.fr>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/core/clock.c | 6 +++---
hw/core/trace-events | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/core/clock.c b/hw/core/clock.c
index f866717a835..8c6af223e7c 100644
--- a/hw/core/clock.c
+++ b/hw/core/clock.c
@@ -54,8 +54,8 @@ bool clock_set(Clock *clk, uint64_t period)
if (clk->period =3D=3D period) {
return false;
}
- trace_clock_set(CLOCK_PATH(clk), CLOCK_PERIOD_TO_NS(clk->period),
- CLOCK_PERIOD_TO_NS(period));
+ trace_clock_set(CLOCK_PATH(clk), CLOCK_PERIOD_TO_HZ(clk->period),
+ CLOCK_PERIOD_TO_HZ(period));
clk->period =3D period;
=20
return true;
@@ -69,7 +69,7 @@ static void clock_propagate_period(Clock *clk, bool call_=
callbacks)
if (child->period !=3D clk->period) {
child->period =3D clk->period;
trace_clock_update(CLOCK_PATH(child), CLOCK_PATH(clk),
- CLOCK_PERIOD_TO_NS(clk->period),
+ CLOCK_PERIOD_TO_HZ(clk->period),
call_callbacks);
if (call_callbacks && child->callback) {
child->callback(child->callback_opaque);
diff --git a/hw/core/trace-events b/hw/core/trace-events
index 1ac60ede6b7..360ddeb2c87 100644
--- a/hw/core/trace-events
+++ b/hw/core/trace-events
@@ -31,6 +31,6 @@ resettable_transitional_function(void *obj, const char *o=
bjtype) "obj=3D%p(%s)"
# clock.c
clock_set_source(const char *clk, const char *src) "'%s', src=3D'%s'"
clock_disconnect(const char *clk) "'%s'"
-clock_set(const char *clk, uint64_t old, uint64_t new) "'%s', ns=3D%"PRIu6=
4"->%"PRIu64
+clock_set(const char *clk, uint64_t old, uint64_t new) "'%s', %"PRIu64"Hz-=
>%"PRIu64"Hz"
clock_propagate(const char *clk) "'%s'"
-clock_update(const char *clk, const char *src, uint64_t val, int cb) "'%s'=
, src=3D'%s', ns=3D%"PRIu64", cb=3D%d"
+clock_update(const char *clk, const char *src, uint64_t hz, int cb) "'%s',=
src=3D'%s', val=3D%"PRIu64"Hz cb=3D%d"
--=20
2.20.1