From nobody Mon Nov 17 12:06:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.52 as permitted sender) client-ip=209.85.218.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1603755001; cv=none; d=zohomail.com; s=zohoarc; b=VlGYxd8/5n8HcoaSd0LyOMHLqyPp/vpERO/UyR6uSVELtw/MEz3UbaA6tnbf9xA7wmUCm/EHNlt/i4QW7EQ1Yd6Na29cq07sZsgDhR6KVlL6Y1YLIkSY91QOcBAigARza5gjxkesFNgX8CRwyj6JzIQT2k89oOr+d0SszuXkW1A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603755001; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2OjR/wUfEEBugepvrkgMq+mri256jiLmUAh08vclpww=; b=AfH3Wq3hy+hw8uTQKaoU7ckJF9rTpwJ+Nu62d8skjbXNOFxVwAmHNflaHlseqfBGP+LskQTrD///qHpHeuZwRKPtATAMh2UudP85sM/PgjUKSgLQwk9xvKmPfQCmosYnlM2/9snTTk6H/pGtopoaYnBsO1umDAilDZLhE5HpZtw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by mx.zohomail.com with SMTPS id 1603755001734604.6224134995019; Mon, 26 Oct 2020 16:30:01 -0700 (PDT) Received: by mail-ej1-f52.google.com with SMTP id dt13so16456999ejb.12 for ; Mon, 26 Oct 2020 16:30:01 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id n22sm5969260edr.11.2020.10.26.16.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2OjR/wUfEEBugepvrkgMq+mri256jiLmUAh08vclpww=; b=bIW7W8qmw+I/hh1l0NKHHt88h0LKNmG1nWv8jbPk/BlX3yFIeVyaP3k6FnhhM59K1w 7BbUMwMCNQUrFlXYfq+G72Rtx69AFlvfv6W3P8mGhfP9UwzOhAxN/kyHDIjGrkTbtFfc caun4lWhNcXLOUmZZd7f4+q5BrrlOj3y7VvE2yLoAvSxkqnb3p9WweQPkOWQjcUudwaN 9DaCeMV8Qj6cNGqKGemQwTopNAH88ez5OUnWWyR3BZCqZbnKEx6qrH91AVSB+GyqlV7V amVKbCIcgqGWvrVX0/3HGTCM81MVLwmhO9hCRhnXvKkabcJ+4gGtrbiQ5dp725luku38 LIww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2OjR/wUfEEBugepvrkgMq+mri256jiLmUAh08vclpww=; b=dYpB0BbcbgDjoLTYvrr+lwZKVDPz6XyLw9WTQPpJc/9PtBiuY5quc6RuYlgFmRv68O 5Y4/bFw6gK3WZnetPBIOD8hkIhetKhRj2bZXgx74gaqJrQoehmwIdFxwcGtI8jyxGD01 rNwI1qaBg5+MMPeKr1u/BiWROwJKnXBiv0u61M01liTok3zkupCBTd2UxZGmemCS6Kvw JewQAMwFL0ETKcOUL6+JEQ+H3EJ5TvPMqw9N+yEBuec/pyf5Mzx00O3X9Tv81TMHmCDy LLKg7AiwSwghCw9Z4eoGSZFPm9xY3T+b3BCJbrli8EFQu8tgJWHwGBH5ENYrY4fL79qT pzIQ== X-Gm-Message-State: AOAM531GrOgmuAxeI2nxnIMcds8kdeRHFnVCTcXtePot7nvkqvZA/8kQ zWt62ivEBwbddYTn2Q8rnio= X-Google-Smtp-Source: ABdhPJxnD0XrshsqAsbiYsU2dfkGZR59jox1zaGn5TYf4myTczI15Kve6jh4wb/d/oTcBm9nte9C/w== X-Received: by 2002:a17:906:1107:: with SMTP id h7mr17808599eja.481.1603754999863; Mon, 26 Oct 2020 16:29:59 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Magnus Damm , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 4/8] hw/timer/sh_timer: Remove superfluous "break" statements Date: Tue, 27 Oct 2020 00:29:31 +0100 Message-Id: <20201026232935.92777-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Thomas Huth hw_error() is marked as QEMU_NORETURN, so the "break" statements after this function are just dead code. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20201020153935.54315-4-thuth@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/timer/sh_timer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c index 934daaa7dcc..58af1a1edbd 100644 --- a/hw/timer/sh_timer.c +++ b/hw/timer/sh_timer.c @@ -125,7 +125,6 @@ static void sh_timer_write(void *opaque, hwaddr offset, /* fallthrough */ default: hw_error("sh_timer_write: Reserved TPSC value\n"); - break; } switch ((value & TIMER_TCR_CKEG) >> 3) { case 0: @@ -139,7 +138,6 @@ static void sh_timer_write(void *opaque, hwaddr offset, /* fallthrough */ default: hw_error("sh_timer_write: Reserved CKEG value\n"); - break; } switch ((value & TIMER_TCR_ICPE) >> 6) { case 0: @@ -152,7 +150,6 @@ static void sh_timer_write(void *opaque, hwaddr offset, /* fallthrough */ default: hw_error("sh_timer_write: Reserved ICPE value\n"); - break; } if ((value & TIMER_TCR_UNF) =3D=3D 0) { s->int_level =3D 0; --=20 2.26.2