From nobody Mon Nov 17 12:06:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.51 as permitted sender) client-ip=209.85.208.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1603754998; cv=none; d=zohomail.com; s=zohoarc; b=aWJA36CGUNljloOe+ScRtgrxpA0RbzKT6C6LCB8c+ctBPwSP3fHS/THJzt7qEXyOGwmW9WCEnjK85op4E5SVnrBptMh/TzR2MiDnTeUmWcLCIHP3yA+tUA/wjcU3IYUPSHNq+d830ykwy3SregJjUKqGh/xB1Zw6xnpglOGhBTE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603754998; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IPy8xSDiS043tJ1qMib/hHCsnldOT9q1j5PDtKMfWf4=; b=CLh0yonQ4blPg1mWOB91Eitt4RCng7bKNrkVTf/Z2jQJXAFUp27Ul3BUC3bp9YCiG15N93fFUFbQ7Tl0oPJtSDWDpssLRGUQ3MNO2VtX3uLN19N6O9eC7Dfj9tcR4twYlA/XBycUEhsDBgqDEJ7NZHJRDP5muxwx/b9ftxoGj44= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by mx.zohomail.com with SMTPS id 1603754998295677.3431553888178; Mon, 26 Oct 2020 16:29:58 -0700 (PDT) Received: by mail-ed1-f51.google.com with SMTP id w23so11568899edl.0 for ; Mon, 26 Oct 2020 16:29:55 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id c5sm6003342edx.58.2020.10.26.16.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IPy8xSDiS043tJ1qMib/hHCsnldOT9q1j5PDtKMfWf4=; b=YjyO25H7f/AlgxZ5zvDpiKR2vl+Tonxb/fesN+Lhox3oU9iYqtExyvrDPb6UElb54C uB59d+9aximzMS544QjdpUTAE64RGtjMpV/NYUueabxJIAoMZxqpzdooiOewpcnOOPXZ EX9tNd7sBh8BbwVXO+JhAkwqO+n8AraQcnCblpA1NpAYrZTYTv23j0YBXcpYJWmPgI8v S2sS/oNWJYWhpBj6hrZ/uapW95jxDblqkBJeNrHmus9kRmQ9htoBsup/srj9mtmgywko w3hmwR2VymCvtLLMDE5eTlvwxHpXI4COkuLUQ8CHzYH5foaZ4faBHwtmJa/Y7t44lBuy 1eXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=IPy8xSDiS043tJ1qMib/hHCsnldOT9q1j5PDtKMfWf4=; b=ElY4mZtQQMl3utP9Qc72QuZHQsHCZ/hIzLbN3puQ8U3GntyURNximiJ0AvLqbauUX3 O8gOwI7B8NyM5/UqsoXutd2F1yTTlOuK6QuQ5fKDdPG/6aLsx/yBWRN2piPRaAQAh5YO XM9CYcN/bHyfqsYmEUQLpSw80wPtCUj2Egd1htNhMVjKptgS5YGeFwwHaTFMTNGFaz+T vYGWaDU00W7BUzW//48u9zMrFctlOym9oSWM5EmHI1Yke3Sjk9q/wwqgPeOHINm7pmE0 jAiTGub3CXghStIianoxlbDuFoKHGutEhIykykbAWWk4boG1m605NzhxUP+oXMm+dF4Q au1A== X-Gm-Message-State: AOAM5333Dwt9MnF+E/6D/KghImDTkD8UGSuXeDCar87upbg+LOl3OBgO eG+xa4N3IGnS03HuKMhfy9k= X-Google-Smtp-Source: ABdhPJy8qozl7+BUfvRi4eLSqZDBe8zDdIX521ymCx58GbHStOofoFONEal03BDnOO4StkVlSAGnGQ== X-Received: by 2002:aa7:c5c4:: with SMTP id h4mr18733480eds.379.1603754994405; Mon, 26 Oct 2020 16:29:54 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Magnus Damm , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 3/8] hw/timer/sh_timer: Silence warnings about missing fallthrough statements Date: Tue, 27 Oct 2020 00:29:30 +0100 Message-Id: <20201026232935.92777-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Thomas Huth When compiling with -Werror=3Dimplicit-fallthrough, gcc complains about missing fallthrough annotations in this file. Looking at the code, the fallthrough is very likely intended here, so add some comments to silence the compiler warnings. Fixes: cd1a3f6840e ("Stand-alone TMU emulation code") Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20201020153935.54315-3-thuth@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/timer/sh_timer.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c index b09e30f9388..934daaa7dcc 100644 --- a/hw/timer/sh_timer.c +++ b/hw/timer/sh_timer.c @@ -122,6 +122,7 @@ static void sh_timer_write(void *opaque, hwaddr offset, if (s->feat & TIMER_FEAT_EXTCLK) { break; } + /* fallthrough */ default: hw_error("sh_timer_write: Reserved TPSC value\n"); break; @@ -135,6 +136,7 @@ static void sh_timer_write(void *opaque, hwaddr offset, if (s->feat & TIMER_FEAT_EXTCLK) { break; } + /* fallthrough */ default: hw_error("sh_timer_write: Reserved CKEG value\n"); break; @@ -147,6 +149,7 @@ static void sh_timer_write(void *opaque, hwaddr offset, if (s->feat & TIMER_FEAT_CAPT) { break; } + /* fallthrough */ default: hw_error("sh_timer_write: Reserved ICPE value\n"); break; @@ -180,6 +183,7 @@ static void sh_timer_write(void *opaque, hwaddr offset, s->tcpr =3D value; break; } + /* fallthrough */ default: hw_error("sh_timer_write: Bad offset %x\n", (int)offset); } --=20 2.26.2