From nobody Mon Nov 17 09:50:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.52 as permitted sender) client-ip=209.85.208.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1603754984; cv=none; d=zohomail.com; s=zohoarc; b=iGDKN9U7+Pxvu5Ohx7Tb3CV0Iu6a0NpAHPTr1yQwFzyJDXGjHd44GMymy9m2T5qg6nz0fcUfcXoplzwJHM5ltbRh6SW+AUe2L+x2ePc+qW3+LQxSnga4W3akWgyAXqeFxZAx7eglaAm4c2KVL6qIn2Kpr/3ohKB4rc5kYojz8Oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603754984; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=urFZaeBJKljDRkArj0HwcSmE633p30vmh0ol15kKy9E=; b=ZZ0VzD8PQzU+X0NyJrgEWkFjmICfmlvYDYc5/vPPRcWFPgYnqJtCsl8gVz+j3h2mMb8LSy4D1LhrKhLRkP71ftblHlGaoacYtHf4Q8edpX0eI1GP+Y7dbKXaFq6HrP5+D7SCoqlnUZKMHtJ1LUUVPsvYOJX6OMBZIY8ZFXoRsJk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by mx.zohomail.com with SMTPS id 1603754984929595.0090942462076; Mon, 26 Oct 2020 16:29:44 -0700 (PDT) Received: by mail-ed1-f52.google.com with SMTP id a6so10204696edx.6 for ; Mon, 26 Oct 2020 16:29:44 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id q9sm6642658ejr.115.2020.10.26.16.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=urFZaeBJKljDRkArj0HwcSmE633p30vmh0ol15kKy9E=; b=mVYUIsqdMcm4JDdnKtYSmnLzcAatosaK79SgzMhDRVgep3RogvqG66cjf7Di22kUx7 3AUNiiBuOydJFnaw+x5n1VQiTGJ32VVvPisI33ZIcYpe7X+wq31hDkq1vy085SjkNcfR YZv11qr0l7v6cy92OQIXnMb1djFD9FdBTio0TK5HXRGQZSYyQ2M8yoJOp8vf8lNtTVgl ChQD/cxtkMsfABLbpos/mjLJPcrqUTPi9ZlRHdgNdEKGVj+aL7WMZmHfoq6KK8IbU3mN FkSj0mgirpXChqywlclbK0v2kHq5qsWsgEHqMWW25pP6HFaqUlZ2vxPK9SdosdvHqt42 jHXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=urFZaeBJKljDRkArj0HwcSmE633p30vmh0ol15kKy9E=; b=OD/YPS+WddJLxM1nQawMijUYSD6DZ95HBKUxhWXZ6eU7lhymn0RIF8rUPeP3Gj7NYE J9CClEGNb6aoOMhOjftZJh8vXf3SuZuys9kzib1/DJ/+NO7mUEK7fCUDkMaPOrJ4hrbY OpdJlZtpqefXT9/CqiHXMykQSL8YD99t8edSmYzDkGU6ncJh7QXz12I/cYHA058HETQ+ t4HPh6TB0bJm+7yI2gbBmrvYxAd5TpsiTpAnyzucqumTFIJiv8bLSYCPLcIC4eO40cIv tNLA8BMPos7//FT3yoJWifR5ZQ9sXUav2GCXIJSy+RkjCohlWxS+F4nrcwXtYPfZANZI Y6Vg== X-Gm-Message-State: AOAM5332iAs3Yn2B5xXiQHqHKex8NAKsooqSDZwc6yZLw/60D2RiFOQl AmI75+uaVb9R4Oe5MhSf0xk= X-Google-Smtp-Source: ABdhPJyW6/eo7p9K54Vvl072fTYA7gHXy/vs5BzmhhMbmYP+49xJ2JAnHIR8KWBBcHl58hCCZDKbHg== X-Received: by 2002:a05:6402:a45:: with SMTP id bt5mr2669162edb.101.1603754983034; Mon, 26 Oct 2020 16:29:43 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Magnus Damm , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 1/8] elf: Add EM_RX definition Date: Tue, 27 Oct 2020 00:29:28 +0100 Message-Id: <20201026232935.92777-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Yoshinori Sato RX's ELF machine is not defined in "elf.h". Added it. Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Message-Id: <20200814131438.28406-1-ysato@users.sourceforge.jp> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/elf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/elf.h b/include/elf.h index c117a4d1ab0..d9bf4a95d86 100644 --- a/include/elf.h +++ b/include/elf.h @@ -172,6 +172,8 @@ typedef struct mips_elf_abiflags_v0 { =20 #define EM_UNICORE32 110 /* UniCore32 */ =20 +#define EM_RX 173 /* Renesas RX family */ + #define EM_RISCV 243 /* RISC-V */ =20 #define EM_NANOMIPS 249 /* Wave Computing nanoMIPS */ --=20 2.26.2 From nobody Mon Nov 17 09:50:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.54 as permitted sender) client-ip=209.85.208.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1603754990; cv=none; d=zohomail.com; s=zohoarc; b=FD+7DwrK+UcvmjrYlKp/qfG90MUh++/t81SxZMLoMYwsy99DQ+IU5gEQ/taN+4e1ab6h4WalqCdUtC75WB7fXpjPBbHrGgkNq+xVa/Lj119T0TRr3BVNXAMw8LLoBC4lCElPrEO8PDmtv0frDV65nx4bDnf6GE9aJlwnCyYZsIc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603754990; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2kYJylSUVap5cHs18MspyX6fw/+yTmDa3KK/zRKs/IU=; b=Ih8pX0xH7zwXNDPemOlB+eJEF0cq6qz64Z1XsTdKSrKXizyzBi2eUx60vDRoPzZMhms1Ll6f2AQnD3OnS3Eop5Lbm17tJVqj+OYlQD2Xm1ZktqHU96rxxp0OcxIb4T25/sD4qUvoRH0NzhwndO9Gc3zU6sdZtiS4SXHVQyq2+r8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by mx.zohomail.com with SMTPS id 1603754990661558.2319591148348; Mon, 26 Oct 2020 16:29:50 -0700 (PDT) Received: by mail-ed1-f54.google.com with SMTP id o18so11551962edq.4 for ; Mon, 26 Oct 2020 16:29:50 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id ck19sm6596062ejb.99.2020.10.26.16.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:29:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2kYJylSUVap5cHs18MspyX6fw/+yTmDa3KK/zRKs/IU=; b=I/UxKwqjsp0MGWHZl4jbkzpoKAd0QGPrQ9/bMFCKa7ieiSocyeOO4aMnkEJfAWUeHV 5rKyNz9mrOBpkVnZSGEiPPBSYuLGh/mny4MyoON9boj64sZJLLUYSi1HWqLuBYHFqRkk spzXqU4TdFKIMOlDmbsZNIEvBfoS4O4X/19RLfrK+UXITNpFWe5Ox/kl3ZhEdsFgyCT/ 1hjdRlwylUj2wvnVEs8VInKVPE+qgeAYxkKBK0gx2U+W0yU0lfuWfNNB8o8JjLfH9Sp/ PGovMBtdiuZeTicJL5HsEsTmLz5GeLg+VAlKBgzW1QQJD5FCJ5+3EASWMFX0a7RyMT9V J+Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2kYJylSUVap5cHs18MspyX6fw/+yTmDa3KK/zRKs/IU=; b=Ns+IbuRgOOOPuHktgK5Xcr9TwS6vedDrgSMsfuV4NiaymefxBHlmFSLehBRm2muvPy WLoItMa0Nx+Pi/+SxHXpoNqIVYOfMrWmSfl+M7rUtDNINqLF3HvC8CuClHGm73/0dN8y 2PMRpERLMIqBS1g353ITGKuC+ij+UnygRB5D2mHMIjNCK5rGdJdmLoT59VJnjnz6ZkNw ptxtzJA7rYnmt9HjgulJnlB8JM2vNqPkd5i15YBYqd9KAIHogzghCHf0EbpVmJcizaiZ J8ZOksCNZFEAJTg0hj90xFNM24CkAspgWvmXAf+/xYWvkb+qEBglKjii+YfYLluYt0Pv mHNA== X-Gm-Message-State: AOAM5302Qg4g8VGL/XpYG8xvjOmqEYxigsRKc7oF9DErgbfSsdyL4Lbs E73h+W26O6pyHHamAioVSxY= X-Google-Smtp-Source: ABdhPJzli51YBxDrqx15oaQecjYaYeSkNVUgAQQsq5dCTGuDIYGa+JnK4pg046VKatbeFCb6W0eWDA== X-Received: by 2002:a50:e705:: with SMTP id a5mr13373894edn.29.1603754988641; Mon, 26 Oct 2020 16:29:48 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Magnus Damm , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 2/8] hw/timer/sh_timer: Coding style clean-up Date: Tue, 27 Oct 2020 00:29:29 +0100 Message-Id: <20201026232935.92777-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Thomas Huth Replace TAB characters with spaces, put code after case-statement on separate lines and add some curly braces in related lines to keep checkpatch.pl happy. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20201020153935.54315-2-thuth@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/timer/sh_timer.c | 89 +++++++++++++++++++++++++++++---------------- 1 file changed, 57 insertions(+), 32 deletions(-) diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c index bb0e1c8ee53..b09e30f9388 100644 --- a/hw/timer/sh_timer.c +++ b/hw/timer/sh_timer.c @@ -117,35 +117,55 @@ static void sh_timer_write(void *opaque, hwaddr offse= t, case 2: freq >>=3D 6; break; case 3: freq >>=3D 8; break; case 4: freq >>=3D 10; break; - case 6: - case 7: if (s->feat & TIMER_FEAT_EXTCLK) break; - default: hw_error("sh_timer_write: Reserved TPSC value\n"); break; + case 6: + case 7: + if (s->feat & TIMER_FEAT_EXTCLK) { + break; + } + default: + hw_error("sh_timer_write: Reserved TPSC value\n"); + break; } switch ((value & TIMER_TCR_CKEG) >> 3) { - case 0: break; + case 0: + break; case 1: case 2: - case 3: if (s->feat & TIMER_FEAT_EXTCLK) break; - default: hw_error("sh_timer_write: Reserved CKEG value\n"); break; + case 3: + if (s->feat & TIMER_FEAT_EXTCLK) { + break; + } + default: + hw_error("sh_timer_write: Reserved CKEG value\n"); + break; } switch ((value & TIMER_TCR_ICPE) >> 6) { - case 0: break; + case 0: + break; case 2: - case 3: if (s->feat & TIMER_FEAT_CAPT) break; - default: hw_error("sh_timer_write: Reserved ICPE value\n"); break; + case 3: + if (s->feat & TIMER_FEAT_CAPT) { + break; + } + default: + hw_error("sh_timer_write: Reserved ICPE value\n"); + break; } - if ((value & TIMER_TCR_UNF) =3D=3D 0) + if ((value & TIMER_TCR_UNF) =3D=3D 0) { s->int_level =3D 0; + } =20 - value &=3D ~TIMER_TCR_UNF; + value &=3D ~TIMER_TCR_UNF; =20 - if ((value & TIMER_TCR_ICPF) && (!(s->feat & TIMER_FEAT_CAPT))) + if ((value & TIMER_TCR_ICPF) && (!(s->feat & TIMER_FEAT_CAPT))) { hw_error("sh_timer_write: Reserved ICPF value\n"); + } =20 - value &=3D ~TIMER_TCR_ICPF; /* capture not supported */ + value &=3D ~TIMER_TCR_ICPF; /* capture not supported */ =20 - if (value & TIMER_TCR_RESERVED) + if (value & TIMER_TCR_RESERVED) { hw_error("sh_timer_write: Reserved TCR bits set\n"); + } s->tcr =3D value; ptimer_set_limit(s->timer, s->tcor, 0); ptimer_set_freq(s->timer, freq); @@ -158,8 +178,8 @@ static void sh_timer_write(void *opaque, hwaddr offset, case OFFSET_TCPR: if (s->feat & TIMER_FEAT_CAPT) { s->tcpr =3D value; - break; - } + break; + } default: hw_error("sh_timer_write: Bad offset %x\n", (int)offset); } @@ -241,8 +261,9 @@ static uint64_t tmu012_read(void *opaque, hwaddr offset, #endif =20 if (offset >=3D 0x20) { - if (!(s->feat & TMU012_FEAT_3CHAN)) - hw_error("tmu012_write: Bad channel offset %x\n", (int)offset); + if (!(s->feat & TMU012_FEAT_3CHAN)) { + hw_error("tmu012_write: Bad channel offset %x\n", (int)offset); + } return sh_timer_read(s->timer[2], offset - 0x20); } =20 @@ -272,33 +293,36 @@ static void tmu012_write(void *opaque, hwaddr offset, #endif =20 if (offset >=3D 0x20) { - if (!(s->feat & TMU012_FEAT_3CHAN)) - hw_error("tmu012_write: Bad channel offset %x\n", (int)offset); + if (!(s->feat & TMU012_FEAT_3CHAN)) { + hw_error("tmu012_write: Bad channel offset %x\n", (int)offset); + } sh_timer_write(s->timer[2], offset - 0x20, value); - return; + return; } =20 if (offset >=3D 0x14) { sh_timer_write(s->timer[1], offset - 0x14, value); - return; + return; } =20 if (offset >=3D 0x08) { sh_timer_write(s->timer[0], offset - 0x08, value); - return; + return; } =20 if (offset =3D=3D 4) { sh_timer_start_stop(s->timer[0], value & (1 << 0)); sh_timer_start_stop(s->timer[1], value & (1 << 1)); - if (s->feat & TMU012_FEAT_3CHAN) + if (s->feat & TMU012_FEAT_3CHAN) { sh_timer_start_stop(s->timer[2], value & (1 << 2)); - else - if (value & (1 << 2)) + } else { + if (value & (1 << 2)) { hw_error("tmu012_write: Bad channel\n"); + } + } =20 - s->tstr =3D value; - return; + s->tstr =3D value; + return; } =20 if ((s->feat & TMU012_FEAT_TOCR) && offset =3D=3D 0) { @@ -314,8 +338,8 @@ static const MemoryRegionOps tmu012_ops =3D { =20 void tmu012_init(MemoryRegion *sysmem, hwaddr base, int feat, uint32_t freq, - qemu_irq ch0_irq, qemu_irq ch1_irq, - qemu_irq ch2_irq0, qemu_irq ch2_irq1) + qemu_irq ch0_irq, qemu_irq ch1_irq, + qemu_irq ch2_irq0, qemu_irq ch2_irq1) { tmu012_state *s; int timer_feat =3D (feat & TMU012_FEAT_EXTCLK) ? TIMER_FEAT_EXTCLK : 0; @@ -324,9 +348,10 @@ void tmu012_init(MemoryRegion *sysmem, hwaddr base, s->feat =3D feat; s->timer[0] =3D sh_timer_init(freq, timer_feat, ch0_irq); s->timer[1] =3D sh_timer_init(freq, timer_feat, ch1_irq); - if (feat & TMU012_FEAT_3CHAN) + if (feat & TMU012_FEAT_3CHAN) { s->timer[2] =3D sh_timer_init(freq, timer_feat | TIMER_FEAT_CAPT, - ch2_irq0); /* ch2_irq1 not supported */ + ch2_irq0); /* ch2_irq1 not supported */ + } =20 memory_region_init_io(&s->iomem, NULL, &tmu012_ops, s, "timer", 0x100000000ULL); --=20 2.26.2 From nobody Mon Nov 17 09:50:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.51 as permitted sender) client-ip=209.85.208.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1603754998; cv=none; d=zohomail.com; s=zohoarc; b=aWJA36CGUNljloOe+ScRtgrxpA0RbzKT6C6LCB8c+ctBPwSP3fHS/THJzt7qEXyOGwmW9WCEnjK85op4E5SVnrBptMh/TzR2MiDnTeUmWcLCIHP3yA+tUA/wjcU3IYUPSHNq+d830ykwy3SregJjUKqGh/xB1Zw6xnpglOGhBTE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603754998; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IPy8xSDiS043tJ1qMib/hHCsnldOT9q1j5PDtKMfWf4=; b=CLh0yonQ4blPg1mWOB91Eitt4RCng7bKNrkVTf/Z2jQJXAFUp27Ul3BUC3bp9YCiG15N93fFUFbQ7Tl0oPJtSDWDpssLRGUQ3MNO2VtX3uLN19N6O9eC7Dfj9tcR4twYlA/XBycUEhsDBgqDEJ7NZHJRDP5muxwx/b9ftxoGj44= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by mx.zohomail.com with SMTPS id 1603754998295677.3431553888178; Mon, 26 Oct 2020 16:29:58 -0700 (PDT) Received: by mail-ed1-f51.google.com with SMTP id w23so11568899edl.0 for ; Mon, 26 Oct 2020 16:29:55 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id c5sm6003342edx.58.2020.10.26.16.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IPy8xSDiS043tJ1qMib/hHCsnldOT9q1j5PDtKMfWf4=; b=YjyO25H7f/AlgxZ5zvDpiKR2vl+Tonxb/fesN+Lhox3oU9iYqtExyvrDPb6UElb54C uB59d+9aximzMS544QjdpUTAE64RGtjMpV/NYUueabxJIAoMZxqpzdooiOewpcnOOPXZ EX9tNd7sBh8BbwVXO+JhAkwqO+n8AraQcnCblpA1NpAYrZTYTv23j0YBXcpYJWmPgI8v S2sS/oNWJYWhpBj6hrZ/uapW95jxDblqkBJeNrHmus9kRmQ9htoBsup/srj9mtmgywko w3hmwR2VymCvtLLMDE5eTlvwxHpXI4COkuLUQ8CHzYH5foaZ4faBHwtmJa/Y7t44lBuy 1eXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=IPy8xSDiS043tJ1qMib/hHCsnldOT9q1j5PDtKMfWf4=; b=ElY4mZtQQMl3utP9Qc72QuZHQsHCZ/hIzLbN3puQ8U3GntyURNximiJ0AvLqbauUX3 O8gOwI7B8NyM5/UqsoXutd2F1yTTlOuK6QuQ5fKDdPG/6aLsx/yBWRN2piPRaAQAh5YO XM9CYcN/bHyfqsYmEUQLpSw80wPtCUj2Egd1htNhMVjKptgS5YGeFwwHaTFMTNGFaz+T vYGWaDU00W7BUzW//48u9zMrFctlOym9oSWM5EmHI1Yke3Sjk9q/wwqgPeOHINm7pmE0 jAiTGub3CXghStIianoxlbDuFoKHGutEhIykykbAWWk4boG1m605NzhxUP+oXMm+dF4Q au1A== X-Gm-Message-State: AOAM5333Dwt9MnF+E/6D/KghImDTkD8UGSuXeDCar87upbg+LOl3OBgO eG+xa4N3IGnS03HuKMhfy9k= X-Google-Smtp-Source: ABdhPJy8qozl7+BUfvRi4eLSqZDBe8zDdIX521ymCx58GbHStOofoFONEal03BDnOO4StkVlSAGnGQ== X-Received: by 2002:aa7:c5c4:: with SMTP id h4mr18733480eds.379.1603754994405; Mon, 26 Oct 2020 16:29:54 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Magnus Damm , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 3/8] hw/timer/sh_timer: Silence warnings about missing fallthrough statements Date: Tue, 27 Oct 2020 00:29:30 +0100 Message-Id: <20201026232935.92777-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Thomas Huth When compiling with -Werror=3Dimplicit-fallthrough, gcc complains about missing fallthrough annotations in this file. Looking at the code, the fallthrough is very likely intended here, so add some comments to silence the compiler warnings. Fixes: cd1a3f6840e ("Stand-alone TMU emulation code") Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20201020153935.54315-3-thuth@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/timer/sh_timer.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c index b09e30f9388..934daaa7dcc 100644 --- a/hw/timer/sh_timer.c +++ b/hw/timer/sh_timer.c @@ -122,6 +122,7 @@ static void sh_timer_write(void *opaque, hwaddr offset, if (s->feat & TIMER_FEAT_EXTCLK) { break; } + /* fallthrough */ default: hw_error("sh_timer_write: Reserved TPSC value\n"); break; @@ -135,6 +136,7 @@ static void sh_timer_write(void *opaque, hwaddr offset, if (s->feat & TIMER_FEAT_EXTCLK) { break; } + /* fallthrough */ default: hw_error("sh_timer_write: Reserved CKEG value\n"); break; @@ -147,6 +149,7 @@ static void sh_timer_write(void *opaque, hwaddr offset, if (s->feat & TIMER_FEAT_CAPT) { break; } + /* fallthrough */ default: hw_error("sh_timer_write: Reserved ICPE value\n"); break; @@ -180,6 +183,7 @@ static void sh_timer_write(void *opaque, hwaddr offset, s->tcpr =3D value; break; } + /* fallthrough */ default: hw_error("sh_timer_write: Bad offset %x\n", (int)offset); } --=20 2.26.2 From nobody Mon Nov 17 09:50:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.52 as permitted sender) client-ip=209.85.218.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1603755001; cv=none; d=zohomail.com; s=zohoarc; b=VlGYxd8/5n8HcoaSd0LyOMHLqyPp/vpERO/UyR6uSVELtw/MEz3UbaA6tnbf9xA7wmUCm/EHNlt/i4QW7EQ1Yd6Na29cq07sZsgDhR6KVlL6Y1YLIkSY91QOcBAigARza5gjxkesFNgX8CRwyj6JzIQT2k89oOr+d0SszuXkW1A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603755001; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2OjR/wUfEEBugepvrkgMq+mri256jiLmUAh08vclpww=; b=AfH3Wq3hy+hw8uTQKaoU7ckJF9rTpwJ+Nu62d8skjbXNOFxVwAmHNflaHlseqfBGP+LskQTrD///qHpHeuZwRKPtATAMh2UudP85sM/PgjUKSgLQwk9xvKmPfQCmosYnlM2/9snTTk6H/pGtopoaYnBsO1umDAilDZLhE5HpZtw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by mx.zohomail.com with SMTPS id 1603755001734604.6224134995019; Mon, 26 Oct 2020 16:30:01 -0700 (PDT) Received: by mail-ej1-f52.google.com with SMTP id dt13so16456999ejb.12 for ; Mon, 26 Oct 2020 16:30:01 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id n22sm5969260edr.11.2020.10.26.16.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2OjR/wUfEEBugepvrkgMq+mri256jiLmUAh08vclpww=; b=bIW7W8qmw+I/hh1l0NKHHt88h0LKNmG1nWv8jbPk/BlX3yFIeVyaP3k6FnhhM59K1w 7BbUMwMCNQUrFlXYfq+G72Rtx69AFlvfv6W3P8mGhfP9UwzOhAxN/kyHDIjGrkTbtFfc caun4lWhNcXLOUmZZd7f4+q5BrrlOj3y7VvE2yLoAvSxkqnb3p9WweQPkOWQjcUudwaN 9DaCeMV8Qj6cNGqKGemQwTopNAH88ez5OUnWWyR3BZCqZbnKEx6qrH91AVSB+GyqlV7V amVKbCIcgqGWvrVX0/3HGTCM81MVLwmhO9hCRhnXvKkabcJ+4gGtrbiQ5dp725luku38 LIww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2OjR/wUfEEBugepvrkgMq+mri256jiLmUAh08vclpww=; b=dYpB0BbcbgDjoLTYvrr+lwZKVDPz6XyLw9WTQPpJc/9PtBiuY5quc6RuYlgFmRv68O 5Y4/bFw6gK3WZnetPBIOD8hkIhetKhRj2bZXgx74gaqJrQoehmwIdFxwcGtI8jyxGD01 rNwI1qaBg5+MMPeKr1u/BiWROwJKnXBiv0u61M01liTok3zkupCBTd2UxZGmemCS6Kvw JewQAMwFL0ETKcOUL6+JEQ+H3EJ5TvPMqw9N+yEBuec/pyf5Mzx00O3X9Tv81TMHmCDy LLKg7AiwSwghCw9Z4eoGSZFPm9xY3T+b3BCJbrli8EFQu8tgJWHwGBH5ENYrY4fL79qT pzIQ== X-Gm-Message-State: AOAM531GrOgmuAxeI2nxnIMcds8kdeRHFnVCTcXtePot7nvkqvZA/8kQ zWt62ivEBwbddYTn2Q8rnio= X-Google-Smtp-Source: ABdhPJxnD0XrshsqAsbiYsU2dfkGZR59jox1zaGn5TYf4myTczI15Kve6jh4wb/d/oTcBm9nte9C/w== X-Received: by 2002:a17:906:1107:: with SMTP id h7mr17808599eja.481.1603754999863; Mon, 26 Oct 2020 16:29:59 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Magnus Damm , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 4/8] hw/timer/sh_timer: Remove superfluous "break" statements Date: Tue, 27 Oct 2020 00:29:31 +0100 Message-Id: <20201026232935.92777-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Thomas Huth hw_error() is marked as QEMU_NORETURN, so the "break" statements after this function are just dead code. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20201020153935.54315-4-thuth@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/timer/sh_timer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c index 934daaa7dcc..58af1a1edbd 100644 --- a/hw/timer/sh_timer.c +++ b/hw/timer/sh_timer.c @@ -125,7 +125,6 @@ static void sh_timer_write(void *opaque, hwaddr offset, /* fallthrough */ default: hw_error("sh_timer_write: Reserved TPSC value\n"); - break; } switch ((value & TIMER_TCR_CKEG) >> 3) { case 0: @@ -139,7 +138,6 @@ static void sh_timer_write(void *opaque, hwaddr offset, /* fallthrough */ default: hw_error("sh_timer_write: Reserved CKEG value\n"); - break; } switch ((value & TIMER_TCR_ICPE) >> 6) { case 0: @@ -152,7 +150,6 @@ static void sh_timer_write(void *opaque, hwaddr offset, /* fallthrough */ default: hw_error("sh_timer_write: Reserved ICPE value\n"); - break; } if ((value & TIMER_TCR_UNF) =3D=3D 0) { s->int_level =3D 0; --=20 2.26.2 From nobody Mon Nov 17 09:50:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.42 as permitted sender) client-ip=209.85.218.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1603755007; cv=none; d=zohomail.com; s=zohoarc; b=gmxG9ZCfPde4NuFbhIhNaqaiIwQuWvjkfA8uktQpgnPYGwVpgvQt/VOx7e865yRyL5L7ZUUblj/KWkIoZ/1D84QonZSkgy9uK9qMkP4L8zApLF2d7yxsu37fLOSrDeZbmiUvOWHbcQogvdFLbptQED6+n2b2B1rUoOTsGPYAS9Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603755007; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ByHyPPqDa1B0Z2A0GB22PMBVgYYCiahQCzikXG3rHfE=; b=UsaogpXHasLvkLs5MLA/RPCc8E/EqpAPrK/s7nb5Hm/5pmr5OiHgKPo3ugZGa6fIA0ZGOf8jYlzLop7sOvrJlZK8jAwUQt78Ti+W2cWqF+2LXZAgZQPp2vNCp1hu+WaAk4A4etxuUOF+QrVQowWTib0u7W1K1s+cn29d6rfpqvs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by mx.zohomail.com with SMTPS id 1603755007356767.6213426913985; Mon, 26 Oct 2020 16:30:07 -0700 (PDT) Received: by mail-ej1-f42.google.com with SMTP id p9so16494778eji.4 for ; Mon, 26 Oct 2020 16:30:06 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id d20sm5907484edp.85.2020.10.26.16.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ByHyPPqDa1B0Z2A0GB22PMBVgYYCiahQCzikXG3rHfE=; b=nCDVqzfHJDfKssmIVW/lJS3qdYaCfFEqyYwpayAM5sTxjHLP0WJjNHlmIqKcGgS0RW 7qvqDPL5AVXF1DgaTBqTtbSsx3w9OUPzg48I/tqniVHQA8U+80b+SnKOlDmy65HeXE3M HTKu3i1ZDkrZYqwl8VsD7oNCDoqx0FANLGbdkaqacc0T/LWaki1wFdiWt2uy+wGlbcl4 FaHwsERLQosvuqd/zksmqlpmSCNIZFM25+IYK11CUf/GTSYqlJZ+LbbpWsyRkjMcBIrW D8GsIFUXNqBRepLJ+0JFunPVQQPZUBv9nP7VhG/QAWiz+0e//nR2soMTjhcSs1uasXbU alQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ByHyPPqDa1B0Z2A0GB22PMBVgYYCiahQCzikXG3rHfE=; b=sCgEFWvj7yUgZp/i82mCiiWnvUgs8uQ8G3zjRRJ9kztG2YFd/+G6v7ts83az1e+tyt ruYM9i1eJN5T1F6os+/U4l3pdmL/jzc1m9hLo0kwml/Vgjb8L83xWyn749YmeH4TdRkW rGvjim/jGJGUCqq26e1qh7FgWigF5t3NLkuxhKpPJgeve3ei9JhLWu8Haq30prw/M/om eP2Z20qxBXax4T7pMyE3qrhUm21RluG7C0qAO0Qht/lHEvEwBbA76jP09/SmhCk+wka+ aHDFRiH0vKARNeijl8Fb4JL11GcNU9SPEsrHn+IZYMw3p6FS834GuGDAriB+yCY+L0h4 nJkA== X-Gm-Message-State: AOAM532zLYc5uUveu6hOh52gOk7N+7GI0GtzOuAkp7HjFg4lsJ4/CN48 lKMwYhTFvFmuwFbUt0VuZbY= X-Google-Smtp-Source: ABdhPJz2kjBKqV0Pjh0ofWny0kDlaRA08V2CrKQXUnnZRnuvqs+G6Kf3MM4Czb/b7pedng1X9deghA== X-Received: by 2002:a17:906:4351:: with SMTP id z17mr17968767ejm.110.1603755005557; Mon, 26 Oct 2020 16:30:05 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Magnus Damm , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 5/8] target/sh4: Update coding style to make checkpatch.pl happy Date: Tue, 27 Oct 2020 00:29:32 +0100 Message-Id: <20201026232935.92777-6-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Avoid checkpatch.pl warnings in the next commit. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sh4/op_helper.c | 8 +++++--- target/sh4/translate.c | 8 +++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/target/sh4/op_helper.c b/target/sh4/op_helper.c index 14c3db0f485..fcd9ac7271c 100644 --- a/target/sh4/op_helper.c +++ b/target/sh4/op_helper.c @@ -398,9 +398,11 @@ float32 helper_fsrra_FT(CPUSH4State *env, float32 t0) /* "Approximate" 1/sqrt(x) via actual computation. */ t0 =3D float32_sqrt(t0, &env->fp_status); t0 =3D float32_div(float32_one, t0, &env->fp_status); - /* Since this is supposed to be an approximation, an imprecision - exception is required. One supposes this also follows the usual - IEEE rule that other exceptions take precidence. */ + /* + * Since this is supposed to be an approximation, an imprecision + * exception is required. One supposes this also follows the usual + * IEEE rule that other exceptions take precidence. + */ if (get_float_exception_flags(&env->fp_status) =3D=3D 0) { set_float_exception_flags(float_flag_inexact, &env->fp_status); } diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 60c863d9e1b..ec5b04889e1 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -1959,9 +1959,11 @@ static void decode_gusa(DisasContext *ctx, CPUSH4Sta= te *env) NEXT_INSN; switch (ctx->opcode & 0xf00f) { case 0x6003: /* mov Rm,Rn */ - /* Here we want to recognize ld_dst being saved for later consumti= on, - or for another input register being copied so that ld_dst need = not - be clobbered during the operation. */ + /* + * Here we want to recognize ld_dst being saved for later consumti= on, + * or for another input register being copied so that ld_dst need = not + * be clobbered during the operation. + */ op_dst =3D B11_8; mv_src =3D B7_4; if (op_dst =3D=3D ld_dst) { --=20 2.26.2 From nobody Mon Nov 17 09:50:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.48 as permitted sender) client-ip=209.85.218.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1603755012; cv=none; d=zohomail.com; s=zohoarc; b=iSDdE1Suf8tlaWaG36hCtgf48lxtML33aSkWuPHpU6OLFckMs4Qxj85+qr1cOgK53lVYrlQvIcfn4iqXfBbf8ZpVirj0TdIOaVz2eiFYLXTHYrChyF9cwOE7F/ZdjkjI+urteyIMDxHasGKlWsn6MahPCWZ927MOyjvG/QGE+RA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603755012; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XhnjuVobHMzU6+7R+rNCPQc+fD9fjM3UbUM8qny37GM=; b=Ye4Yjh/oNWnUpN+mPSuVZ4TQ9MEJeoPaCay2lgyBMXfLn9phHEPuTsKgZFTmVzswR1GflO9asYBnUvs5KBlTu12Mq3rtOzS1PVrTUMd2I1BYk0GVJ7tUB66b98Ss6BYRGhAmhUP4B8vApjQ35zdDTpoUg7mrFx+JFYPAni7JTy4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by mx.zohomail.com with SMTPS id 1603755012614621.5186911783355; Mon, 26 Oct 2020 16:30:12 -0700 (PDT) Received: by mail-ej1-f48.google.com with SMTP id ce10so16480614ejc.5 for ; Mon, 26 Oct 2020 16:30:12 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id o15sm6717627ejm.38.2020.10.26.16.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XhnjuVobHMzU6+7R+rNCPQc+fD9fjM3UbUM8qny37GM=; b=fmSh1O100g+ggujU0fOeG1lI443JULq4WW/bGa3PZ4NsygMZjUhUEJ+r1II/W9QVhz DgshmaODpuRkjmF9QaubUmAACcq70utUbq4afukVTzpdlwPQJizcFwSO1ptfQNvdAAiC QrG4rgxMjz622CdmG3oM9HwsKMItaOjoouqUqhoFhYklIu1GbdQ/Lk54wqVbubYjS28h o6MiK3pmzjesXXS0K4H054iTLyRxjgdn5rLAX3M8+cDw3BdwniSsOb8gESc8E+ev7Nvb JnGZQrj+tLNm1s/S6zoxBoFXCBS7vjJNOzE7umQ517bSJOdffBb9QVFRGrod+I/+5mPh A5zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=XhnjuVobHMzU6+7R+rNCPQc+fD9fjM3UbUM8qny37GM=; b=T0Zj7uZIX2/SDcqvSuj0b6+pbc3v2zh/hIGIq+Max4AuvIOYoaKmijmROru/HO/FFP xCWeejX84g5hmU2Re2JbHWgmIJszxfdQxUILE/lC8Fxp0HS0X+QXgD2alqdYNM93yTyK iKD1nsxreu4w5+UPCk2ihvRxcleDWDLB1bW4YB+E5gPAZHO+GCtHc4vp82jjo1FxxRzf +mbFl54GI/Vh929cVAyNmFOnjTLxe2mnJGQoLsD6UkBCb1/IsrhXimnEVIyNQ5dDruT2 eB0vYaKzRMUZ7FQ+ulrhdo42kQYc01fKjB2+mDSPRDDlW/zAV8wZYnZiS3+29Xk6Epy2 REAQ== X-Gm-Message-State: AOAM5319qemlNVOSxMf4rRNI2MV8powvA4EmxIIH4/8hAAGdFVstqXLH 6J4D1klJiT3tBACWkNouwRo= X-Google-Smtp-Source: ABdhPJxdJ/T0Qj0ELeG+hiYmQBkWvA5R8uuBXtIUB1ZeqFuY3VHcf2hLlB41R7Dx9x8qeJGzQWcwEw== X-Received: by 2002:a17:906:1b51:: with SMTP id p17mr8622847ejg.462.1603755010770; Mon, 26 Oct 2020 16:30:10 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Magnus Damm , Lichang Zhao , David Edmondson , Philippe Mathieu-Daude Subject: [PULL 6/8] target/sh4: fix some comment spelling errors Date: Tue, 27 Oct 2020 00:29:33 +0100 Message-Id: <20201026232935.92777-7-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Lichang Zhao There are many spelling errors in the comments of target/sh4. Use spellcheck to check the spelling errors, then fix them. Signed-off-by: zhaolichang Reviewed-by: David Edmondson Reviewed-by: Philippe Mathieu-Daude Message-Id: <20201009064449.2336-10-zhaolichang@huawei.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sh4/cpu.h | 2 +- target/sh4/op_helper.c | 2 +- target/sh4/translate.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/sh4/cpu.h b/target/sh4/cpu.h index dbe58c7888f..714e3b56413 100644 --- a/target/sh4/cpu.h +++ b/target/sh4/cpu.h @@ -160,7 +160,7 @@ typedef struct CPUSH4State { uint32_t pteh; /* page table entry high register */ uint32_t ptel; /* page table entry low register */ uint32_t ptea; /* page table entry assistance register */ - uint32_t ttb; /* tranlation table base register */ + uint32_t ttb; /* translation table base register */ uint32_t tea; /* TLB exception address register */ uint32_t tra; /* TRAPA exception register */ uint32_t expevt; /* exception event register */ diff --git a/target/sh4/op_helper.c b/target/sh4/op_helper.c index fcd9ac7271c..c0cbb953828 100644 --- a/target/sh4/op_helper.c +++ b/target/sh4/op_helper.c @@ -401,7 +401,7 @@ float32 helper_fsrra_FT(CPUSH4State *env, float32 t0) /* * Since this is supposed to be an approximation, an imprecision * exception is required. One supposes this also follows the usual - * IEEE rule that other exceptions take precidence. + * IEEE rule that other exceptions take precedence. */ if (get_float_exception_flags(&env->fp_status) =3D=3D 0) { set_float_exception_flags(float_flag_inexact, &env->fp_status); diff --git a/target/sh4/translate.c b/target/sh4/translate.c index ec5b04889e1..93127906237 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -1960,7 +1960,7 @@ static void decode_gusa(DisasContext *ctx, CPUSH4Stat= e *env) switch (ctx->opcode & 0xf00f) { case 0x6003: /* mov Rm,Rn */ /* - * Here we want to recognize ld_dst being saved for later consumti= on, + * Here we want to recognize ld_dst being saved for later consumpt= ion, * or for another input register being copied so that ld_dst need = not * be clobbered during the operation. */ --=20 2.26.2 From nobody Mon Nov 17 09:50:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.48 as permitted sender) client-ip=209.85.218.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1603755018; cv=none; d=zohomail.com; s=zohoarc; b=b7Gk4MOluiqR7pvr2SxtQ6e55rdyv18wtq5H6/J+uEtyOAQCHsxB2wcvN6k8Fy0zeihP/X/ez6nSzUUeQGZtwztKjeYfZDwrWvkaUgZnaI8vV0xObhxX/NW42TrGK11/edKtJycYf8Ql/lT+nfuthZaP1nDx1WWdfDI0KOlqf6g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603755018; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pEqSKEMY04puZYBT7KxO2knLfSLveelIAXH747evHJ0=; b=GKLyGkk50KaD2jarLWtiaiLeNRtUSPyTeX6zpGODpwPuzmSC5/wt3UU2mLHTOLPzDg9urNSjeXT7MXXPL3DbBDi/oYTz3jJnNxW4sepo9s2R9VyBslWMiUAXo3ckR4VdRfWNS7KnB86kRSukbfMjUb5uCeCOSUTCvI1xlhM2lYM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by mx.zohomail.com with SMTPS id 160375501833058.415849418315474; Mon, 26 Oct 2020 16:30:18 -0700 (PDT) Received: by mail-ej1-f48.google.com with SMTP id w27so16506752ejb.3 for ; Mon, 26 Oct 2020 16:30:17 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id m11sm5970344edv.14.2020.10.26.16.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:30:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pEqSKEMY04puZYBT7KxO2knLfSLveelIAXH747evHJ0=; b=MvwyJshDxZ7tllBWWiu5xhHIL9RNwRAgI4uwjqbfbGzpZ/IWd5K7angs5wbpSQ9+Lv s5hYBNlY2/yoOZ3RpSjBhr/qGv6UbO+NsJW1XN0JUUtuKLUJ7vZntIfx8ykQSESk2aUM /kCdvka9J8xwaHlX8Su+cnH2mzkswJD3wkXcJmwRxCvQ0BxcjrDxTU3TgsjlRQWfUZ6Q xQ7dP6aRamwnnpsre4q/5NJ7MjZ9+WTpVUelLq0spSuEbarGHzD4JJvrMWg50pwZ36pX 9f3sLzYk1hveFeFgftzGw/Qx6SuYkYbw99mK7XwV3eW9LMXS0gTKIjjgGj0KYopW87gq 3jWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pEqSKEMY04puZYBT7KxO2knLfSLveelIAXH747evHJ0=; b=GWqAy30NBAFwgIZPdzhYGSmfSKIHUF0rP3EJtnx1DM/6k0LQCXt2cl7/tOJ5joehB8 suibw78nvcgHotJMU2i82BO/GMNAyIpbF1i0oiTTJfVUS7GVZv6VWVyddd2bS/ex4lln X/cCPZCNITuFzyx5d/Yfq06tTyjvsQVc2t9PpP9hTxVZpYGA+wwx73W1aK6xxFzFCuW8 IPe4Rb8NfN3BKhAae2tyKhAdL5+4g+bciebDJqZItXWoUnNnJ2CRwyM611NpKEubh+Ci /lDigY8dSexJI6JRue/lJyroWhQjhK2F+G69m9vhfODFHlZZYYHAWlyC+HLVqXJRTdBG 6fAQ== X-Gm-Message-State: AOAM53370XRvKXiBdmYULfI6uqgp4Q9BbXzxD/KDciCVylDg0+QoXTp+ 4n7A+2/EqExkn0QrTVkO1KA= X-Google-Smtp-Source: ABdhPJxNvylgZNUJpuhj3ahISda1unkvX7kRgyYwiHTUo5YBfCKnAe+6VQm2N0fIGUZLhoh9VOSmhA== X-Received: by 2002:a17:906:824b:: with SMTP id f11mr17585521ejx.16.1603755016520; Mon, 26 Oct 2020 16:30:16 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Magnus Damm , Lichang Zhao , David Edmondson , Philippe Mathieu-Daude Subject: [PULL 7/8] target/rx: Fix some comment spelling errors Date: Tue, 27 Oct 2020 00:29:34 +0100 Message-Id: <20201026232935.92777-8-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Lichang Zhao There are many spelling errors in the comments of target/rx. Use spellcheck to check the spelling errors, then fix them. Signed-off-by: zhaolichang Reviewed-by: David Edmondson Reviewed-by: Philippe Mathieu-Daude Message-Id: <20201009064449.2336-5-zhaolichang@huawei.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/rx/op_helper.c | 2 +- target/rx/translate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c index f89d294f2b2..59389f49921 100644 --- a/target/rx/op_helper.c +++ b/target/rx/op_helper.c @@ -318,7 +318,7 @@ void helper_swhile(CPURXState *env, uint32_t sz) env->psw_c =3D (tmp <=3D env->regs[2]); } =20 -/* accumlator operations */ +/* accumulator operations */ void helper_rmpa(CPURXState *env, uint32_t sz) { uint64_t result_l, prev; diff --git a/target/rx/translate.c b/target/rx/translate.c index 482278edd25..9ea941c6302 100644 --- a/target/rx/translate.c +++ b/target/rx/translate.c @@ -1089,7 +1089,7 @@ static void rx_sub(TCGv ret, TCGv arg1, TCGv arg2) tcg_gen_xor_i32(temp, arg1, arg2); tcg_gen_and_i32(cpu_psw_o, cpu_psw_o, temp); tcg_temp_free_i32(temp); - /* CMP not requred return */ + /* CMP not required return */ if (ret) { tcg_gen_mov_i32(ret, cpu_psw_s); } --=20 2.26.2 From nobody Mon Nov 17 09:50:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.52 as permitted sender) client-ip=209.85.218.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1603755023; cv=none; d=zohomail.com; s=zohoarc; b=Kjm1nN1zxnY86PYiwQL3LhKj3cuyTctdkuASZ25LAOQKpkkY+2ICLFEP1ir10PT/yZlMk7LXxBQzyKQ3yWbPD9JqMQ5/nKVZFJ15076KwucQ1/24lRwkK1dgk7/VruC3E9x8uDNgbN+cj80tjhzz929K6dWb6XvowXrNVIdVZ8k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603755023; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=W3Vv/QCWXUFg/foUe4To3UqDPWKAHvwPLF8rKVguBJk=; b=K8UkirUnFqCmOBHdtIp1peVMGTz5eKrmImlDchZC35Z/lBggQEBsAoW4aa1ksS6K/Ijxz3bPTg/Rv5/EuqQhnNJMi6bj/HIyRw9qXSF/wzLnWKYSNbJZeRBqTdvwnSD5/PmMO15E88BD3SVgKtgsLqjZst5cmkhaxe7OkhPQPVc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by mx.zohomail.com with SMTPS id 1603755023806791.487081103816; Mon, 26 Oct 2020 16:30:23 -0700 (PDT) Received: by mail-ej1-f52.google.com with SMTP id s15so11932406ejf.8 for ; Mon, 26 Oct 2020 16:30:23 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id t15sm5948010edr.27.2020.10.26.16.30.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 16:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=W3Vv/QCWXUFg/foUe4To3UqDPWKAHvwPLF8rKVguBJk=; b=fCXmF8FbDBx/SIXLzr9WdkSYJwYMIY27zgNwbRw76qP71b6mwta7DeMxs1l1QjgtWi kSqYM2FCYTySMzjjU/gDQPafT5NySt+MnXK9OfQWhOpqdAmGaGkqrkSwjtmPlywIDCJd 7bDXDW3XNEsf4KgqbvKMT2eBsROMVze9fqnw1M4U4d3PBSvzRViVrtniRwBbtSh6MdoG vMpDGvneGZt2LioQEGXlPCGhjThYKGhLI5ORB/zgXISx6tsAhAKxY5GHOjaHDl7T9LtG 68zf+vSvi8H09IzkZe9QXoLuvjm2cpxSOG6iSssQS+FZfWamdwGO0iTZ4qTu3I/9EzkL SP0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=W3Vv/QCWXUFg/foUe4To3UqDPWKAHvwPLF8rKVguBJk=; b=LI/E9OJpQ3ZlbSeNddpIhwpwrm9Qc50R0WJXl6LnHHKXlhKp7o4eF19tak67xW58nv pb0P9fV1JqLFGEkFzhBmE8Db0+gI0UH24UEZ52EEDPGvyXLUPTEA/7Yto9yhvgCpq/yg oiK+5nRELCpaIwDnOS/bo8pDybbtyBmEHxpXEYIW/FVRNvIarrZ/ms7ioIWXvLjAfG/Q mKhYiVwMyrfe/Ohwg3tuKhI1TW0se6FAQEAmyyF3hoKK8i8rsAsTYoHqshRcD56UCAfS ePNcoeOOI3J5phHq12Z+dfsuW87FOHA13hCS8XUlmsGfoJo0Y+IWP9MYPAepkIfpX7l7 dWlw== X-Gm-Message-State: AOAM531DJHs17aF8Mf8IFLgmBKQQ9Iz9nK+1ib5QSVrZpqeQea5JUcMQ Z1K3eI3zqe65jxk7KpTI9rE= X-Google-Smtp-Source: ABdhPJzAvg8E4+MptrAi3QV3nzihfSdPJcEzv7+ee50wxEtscV190cgXAxvcNu8UjBkmvpHhuMtpjQ== X-Received: by 2002:a17:906:3406:: with SMTP id c6mr17140314ejb.65.1603755021949; Mon, 26 Oct 2020 16:30:21 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Magnus Damm , Chetan Pant , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 8/8] target/rx: Fix Lesser GPL version number Date: Tue, 27 Oct 2020 00:29:35 +0100 Message-Id: <20201026232935.92777-9-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026232935.92777-1-f4bug@amsat.org> References: <20201026232935.92777-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Chetan Pant There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201023123840.19988-1-chetan4windows@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/rx/insns.decode | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/rx/insns.decode b/target/rx/insns.decode index 232a61fc8ed..ca9334b37af 100644 --- a/target/rx/insns.decode +++ b/target/rx/insns.decode @@ -7,7 +7,7 @@ # This library is free software; you can redistribute it and/or # modify it under the terms of the GNU Lesser General Public # License as published by the Free Software Foundation; either -# version 2 of the License, or (at your option) any later version. +# version 2.1 of the License, or (at your option) any later version. # # This library is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of --=20 2.26.2