From nobody Mon Nov 17 12:05:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.68 as permitted sender) client-ip=209.85.218.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1603750013; cv=none; d=zohomail.com; s=zohoarc; b=R/IaTFMR+W14DoA5Kv4DR6aZf7XEhHlkcFMYZsRN/GJudP0ULs9N54gPoSok9hp1JHWWA1GWW7Br6TYouCPNOym9mdoAusLoZwI1Ebzk44I06DRf+z8yQCjE2y1rxpF4GfGzjyu1hW19KcWxQNrKi4qt7a2soW62is/CSIPE/uE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603750013; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kkYx6ufxDsW7KHkPk9xI2ZT1n0haC2qnRwJcFZkWqPY=; b=l7cU+1x2jiZKOtWzfZqMHgMhbGJ4uip+1yoZaLheb02EtunvGpu5gKOfqOE8KTaEIx0Bll21Tr4YE/SwRhBGVwmgEvN5wX7kknX2+CW1eWSaPMCbcKtAkh9DoRlkq9S4LKiY46cKMD9QHUx/DSuNxeCwCPHdCeTlOU4zxplJVks= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) by mx.zohomail.com with SMTPS id 1603750013256370.765390833408; Mon, 26 Oct 2020 15:06:53 -0700 (PDT) Received: by mail-ej1-f68.google.com with SMTP id gs25so16127982ejb.1 for ; Mon, 26 Oct 2020 15:06:52 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id j10sm6199584ejy.90.2020.10.26.15.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 15:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kkYx6ufxDsW7KHkPk9xI2ZT1n0haC2qnRwJcFZkWqPY=; b=oOUnqJjd44A9V0uVy6Bt58BV7gQ0P2/YTUfW4UFqJt54ddwi7McYw3p4YI4afVdT27 JO5gTfKrq/2YMXSgQdsbprS4GtGOqYX69dEQXavTjZx1m/h3VdT8qOrAKaYOp79auLVX cEetUdvPIORQLj+usr6K9iLPHLD3/ppaWBbNYnr9wUcQf86ZY7db7kZpFAPtH+wRtaUS 4X/HI6BtAs5HuvLlAbJIIA+9VMYr6BeBkUwONiHgq5frWExs6Dp+DiKKZ3SdBDiWmCrU SjGw/EuuZ5AmaAM7bWWUIYb5md3EUXRwQDl8/3tCb1Dd/aKRRZZJMuar7hf4Ri4CltFm 64ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=kkYx6ufxDsW7KHkPk9xI2ZT1n0haC2qnRwJcFZkWqPY=; b=azG5PuzY/tZkpv/1Xs0qQK/0Ey3uQsGO0AThrun9ZOxZZVjysEmMHhkPR94/F58Q09 Q/DFNgWwebkqWECotm0oKl9qZRsPz3ht4Wz4HH276FVcbM4B0lW3fiCAe4y4c5d4Sz6L r/bVoVIRNrrRMEOWnrG2vPFP8Wj5JsAliVUzgIcaf4LBrddLI0x+bs/XCP6ZsqJnlwXO rJ75Vz2naCXmZ9d356YQfWOn8pFtGdER1py2Gg0CP17il0RPhNeXRXyMrOQjjMs12W70 +nQrJrslseYi6wBNEIXRwcFYwK4wkwqra5yEdqJtTYcC9QixXktpGXXIoI5l4/fEYX+B IEPg== X-Gm-Message-State: AOAM530VGbFEkp8OBLGRlCg9+6t8fLnqj62n84CRS8UWu9J+458RbC2t JY929L3elRz2in6ojGmhIm4= X-Google-Smtp-Source: ABdhPJypqmunxv8fn8CVTBt1NixjQC4QefEdnZtkEL7NdqgxRlFZqmjp+ptIFyStyxHEJKAgpGJgSw== X-Received: by 2002:a17:907:43c0:: with SMTP id ok24mr17765576ejb.385.1603750011360; Mon, 26 Oct 2020 15:06:51 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Andrew Jeffery , Joel Stanley , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Andrzej Zaborowski , qemu-arm@nongnu.org, Paolo Bonzini , Peter Maydell , Richard Henderson , Luc Michel Subject: [PULL 4/7] hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1 Date: Mon, 26 Oct 2020 23:06:21 +0100 Message-Id: <20201026220624.60878-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026220624.60878-1-f4bug@amsat.org> References: <20201026220624.60878-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The Witherspoon has 3 LEDs connected to a PCA9552. Add them. The names and reset values are taken from: https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml Example booting obmc-phosphor-image: $ qemu-system-arm -M witherspoon-bmc -trace led_change_intensity 1592693373.997015:led_change_intensity LED desc:'front-fault-4' color:gre= en intensity 0% -> 100% 1592693373.997632:led_change_intensity LED desc:'front-power-3' color:gre= en intensity 0% -> 100% 1592693373.998239:led_change_intensity LED desc:'front-id-5' color:green = intensity 0% -> 100% 1592693500.291805:led_change_intensity LED desc:'front-power-3' color:gre= en intensity 100% -> 0% 1592693500.312041:led_change_intensity LED desc:'front-power-3' color:gre= en intensity 0% -> 100% 1592693500.821254:led_change_intensity LED desc:'front-power-3' color:gre= en intensity 100% -> 0% 1592693501.331517:led_change_intensity LED desc:'front-power-3' color:gre= en intensity 0% -> 100% 1592693501.841367:led_change_intensity LED desc:'front-power-3' color:gre= en intensity 100% -> 0% 1592693502.350839:led_change_intensity LED desc:'front-power-3' color:gre= en intensity 0% -> 100% 1592693502.861134:led_change_intensity LED desc:'front-power-3' color:gre= en intensity 100% -> 0% 1592693503.371090:led_change_intensity LED desc:'front-power-3' color:gre= en intensity 0% -> 100% We notice the front-power LED starts to blink at a ~2Hz rate. Reviewed-by: Richard Henderson Reviewed-by: Luc Michel Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: C=C3=A9dric Le Goater Message-Id: <20200912134041.946260-5-f4bug@amsat.org> --- hw/arm/aspeed.c | 20 ++++++++++++++++++++ hw/arm/Kconfig | 1 + 2 files changed, 21 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index bdb981d2f87..0ef3f6b412f 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -20,6 +20,7 @@ #include "hw/i2c/smbus_eeprom.h" #include "hw/misc/pca9552.h" #include "hw/misc/tmp105.h" +#include "hw/misc/led.h" #include "hw/qdev-properties.h" #include "qemu/log.h" #include "sysemu/block-backend.h" @@ -525,9 +526,20 @@ static void sonorapass_bmc_i2c_init(AspeedMachineState= *bmc) =20 static void witherspoon_bmc_i2c_init(AspeedMachineState *bmc) { + static const struct { + unsigned gpio_id; + LEDColor color; + const char *description; + bool gpio_polarity; + } pca1_leds[] =3D { + {13, LED_COLOR_GREEN, "front-fault-4", GPIO_POLARITY_ACTIVE_LOW}, + {14, LED_COLOR_GREEN, "front-power-3", GPIO_POLARITY_ACTIVE_LOW}, + {15, LED_COLOR_GREEN, "front-id-5", GPIO_POLARITY_ACTIVE_LOW}, + }; AspeedSoCState *soc =3D &bmc->soc; uint8_t *eeprom_buf =3D g_malloc0(8 * 1024); DeviceState *dev; + LEDState *led; =20 /* Bus 3: TODO bmp280@77 */ /* Bus 3: TODO max31785@52 */ @@ -538,6 +550,14 @@ static void witherspoon_bmc_i2c_init(AspeedMachineStat= e *bmc) aspeed_i2c_get_bus(&soc->i2c, 3), &error_fatal); =20 + for (size_t i =3D 0; i < ARRAY_SIZE(pca1_leds); i++) { + led =3D led_create_simple(OBJECT(bmc), + pca1_leds[i].gpio_polarity, + pca1_leds[i].color, + pca1_leds[i].description); + qdev_connect_gpio_out(dev, pca1_leds[i].gpio_id, + qdev_get_gpio_in(DEVICE(led), 0)); + } i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 4), "tmp423", 0x= 4c); i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 5), "tmp423", 0x= 4c); =20 diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 7d040827af4..70e275cafda 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -404,6 +404,7 @@ config ASPEED_SOC select TMP105 select TMP421 select UNIMP + select LED =20 config MPS2 bool --=20 2.26.2