From nobody Mon Nov 17 07:58:03 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603728382; cv=none; d=zohomail.com; s=zohoarc; b=PVUCekzmvz2pQnx8yyeWUTYOZhpY7osUFT619Ol3zGAdi4DThfWO1uVuESpXNH03MBrrvzVzTORUhN8ImozSnQDzkmQCqYnIoEGtWeViy8zl5+AVCete5czMwA75USNnqAuTJkucyY2OzslC2nhC9VGooEnS/WXnsA7lgzUzG3o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603728382; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LEuLy70bO9rGKypxbnX7ZHoOi/nKsVsUSyciGbs1XDI=; b=ZInVyPDn5fydun3jUA7og6nnvDUzB2MPC81QSVL9zJVkhzPiZCPleXdWf3phI864HHbMXhaiXjZAi7uls1WbI+55HyIzFWxS3oG213SMdliqFD8aJaPvxgOIWz+QaaghZxBwOs143hMTeLKgwkvbd6OyS4BrCHcVpEMdzYE7nk0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603728382471990.9041783187212; Mon, 26 Oct 2020 09:06:22 -0700 (PDT) Received: from localhost ([::1]:43696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX50m-00062J-Rf for importer@patchew.org; Mon, 26 Oct 2020 12:06:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX4xA-0002zN-K1 for qemu-devel@nongnu.org; Mon, 26 Oct 2020 12:02:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:42336) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kX4x8-0005ra-JV for qemu-devel@nongnu.org; Mon, 26 Oct 2020 12:02:36 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-340-6F21LJZROjSmqDZEzbvP-Q-1; Mon, 26 Oct 2020 12:02:29 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 703921060B73; Mon, 26 Oct 2020 16:02:27 +0000 (UTC) Received: from localhost (ovpn-114-214.ams2.redhat.com [10.36.114.214]) by smtp.corp.redhat.com (Postfix) with ESMTP id 04D8E5C1BB; Mon, 26 Oct 2020 16:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603728153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LEuLy70bO9rGKypxbnX7ZHoOi/nKsVsUSyciGbs1XDI=; b=VGNvagA7sfEwjcSEhTDBatNPr1ATJlHb5+Z7hs7AYG1rrkZ0MemxcHNXWsay8E4+V6eNMu A68dqKdj9jaPR64wsE4Kyn+YRrDb1kSvOE6CqO5IIccK6XYkTIf4LzB1hVv/iK6fvGiAfA NLphWYRVGnOed6PZjL6wB7a+IaizHQM= X-MC-Unique: 6F21LJZROjSmqDZEzbvP-Q-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PULL v2 1/2] trace/simple: Enable tracing on startup only if the user specifies a trace option Date: Mon, 26 Oct 2020 16:02:20 +0000 Message-Id: <20201026160221.62704-2-stefanha@redhat.com> In-Reply-To: <20201026160221.62704-1-stefanha@redhat.com> References: <20201026160221.62704-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/25 21:03:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Josh DuBois , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Josh DuBois Tracing can be enabled at the command line or via the monitor. Command-line trace options are recorded during trace_opt_parse(), but tracing is not enabled until the various front-ends later call trace_init_file(). If the user passes a trace option on the command-line, remember that and enable tracing during trace_init_file(). Otherwise, trace_init_file() should record the trace file specified by the frontend and avoid enabling traces until the user requests them via the monitor. This fixes 1b7157be3a8c4300fc8044d40f4b2e64a152a1b4 and also db25d56c014aa1a96319c663e0a60346a223b31e, by allowing the user to enable traces on the command line and also avoiding unwanted trace- files when the user has not asked for them. Fixes: 1b7157be3a8c4300fc8044d40f4b2e64a152a1b4 Signed-off-by: Josh DuBois Message-id: 20200816174610.20253-1-josh@joshdubois.com Signed-off-by: Stefan Hajnoczi --- trace/control.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/trace/control.c b/trace/control.c index b35e512dce..5669db7eea 100644 --- a/trace/control.c +++ b/trace/control.c @@ -39,6 +39,7 @@ static TraceEventGroup *event_groups; static size_t nevent_groups; static uint32_t next_id; static uint32_t next_vcpu_id; +static bool init_trace_on_startup; =20 QemuOptsList qemu_trace_opts =3D { .name =3D "trace", @@ -225,7 +226,9 @@ void trace_init_file(const char *file) { #ifdef CONFIG_TRACE_SIMPLE st_set_trace_file(file); - st_set_trace_file_enabled(true); + if (init_trace_on_startup) { + st_set_trace_file_enabled(true); + } #elif defined CONFIG_TRACE_LOG /* * If both the simple and the log backends are enabled, "--trace file" @@ -299,6 +302,7 @@ char *trace_opt_parse(const char *optarg) } trace_init_events(qemu_opt_get(opts, "events")); trace_file =3D g_strdup(qemu_opt_get(opts, "file")); + init_trace_on_startup =3D true; qemu_opts_del(opts); =20 return trace_file; --=20 2.26.2 From nobody Mon Nov 17 07:58:03 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603728861; cv=none; d=zohomail.com; s=zohoarc; b=DUn6XQo+lFtK3/VaUTbQrEUUbbrZaeVI5yM8FsdVs7727uYU75gH+2mDN4BxdyjJv5SWuUCwp6IZeS/RwB7JgphgixIjK7QDPnGFnLKEABf1P2lwVCptDcCVGP+vrmbQIT1N2WL6ZmQV0MQEV9wfDwT2GKgxg6GaCOeC77bQITI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603728861; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zn+pN59A0gckCjOQnh1z+idcXSYHD9BQQ2+zwP6kiYk=; b=fVapBIigt/cAAtL5ldw8/JJgYsk7GhXwMXgIKM9GHj39WPPL/FwzIXszhZ3POzwwNRh0itu0t9KJ0cveM+HolvBgXyYcTfVsG6jZ1YjSoBDA2NYg0hJUj8fqJhlrb/NENoh47dvTPH7lq3J3bHYAf61rO/f04CrKgeSJvaUMpHM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603728861791491.0783124373546; Mon, 26 Oct 2020 09:14:21 -0700 (PDT) Received: from localhost ([::1]:37940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX58W-0007FZ-Pv for importer@patchew.org; Mon, 26 Oct 2020 12:14:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX4xK-0003Bw-9Y for qemu-devel@nongnu.org; Mon, 26 Oct 2020 12:02:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kX4xI-0005sO-JQ for qemu-devel@nongnu.org; Mon, 26 Oct 2020 12:02:45 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-97-LFyCPfhVOgSLB47XSHU4PQ-1; Mon, 26 Oct 2020 12:02:33 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D01018C9F46; Mon, 26 Oct 2020 16:02:32 +0000 (UTC) Received: from localhost (ovpn-114-214.ams2.redhat.com [10.36.114.214]) by smtp.corp.redhat.com (Postfix) with ESMTP id 048035B4A4; Mon, 26 Oct 2020 16:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603728163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zn+pN59A0gckCjOQnh1z+idcXSYHD9BQQ2+zwP6kiYk=; b=BBQ+eCSQc/D6I9C4h2QMVjiDENz2+TlJmIlAa1SOzzOVIa2LUEFdCNRbRQE/laHkov7S0f 5IurrTZmGOVxcxMGsmQt/Z+6DGxPmtwWrLxSRz2XvQLy0ESOgAmCa8bqetGNfPKR0kAlNU cvja4LhxHsRTg+yWOfSt6ui56JXKN4E= X-MC-Unique: LFyCPfhVOgSLB47XSHU4PQ-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PULL v2 2/2] Add execute bit back to scripts/tracetool.py Date: Mon, 26 Oct 2020 16:02:21 +0000 Message-Id: <20201026160221.62704-3-stefanha@redhat.com> In-Reply-To: <20201026160221.62704-1-stefanha@redhat.com> References: <20201026160221.62704-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/26 02:39:09 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Anthony PERARD via Commit a81df1b68b65 ("libqemuutil, qapi, trace: convert to meson") removed it without explanation and it is useful to be able to run a script without having to figure out which interpreter to use. Signed-off-by: Anthony PERARD Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Message-Id: <20200923103620.1980151-1-anthony.perard@citrix.com> --- scripts/tracetool.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 =3D> 100755 scripts/tracetool.py diff --git a/scripts/tracetool.py b/scripts/tracetool.py old mode 100644 new mode 100755 --=20 2.26.2