From nobody Mon Nov 17 09:48:35 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603721275; cv=none; d=zohomail.com; s=zohoarc; b=KlSahngWZXXfSAUGYqWvxlsva9mceTpszOvL85B2ljZXgjteQTlyYuMIVNibpvvm4nC2UPPma6gvbXvmn48qpQ04wlGmCxR4hLYzSPXGVmSatGGviu9Nyf+Tido0uj5Pi4Q4zByiTh5k5E6wmlNpBNspvmqeaRCpKEO7ERWWkOI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603721275; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6zyuao6p7/K0jMw3GBouKUVe5X+y77/fWzKmTRdf6wc=; b=VWXQ1dllahj13Lq6k17nnaQ6DPNIRj18eYGNCoVDYjKK5I+MQV/SUjACgYGB81NGWKwVWFSMEd56LPQE8ZCt3c4iB4U0oxJeM2wNfjaWxDtooS//JIUol+S3MHp51yJmOxW0n+X/XFJcj3KF5ZIYTB8wtGIKVrYY2/7NzJ4JMf8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603721275465479.3415267461497; Mon, 26 Oct 2020 07:07:55 -0700 (PDT) Received: from localhost ([::1]:49492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX3AA-00073n-0Z for importer@patchew.org; Mon, 26 Oct 2020 10:07:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX2ut-0005x0-HL for qemu-devel@nongnu.org; Mon, 26 Oct 2020 09:52:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kX2ug-0001le-68 for qemu-devel@nongnu.org; Mon, 26 Oct 2020 09:52:07 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-323-nAhYQDOhMPWHdy7gjlfLnw-1; Mon, 26 Oct 2020 09:51:39 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2BBF81060BBF; Mon, 26 Oct 2020 13:51:38 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE11F1043268; Mon, 26 Oct 2020 13:51:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603720301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6zyuao6p7/K0jMw3GBouKUVe5X+y77/fWzKmTRdf6wc=; b=CmbbL1Xw4ChpKTSjZ2gYjDqOySfTVwPdDdyfkP+cLDg4p+b1B8ZfGiUlULvUg1t6FyVlMg v2aWAghfcHy25UWVrSUcIzwNyx2h7bfEn7nMFMoTniWX92nDDW6XaAPgRapCELLT/eLLIy eLb8BTe8tOM2sYK6XMxi1botujE4QX4= X-MC-Unique: nAhYQDOhMPWHdy7gjlfLnw-1 From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 14/17] win32: boot broken when bind & data dir are the same Date: Mon, 26 Oct 2020 09:51:28 -0400 Message-Id: <20201026135131.3006712-15-pbonzini@redhat.com> In-Reply-To: <20201026135131.3006712-1-pbonzini@redhat.com> References: <20201026135131.3006712-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/26 02:39:09 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sunil Muthuswamy Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Sunil Muthuswamy With upstream commit#ea1edcd7da1a "vl: relocate paths to data directories", the data dir logic was unified between POSIX & Win32. That patch moved to using 'get_relocated_path()', to find the data dir. There is a latent bug in get_relocated_path which can cause it to spin indefinitely, when the bind dir is the same as the passed in dir (in this case, it was the data dir). Signed-off-by: Sunil Muthuswamy Message-Id: Signed-off-by: Paolo Bonzini --- util/cutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cutils.c b/util/cutils.c index be4e43a9ef..c395974fab 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -949,7 +949,7 @@ char *get_relocated_path(const char *dir) bindir +=3D len_bindir; dir =3D next_component(dir, &len_dir); bindir =3D next_component(bindir, &len_bindir); - } while (len_dir =3D=3D len_bindir && !memcmp(dir, bindir, len_dir)); + } while (len_dir && len_dir =3D=3D len_bindir && !memcmp(dir, bindir, = len_dir)); =20 /* Ascend from bindir to the common prefix with dir. */ while (len_bindir) { --=20 2.26.2