From nobody Mon Nov 17 09:50:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) client-ip=209.85.128.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1603710219; cv=none; d=zohomail.com; s=zohoarc; b=PcLO8e9YsoFcV09CQOediOZsCDqpDER0EVHCV7onIyd+B1aybtmZev/Z6XPLUCbgbTchDdSipF+33ftSftQbjg7cFZOoWMyyqdztq/IEvvLuFq9MjjBcaLJRoSeGD/QjTYe61Inr7Ie1MHy0JpZfyh/GZhCrY16AEu53RCBqWoo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603710219; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CaEc+EndnthM/jQRSTritjVWMWjtPivpLOdnvFGKtOc=; b=RlcrcU0NS8nMrkamxj0ESgbwfHFrTkSd+6r5jQ34smcj5m7p8KKS+YIpceaW0tI3BsuLIVhs6hhHjgHtbazqhc26cf596fYebJO2jkDBDJW6O6qkwfQe7HwZBXnUUivJbQTmyEBqVBeRzVWi4BECFvcpA61GI025xebThowAUAU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.zohomail.com with SMTPS id 1603710219718330.9315457897304; Mon, 26 Oct 2020 04:03:39 -0700 (PDT) Received: by mail-wm1-f50.google.com with SMTP id k21so5445074wmi.1 for ; Mon, 26 Oct 2020 04:03:38 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id h4sm21987467wrv.11.2020.10.26.04.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 04:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CaEc+EndnthM/jQRSTritjVWMWjtPivpLOdnvFGKtOc=; b=B51UdXVNUMxIJXfJbtOeTXONrMoctRM+wW11QjE6H/PSYVoSRYayynce9vro6AfVkW 8GKbBCnOo1VvecTZaTVZq5fx962sOXz9AeSJvUPkKPiDpS6WQrKnR3CvGQjz+i1VjJ5x FyiHUtyctPri1rqi2p/OHAkFRFrBS6yqSBQRRiT5CcYnvGbvdkEqYcNLEbbPLwTsvC45 V1RdzZX7OxyPZG/Di85O8ZPk1EDt6fzwBObdQfj3s2Zhs8VWRqHai4EsOKIJFK+gt4pR JVsUcVGYGGBLKVdsKo7UbSL9vUJbzA5A4NYpR9qn/qHLDWRQnZVuwVjJRen/YeWHoGed I/dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=CaEc+EndnthM/jQRSTritjVWMWjtPivpLOdnvFGKtOc=; b=mHNI7sqO/dhHp4wYOZKcuuv+58xW//y4Rgw137KsrZZsBil3q+DOe/7X7flsj3FKHn SQuKRvSUfzsv/N5/F+uFmeNx+Ao5Y8BX00W3CYgpwn3WoILRc6kyiL/t7VpNQNa2ye1s yxvjTej/WPx0ZLoFkWYu2kiz3kxPjIPlZawHXXOabbcpJbAn+Yxb2E/JgLeSHaekiEmb c8YSxXd3X5pkxBvXGIT+FptC/ggPV0lFHT/rM5d8fC4VvqaOmNXsNGjxXdaldLrdiVIv fURIzY05+96Co0igBGeTn9njNJ/X8Oq3cYfNQp6/5pBcmPEXIf850qp6vycgBd4l6MFQ pEQw== X-Gm-Message-State: AOAM532Kj/dXRU6LKgs5WvAToKqCYtzvISm9gseUUXX2Hj9NGC/7GFSX GTxAs88iRWy55A7kxN8HG6w= X-Google-Smtp-Source: ABdhPJyF1JOQLXzJb3x+ZLCPuqMyMqIwI8BIc/uwm2/AcK/dwJkNka42hifUNxBvR6TNrLS6P3KkBg== X-Received: by 2002:a1c:2302:: with SMTP id j2mr15469805wmj.100.1603710217030; Mon, 26 Oct 2020 04:03:37 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, Peter Maydell , Alistair Francis Subject: [PULL 4/5] hw/sd/sdcard: Make iolen unsigned Date: Mon, 26 Oct 2020 12:03:14 +0100 Message-Id: <20201026110315.4026183-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026110315.4026183-1-f4bug@amsat.org> References: <20201026110315.4026183-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) I/O request length can not be negative. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Message-Id: <20200630133912.9428-15-f4bug@amsat.org> --- hw/sd/sd.c | 2 +- hw/sd/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index aa6059d2ad6..fcbc1fd9d6e 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1982,7 +1982,7 @@ uint8_t sd_read_byte(SDState *sd) { /* TODO: Append CRCs */ uint8_t ret; - int io_len; + uint32_t io_len; =20 if (!sd->blk || !blk_is_inserted(sd->blk) || !sd->enable) return 0x00; diff --git a/hw/sd/trace-events b/hw/sd/trace-events index 96c7ea5e52f..4140e485403 100644 --- a/hw/sd/trace-events +++ b/hw/sd/trace-events @@ -52,7 +52,7 @@ sdcard_unlock(void) "" sdcard_read_block(uint64_t addr, uint32_t len) "addr 0x%" PRIx64 " size 0x= %x" sdcard_write_block(uint64_t addr, uint32_t len) "addr 0x%" PRIx64 " size 0= x%x" sdcard_write_data(const char *proto, const char *cmd_desc, uint8_t cmd, ui= nt8_t value) "%s %20s/ CMD%02d value 0x%02x" -sdcard_read_data(const char *proto, const char *cmd_desc, uint8_t cmd, int= length) "%s %20s/ CMD%02d len %d" +sdcard_read_data(const char *proto, const char *cmd_desc, uint8_t cmd, uin= t32_t length) "%s %20s/ CMD%02d len %" PRIu32 sdcard_set_voltage(uint16_t millivolts) "%u mV" =20 # milkymist-memcard.c --=20 2.26.2