From nobody Mon Nov 17 09:50:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) client-ip=209.85.221.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1603710214; cv=none; d=zohomail.com; s=zohoarc; b=E2rBnuizNvzAdaghvzXx2y9GvRSVv6XB9zZcE/C3OUnt7SmEsrEan1cNuvcFUAGHFD4ptpsbKWkxsrNyEzfEYI7BdpQ2upqeKEUxG5mdsb+3fjKJpsvfudBSXteJ5aqTfDnym8u/Eeg34luwSSg/QhG88clTaSbFS+PcCeLo2YU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603710214; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3PqeCvMaRSfOqr/6xhOfmbV28LZjwldqha7vO+7WnUc=; b=Gj/odcY1qpAWC1B7Hu7MjmuCIRnIDB3b1rk5JmK1gF1RMARamqZktiQcxi7Hute2zBTo7JrpWv5j3cI1TTqPuwRrGws7zKZESuvoSjXKAWblCXvnbe1/PL9p1XCimT9EKezchA2NUQ3H0EExJr3MjvEqXtbq9fZHoS4TngHV3Is= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mx.zohomail.com with SMTPS id 16037102148431.784205821427804; Mon, 26 Oct 2020 04:03:34 -0700 (PDT) Received: by mail-wr1-f43.google.com with SMTP id b8so11944465wrn.0 for ; Mon, 26 Oct 2020 04:03:33 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (237.red-88-18-140.staticip.rima-tde.net. [88.18.140.237]) by smtp.gmail.com with ESMTPSA id d129sm20226273wmf.19.2020.10.26.04.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 04:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3PqeCvMaRSfOqr/6xhOfmbV28LZjwldqha7vO+7WnUc=; b=Dzfljq8fBMOykHo/ksRTTp5iGGkuIy5dPJHu6b4p5BLmM4tyMbfIvgS6BwRBgId/6l ImdPHDmN4/Uu4EV++mPxvJScZZpf3VcKyU8DlSJBxRMham/HvasbhKW2wvtLmgAcE/Tk 755Va/3x+YMrTaD35I+JHNuL35h0h3m/joSMHZZ9XmsPiG976L0+nnpDj08yKUfuvrhr fDDTTo66XCptH8gO5oI29S6m0kWBOXnU+F/3wBbnW8TzUBzzmg8ou3HhFxLi3VHomkiq swF6F+GOr7NHDKgJfyFRJxk6cjbv6+bN42MKhsSLm6HPvo3KOMdFDN3NnA/IBQsmvRxw 1KfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=3PqeCvMaRSfOqr/6xhOfmbV28LZjwldqha7vO+7WnUc=; b=NH4Grx3u2D1ChKAYqPx9Bski0zIwvzLKSBWg2DFi2kq2QbKA0lvA/XYA47n2dfQSLs T0ryyP7sp9hTUebTC29nxcAgerQC8lDZTP3I8R4Ba5QtoLDr0CrOfYsINGPQ7edwSHk2 EzMLM63PE10lWFpFVJd6uvWT29ippo6ugMZkdz0EpPY3Oq1yxKhYWGPYCpI1nE8HUgsi am2APoqu8kNZszMTDCKOFMVHHKcCbP4+DGoJR4+n3owconAQacyYj5ugnwE1R7/sUgO2 zDrQj1Dw7kUDCZOC4ZhkkJ0GFdWmi93YdbrC8xIsrvPDp52eY8aqNL62nl5GVXQyRpIU eWeA== X-Gm-Message-State: AOAM530pajU3+KAU/X3suPP67UTNTnsQSY9UTiAjmIGMlHCdFNzW3tmn oDVXCzpx3c3BQOmC7WGS62I= X-Google-Smtp-Source: ABdhPJxXPyQANOS53JmNBde6/D2k8al9tvWCuQLC+USjzFwj6ItTzX25RiIhbfb1ulBKL8GLsWuq6w== X-Received: by 2002:adf:ee4c:: with SMTP id w12mr16429071wro.22.1603710212265; Mon, 26 Oct 2020 04:03:32 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, Alistair Francis , Peter Maydell Subject: [PULL 3/5] hw/sd/sdcard: Constify sd_crc*()'s message argument Date: Mon, 26 Oct 2020 12:03:13 +0100 Message-Id: <20201026110315.4026183-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201026110315.4026183-1-f4bug@amsat.org> References: <20201026110315.4026183-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) CRC functions don't modify the buffer argument, make it const. Reviewed-by: Alistair Francis Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200630133912.9428-14-f4bug@amsat.org> --- hw/sd/sd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 5510a64401b..aa6059d2ad6 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -254,11 +254,11 @@ static const int sd_cmd_class[SDMMC_CMD_MAX] =3D { 7, 7, 10, 7, 9, 9, 9, 8, 8, 10, 8, 8, 8, 8, 8, 8, }; =20 -static uint8_t sd_crc7(void *message, size_t width) +static uint8_t sd_crc7(const void *message, size_t width) { int i, bit; uint8_t shift_reg =3D 0x00; - uint8_t *msg =3D (uint8_t *) message; + const uint8_t *msg =3D (const uint8_t *)message; =20 for (i =3D 0; i < width; i ++, msg ++) for (bit =3D 7; bit >=3D 0; bit --) { @@ -270,11 +270,11 @@ static uint8_t sd_crc7(void *message, size_t width) return shift_reg; } =20 -static uint16_t sd_crc16(void *message, size_t width) +static uint16_t sd_crc16(const void *message, size_t width) { int i, bit; uint16_t shift_reg =3D 0x0000; - uint16_t *msg =3D (uint16_t *) message; + const uint16_t *msg =3D (const uint16_t *)message; width <<=3D 1; =20 for (i =3D 0; i < width; i ++, msg ++) --=20 2.26.2